Marking invalid in scopes API since the problem was in the shell plugin
and got fixed.
** Changed in: unity-scopes-api (Ubuntu)
Status: Confirmed => Invalid
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to
This bug was fixed in the package unity-scopes-shell -
0.5.7+16.10.20160525-0ubuntu1
---
unity-scopes-shell (0.5.7+16.10.20160525-0ubuntu1) yakkety; urgency=medium
[ Gary.Wzl ]
* Stop typing timer when reset navigation tag(tapping cancel). Also
make sure relevant
Michi, your guess was correct, the shell doesn't set connectivity status
in ActionMetadata. Attached branch fixes that.
** Branch linked: lp:~stolowski/unity-scopes-shell/set-connectivity-
status-of-actionmetadata
--
You received this bug notification because you are a member of Ubuntu
Touch
Here is the code in QueryMetadata that set this:
it = var.find("internet_connectivity");
if (it != var.end())
{
internet_connectivity_ = it->second.get_bool() ?
QueryMetadata::Connected : QueryMetadata::Disconnected;
}
else
{
internet_connectivity_ =
You are always free to ignore the network status. It was moved in mainly
as a convenience feature, to allow a scope to immediately notice if, for
example, the device is in flight mode. Given the problems with
NetworkAccessManager (still not completely resolved), I would probably
interpret
It seems there are two issues here:
1) As noted, apparently ActionMetadata passed into PerformAction and
Activate methods is always Unknown
2) Network connectivity status should not be passed into the scope as an
enum because it can become stale and therefore can prevent a scope from
making good
@marcus: So yes, I would rather never see Unknown. But in any case I'd
like the state to be consistent when returned by the different metadata
objects. Is this still Incomplete?
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to
I see different network connectivity state reported from Search() and
from these: Activate(), Preview() and PerformAction().
I've written a simple golang scope [1] that shows the differences.
The scope has one result with SetInterceptAction(), so it goes to
Activate, then it goes to Preview()
Hmmm... This looks like the ActionMetadata that is passed in has an
uninitialised connectivity status. I'm not sure who's to blame here. It
might be the Go binding, or it might be shell.
** Changed in: unity-scopes-api (Ubuntu)
Status: Incomplete => Confirmed
** Changed in:
Kyle, do you see it returning unknown only before the first request, or
always (even after a successful request)? I'd try treating "unknown" as
"available" and see how that goes. There might still some weirdness in
NetworkAccessManager.
--
You received this bug notification because you are a
Problem: metadata.InternetConnectivity() is always returning 0 (for
Unknown), where: metadata is the pointer passed into Activate().
http://bazaar.launchpad.net/~unity-team/go-
unityscopes/v2/view/head:/metadata.go#L47
Don't know if this is a golang binding, c++ scope framework, unity8,
network
A problem is that the QueryMetadata.h file [1] and the public docs [2]
states that Unknown is one of the enum values. As such a scope dev needs
to handle the case.
Perhaps those texts should be modified to indicate "Unknown" will never
be the value, therefore sparing the dev the need to figure
@Michi
Hmmm, I expected lp to auto-link "comment #7" to the comment in this
bug, but that apparently didn't work:
https://bugs.launchpad.net/ubuntu/+source/unity-scopes-
api/+bug/1502282/comments/7
*If* it's possible for the shell to return "unknown", then yes I think
the shell should be
The discussion has derailed somewhat from the original issue, please
continue this elsewhere.
Coming back to this particular bug, we only provide the statuses
Connected and Disconnected to the scope from the shell. The Unknown
status is an uninitialised state and should never reach the scope.
Forgot to mention, but if you are interested in testing the silo 032 to
test behaviour changes (I'm happy to hear about experiences), you need
to add QT_EXCLUDE_GENERIC_BEARER=1 to /etc/environment.
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages,
It's clear the current Qt 5.4.1 has bugs related to this, but it's not
clear how to fix those without causing regressions. It should be useful
to experiment with the PPA https://launchpad.net/~ci-train-ppa-
service/+archive/ubuntu/landing-032/ and try how things work with that.
After upgrading
Who looks after the Weather app? Whoever it is, they should be involved.
Does anyone know?
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to unity-scopes-shell in
Ubuntu.
https://bugs.launchpad.net/bugs/1502282
Title:
> * the scope could assume the network is up, but this is dangerous if
it is not up
@Kyle: Why is it dangerous if it is not up?
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to unity-scopes-shell in
Ubuntu.
I agree with Kyle that "unknown" state is pretty useless, that said, as
it's defined by QNetworkAccessManager, we can't really get rid of it
without proposing a change to QNetworkAccessManager API. Thus I agree
with Michi that for now scopes and/or the scopes framework should treat
"unknown" the
@Kyle: If no network is available, the network indicator should show it,
I would think?
@Tony: I get the impression that treating "unknown" as "inaccessible" is
not the right thing to do. From what I can glean, it appears that QNAM
starts out in the "unknown" state and, once the first request has
@Michi, yes the network indicator would I presume show a no network
state. But the scope GUI itself would be in a state that could confuse a
user and lead to invalid bugs, like this one:
https://bugs.launchpad.net/today-scope/+bug/1507466
--
You received this bug notification because you are a
@Michi
I guess I look at this from NetworkManager's point of view. Your either
"connected" or you're not... The network indicator reflects this, it
shows the mobile data technology if connected to the mobile operator.
If WiFi is enabled, it works like the desktop. You can easily see the
state
> From the thread you posted on qtcentre.org in comment #7
I don't remember ever posting there. Do you have a link?
So, should the shell be doing what's suggested in the code example in
order to give a defined status to the scope?
--
You received this bug notification because you are a member
@Michi, "dangerous" in the sense that the user experience is broken, as
in, no "no network" result is posted, but also no actual results are
posted, so the user sees something that looks broken.
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which
I think the bug here is that you are seeing an Unknown status at all.
That shouldn't happen. The shell sets the connectivity status before it
dispatches queries, so you should only get Connected or Disconnected.
Unknown is really more of an uninitialised state.
Could you please point me to the
I strongly suspect that this may be related to this bug:
https://bugs.launchpad.net/ubuntu/+source/qtbase-opensource-
src/+bug/1470700
The shell would be victimised by this just as much as the thumbnailer.
--
You received this bug notification because you are a member of Ubuntu
Touch seeded
Yes. But, underneath it, I suspect that QNetworkAccessManager isOnline()
always returns false. (At least, that would be consistent with the
behavior we saw in the thumbnailer.) Marcus, on line 173,
Status::Unknown is mentioned.
Kyle, it's not clear from your original description whether you are
Michi, have a look at http://bazaar.launchpad.net/~unity-team/unity-
scopes-shell/trunk/view/head:/src/Unity/scope.cpp#L745
The scope should actually never receive scopes::SearchMetadata::Unknown.
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages,
FYI I was on holiday last week and will add info here soon.
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to unity-scopes-api in
Ubuntu.
https://bugs.launchpad.net/bugs/1502282
Title:
"unknown" connectivity status
The tri-state accessibility comes straight from QNetworkAccessManager:
http://doc.qt.io/qt-5/qnetworkaccessmanager.html#NetworkAccessibility-
enum
There is a discussion thread here: http://www.qtcentre.org/threads/37514
-use-of-QNetworkAccessManager-networkAccessible
I agree that the tri-state
The poor doc for QNetworkAccessManager isn't helping :-(
I get the impression that the unknown state is caused by lazy
initialisation: as long as no request has been sent yet, the state is
unknown and, after the first request, changes to accessible or
inaccessible as appropriate, until the
** Also affects: unity-scopes-shell (Ubuntu)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to unity-scopes-shell in
Ubuntu.
https://bugs.launchpad.net/bugs/1502282
Title:
Michi,
1) Yes I object to even the possibility of ever receiving an Unknown so I
proposed it be removed from the API
2) I have seen Unknowns in the past. However now I cannot reproduce.
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is
** Also affects: savilerow
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to unity-scopes-api in
Ubuntu.
https://bugs.launchpad.net/bugs/1502282
Title:
"unknown" connectivity
34 matches
Mail list logo
