[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

** Description changed: 1. $ lsb_release -rd Description: Ubuntu 17.10 Release: 17.10 2. $ apt-cache policy linux-image-`uname -r` linux-image-4.13.0-16-generic: - Installed: 4.13.0-16.19 - Candidate: 4.13.0-16.19 - Version table: - *** 4.13.0-16.19 500 - 500

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

** Changed in: linux (Ubuntu Xenial) Status: In Progress => Fix Committed ** Changed in: linux (Ubuntu Artful) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

** Merge proposal linked: https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/336871 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1729145 Title:

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

** Changed in: linux (Ubuntu Zesty) Status: In Progress => Won't Fix -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1729145 Title: /dev/bcache/by-uuid links not

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

** Changed in: systemd (Ubuntu Xenial) Status: New => Won't Fix ** Changed in: systemd (Ubuntu Zesty) Status: New => Won't Fix ** Changed in: systemd (Ubuntu Artful) Status: New => Won't Fix ** Changed in: systemd (Ubuntu Bionic) Status: Incomplete => Won't Fix --

Re: [Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

On Tue, Dec 12, 2017 at 5:52 AM, Dimitri John Ledkov wrote: > Once the kernel is fixed, are there any changes that are required to > systemd/udev? > No changes needed. > > ** Changed in: systemd (Ubuntu Bionic) >Status: New => Incomplete > > -- > You received

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

Once the kernel is fixed, are there any changes that are required to systemd/udev? ** Changed in: systemd (Ubuntu Bionic) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu.

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

** Changed in: linux (Ubuntu Xenial) Status: Triaged => In Progress ** Changed in: linux (Ubuntu Xenial) Assignee: (unassigned) => Joseph Salisbury (jsalisbury) ** Changed in: linux (Ubuntu Zesty) Status: Triaged => In Progress ** Changed in: linux (Ubuntu Zesty)

Re: [Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

Confirmed bionic works as expected. I suspect you can send that upstream with my SoB faster than I can. Definitely interested in seeing if they'll take something like that. On Thu, Dec 7, 2017 at 1:21 PM, Joseph Salisbury < joseph.salisb...@canonical.com> wrote: > Thanks for testing and the

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

Submitted SRU requests: https://lists.ubuntu.com/archives/kernel-team/2017-December/088680.html https://lists.ubuntu.com/archives/kernel-team/2017-December/088682.html -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

Thanks for testing and the patch, Ryan. I can submit and SRU request. We should also send this upstream for inclusion in the mainline kernel. Is that something you think you can do? If not, I can do it for you. -- You received this bug notification because you are a member of Ubuntu Touch

Re: [Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

Tested the xenial update. I had one boot where the links didn't get created, but I cannot recreate that issue now. On Thu, Dec 7, 2017 at 9:56 AM, Ryan Harper wrote: > Here's the Zesty test; all looks good. > > ubuntu@ubuntu:~$ cat /etc/cloud/build.info > build_name:

Re: [Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

Here's the Zesty test; all looks good. ubuntu@ubuntu:~$ cat /etc/cloud/build.info build_name: server serial: 20171207 ubuntu@ubuntu:~$ uname -a Linux ubuntu 4.10.0-40-generic #44~lp1729145 SMP Wed Dec 6 16:21:45 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux ubuntu@ubuntu:~$ tree /dev/bcache /dev/bcache

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

I built Xenial, Zesty and Bionic test kernels with your patch. They can also be downloaded from: http://kernel.ubuntu.com/~jsalisbury/lp1729145/ Can those that can reproduce this bug give this test kernel a try? Zesty required upstream commit 4b758df21 as a prereq. Zesty never got it, since

Re: [Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

Thanks for doing the cleanup; Patch looks good and I approve. Signed-off-by: Ryan Harper On Tue, Dec 5, 2017 at 4:59 PM, Joseph Salisbury < joseph.salisb...@canonical.com> wrote: > In the final patch we submit for SRU, it will also include your Signed- > off-by, I

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

I attached an update to your patch, Ryan. I added a subject, commit log and couple of missing semi colons / parenthesis. Can you look it over and see if you approve of the log and subject? I'll see if it applies to the other Ubuntu releases and builds on them as well. ** Patch added:

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

In the final patch we submit for SRU, it will also include your Signed- off-by, I just forgot to add it in the attached one. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu.

Re: [Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

Woot! I think that did the trick. ubuntu@ubuntu:~$ cat /etc/cloud/build.info build_name: server serial: 20171122 ubuntu@ubuntu:~$ lsb_release -rd Description: Ubuntu 17.10 Release: 17.10 ubuntu@ubuntu:~$ set -o vi ubuntu@ubuntu:~$ dpkg --list | grep linux-image ii linux-image-4.13.0-17-generic

Re: [Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

Thanks! I'll give it a try today. On Tue, Dec 5, 2017 at 3:43 PM, Joseph Salisbury < joseph.salisb...@canonical.com> wrote: > I built an Artful test kernel with the path provided by Ryan. The test > kernel can be downloaded from: > > http://kernel.ubuntu.com/~jsalisbury/lp1729145/ > > Can

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

I built an Artful test kernel with the path provided by Ryan. The test kernel can be downloaded from: http://kernel.ubuntu.com/~jsalisbury/lp1729145/ Can those that can reproduce this bug give this test kernel a try? -- You received this bug notification because you are a member of Ubuntu

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

Revised patch, should fix error with kfree on env ** Patch added: "bcache_always_emit_backing_dev_change_uevent_v2.diff" https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1729145/+attachment/5018329/+files/bcache_always_emit_backing_dev_change_uevent_v2.diff -- You received this bug

Re: [Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

Looks like those two kfree's in dev_run can be dropped since that was an exit after kmalloc'ing env entries which are now only done in bch_cached_dev_emit_change() which is only called by dev_run after it knows that the device is not yet running. On Mon, Dec 4, 2017 at 11:35 AM, Ryan Harper

Re: [Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

Hi Joseph, Sorry, I didn't give that a compile either; I just wanted to show what the change could look like; Let me see if I can get that to at least compile. On Mon, Dec 4, 2017 at 11:18 AM, Joseph Salisbury < joseph.salisb...@canonical.com> wrote: > It looks like env[] was declared in

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

It looks like env[] was declared in bch_cached_dev_emit_change(), but not in bch_cached_dev_run(). -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1729145 Title:

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

@Ryan I tried to build an Artful test kernel with your patch. However, there were compilation errors: ubuntu-artful/drivers/md/bcache/super.c:868:9: error: 'env' undeclared (first use in this function); did you mean '_end'? kfree(env[1]); ^~~ _end Did you have any issues

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

** Tags removed: kernel-da-key ** Tags added: kernel-key -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1729145 Title: /dev/bcache/by-uuid links not created after reboot

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

The attachment "bcache_always_emit_backing_dev_change_uevent.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

Untested patch. Hoping to convey the change that's needed. - decouple emitting a cached_dev CHANGE uevent which includes dev.uuid and dev.label from bch_cached_dev_run() which only happens when a bcacheX device is bound to the actual backing block device (bcache0 -> vdb) - update

Re: [Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

Dec 01 05:07:25.679368 ubuntu systemd-udevd[474]: LINK 'disk/by-uuid/0a270acb-56b8-4498-8bad-b3bb149fe869' /lib/udev/rules.d/60-persistent-storage.rules:79 Dec 01 05:07:25.683008 ubuntu systemd-udevd[474]: WARK: dev_old_name=/dev/bcache/by-uuid/92d882d8-38cd-4537-847b-6f9c40ba67b4

Re: [Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

It looks like there is some ordering issues: This is a grep through /run/udev/links ; these are checked by udev-dev # find . -name 'b250*' ./\x2fdisk\x2fby-uuid\x2f0a270acb-56b8-4498-8bad-b3bb149fe869/b250:1 ./\x2fdisk\x2fby-uuid\x2f92b0868d-7e56-4956-8e55-2c90ebee4a72/b250:0

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

Looks like masking systemd-udevd removes this behavior. Need to figure out where it actually clears everything out. ubuntu@maas-xenial4:~$ sudo systemctl mask systemd-udevd 11:32 PM Created symlink from /etc/systemd/system/systemd-udevd.service to /dev/null. # reboot ubuntu@maas-xenial4:~$ ls

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

Ryan, As discussed in IRC, I tweaked locations for testing in #11 and added all paths in #14. Looks like after `mount -n -o move /dev ${rootmnt}/dev` ${rootmnt}/dev has the proper content (see the bcache rule as well) https://paste.ubuntu.com/26082611/ == before == lrwxrwxrwx113

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

** Bug watch added: Debian Bug tracker #844775 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=844775 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1729145 Title:

Re: [Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

Investigating why /dev doesn't have the correct links even if they're present led me to look at /usr/share/initramfs-tools/scripts/init-bottom/udev (provided via the udev dpkg from systemd) In there, the mount -n -o move is used to migrate the /dev from initramfs to the rootfs/dev This bug:

Re: [Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

So, /dev/bcache/by-uuid is not getting created. That's the same kernel bug I filed. And, if they were, I think they'd get moved properly. init-bottom/udev script does the following: # Stop udevd, we'll miss a few events while we run init, but we catch up udevadm control --exit # move the /dev

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

Just in case also checked with this rule that creates links at /dev /dev/disk/by-uuid /dev/bcache/by-uuid https://paste.ubuntu.com/26081756/ They are all there originally (see the screenshot). But not there afterwards. So it's not just a problem with a different path.

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

After booting with break=bottom kernel parameter I can see that symlinks are in fact present at the initramfs stage. They are gone afterwards post pivot_root & systemd start (the bcache dir isn't even present while it was there) ubuntu@maas-xenial4:~$ ls /dev/disk/ by-dname by-id by-label

[Touch-packages] [Bug 1729145] Re: /dev/bcache/by-uuid links not created after reboot

Let's assume there is a systemd fault here too, thus marking systemd as affected. I will try to play around with this, but may get to this by December 14th the earliest. ** Also affects: systemd (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because