Reviewed: https://review.openstack.org/623564
Committed:
https://git.openstack.org/cgit/openstack/sqlalchemy-migrate/commit/?id=231a4d2ae9f8496cfc8eea2e6bb8186a0dd602f9
Submitter: Zuul
Branch:master
commit 231a4d2ae9f8496cfc8eea2e6bb8186a0dd602f9
Author: Corey Bryant
Date: Fri Dec 7 13:49
** Changed in: sqlalchemy-migrate
Status: New => In Progress
** Changed in: sqlalchemy-migrate
Assignee: (unassigned) => Corey Bryant (corey.bryant)
** Changed in: sqlalchemy-migrate
Importance: Undecided => High
--
You received this bug notification because you are a member of U
Steps to reproduce using a Fedora container, courtesy of sean-k-mooney.
#create fedora29 docker container or use a fedora 29 host
sudo docker run --rm -it fedora bash
# recreate bug
yum install -y tox git python2-devel libffi-devel make gcc
cd ~
git clone http://github.com/openstack/nova
cd nova/
For what it's worth, I'm seeing this issue on Fedora 29 too with SQLite
3.26.0. Downgrading to 3.24.0 resolves things. Time to get some movement
on that patch.
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to sqlite3 in Ubuntu.
This bug was fixed in the package cinder -
2:14.0.0~b1~git2018120609.2cd694046-0ubuntu1
---
cinder (2:14.0.0~b1~git2018120609.2cd694046-0ubuntu1) disco; urgency=medium
* d/tests/control, d/tests/cinder-daemons, d/tests/cinder-volume: Switch to
using mysql-server databases in aut
This bug was fixed in the package nova -
2:19.0.0~b1~git2018120609.c9dca64fa6-0ubuntu1
---
nova (2:19.0.0~b1~git2018120609.c9dca64fa6-0ubuntu1) disco; urgency=medium
* d/tests/control, d/tests/nova-daemons: Switch to using mysql-server
databases in autopkgtests.
* New upstream
This bug was fixed in the package migrate - 0.11.0-3ubuntu1
---
migrate (0.11.0-3ubuntu1) disco; urgency=medium
* d/p/use-legacy-alter-sqlite.patch: Cherry-picked from upstream
gerrit review (https://review.openstack.org/#/c/623564/) to ensure
compatability with sqlite >= 3.
** Changed in: cinder (Ubuntu)
Status: Invalid => Triaged
** Changed in: cinder (Ubuntu)
Importance: Undecided => High
** Changed in: nova (Ubuntu)
Status: Invalid => Triaged
** Changed in: nova (Ubuntu)
Importance: Undecided => High
--
You received this bug notification be
Upstream PR: https://review.openstack.org/#/c/623564/
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to sqlite3 in Ubuntu.
https://bugs.launchpad.net/bugs/1807262
Title:
stein unit tests fail with sqlalchemy.exc.NoSuchTableEr
I've moved ahead with an upstream PR and will be uploading to Ubuntu
shortly with a patch/bug to Debian.
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to sqlite3 in Ubuntu.
https://bugs.launchpad.net/bugs/1807262
Title:
stei
** Also affects: sqlalchemy-migrate
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to sqlite3 in Ubuntu.
https://bugs.launchpad.net/bugs/1807262
Title:
stein unit tests fail with sq
Laszlo, I just tested with the updates you posted in comment #8 and it
works. \o/
** Also affects: migrate (Ubuntu)
Importance: Undecided
Status: New
** Changed in: migrate (Ubuntu)
Status: New => Triaged
** Changed in: migrate (Ubuntu)
Importance: Undecided => High
** Chang
Laszlo, that fix seems reasonable. Do you want to push on getting that
into migrate and uploaded to Debian or would you like one of us to
handle it? Thanks again for the quick responses on this.
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which
Indentation is messed up during the post, but easy to correct if you see
the source of the migrate/changeset/databases/sqlite.py file.
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to sqlite3 in Ubuntu.
https://bugs.launchpad.n
It's 'PRAGMA legacy_alter_table = ON' and the following change in
src:migrate (0.11.0 version) might do the trick.
@@ -9,6 +9,7 @@ except ImportError: # Python 2
from UserDict import DictMixin
from copy import copy
import re
+import sqlite3
from sqlalchemy.databases import sqlite as sa_b
Christian, thanks for all the digging! I just ran a successful test
against sqlite 3.26.0-2 package rebuilt with
2defce45c5670e0258374eeb2e293fcf6f82bddd reverted. That's the only
change I made and it seems to resolve the issue. Now to figure out if
that patch is fine and we really need to update P
quoting; ... so that when "PRAGMA legacy_alter_table" is set behaviour
is still compatible with versions 3.24 and earlier).
WTH where would/should we set that PRAGMA?
I think that would be in sqlalchemy's sqlite backend?
Coreybc can you take over from here?
--
You received this bug notification
git bisect start
# good: [cbb6e4f7de0115395269860fed18d56beb7ac2bb] Version 3.24.0
git bisect good cbb6e4f7de0115395269860fed18d56beb7ac2bb
# bad: [d4f098763eb4fd12a99497340e2f589b37234676] Version 3.26.0
git bisect bad d4f098763eb4fd12a99497340e2f589b37234676
# good: [bf92c08976ad16818be09a6941995
Oh yeah sqlite uses special repository software - thanks :-/
But there is https://github.com/mackyle/sqlite/commits/master
I wrote a build and test script that worked against 3.24 and 3.26 from
git confirming the results.
Kicking that in git bisect to hopefully be able to pick up some insight
lat
As we knew from the logs already the issue is raised to "db_sync" at
/usr/lib/python3/dist-packages/oslo_db/sqlalchemy/migration.py:81
that is:
test.py:setUp -> test.py::Database:__init__ -> db/migration.py:db_sync ->
oslo_db/sqlalchemy/migration.py:81
The __init__ suppresses logging for tests,
Hrm, this is not my homest of home turfs :-/
- tox based test calling (as mentioned upstream) blocks on pip install
- the python3-stestr based test fails to find resources when stripped
This works:
$ pkgos-dh_auto_test --no-py2
"cinder.tests.unit.api.contrib.test_volume_type_encryption.VolumeType
FYI there is [1] now (since an hour), which is building atm.
The delta added is [2] to
The code that seems to be related and not working is not using a view, but who
knows [3]
self.append('ALTER TABLE %s RENAME TO migration_tmp' % table_name)
(If that is the right code at all, I need to check
** Also affects: sqlite3 (Ubuntu)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to sqlite3 in Ubuntu.
https://bugs.launchpad.net/bugs/1807262
Title:
stein unit tests fail with sqla
23 matches
Mail list logo
