[Touch-packages] [Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-10-11 Thread Michael Nazzareno Trimarchi
** Changed in: wpa (Ubuntu)
 Assignee: (unassigned) => Michael Nazzareno Trimarchi 
(michael-t16qijz8x59bnuup5)

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to wpa in Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

Status in wpa package in Ubuntu:
  New

Bug description:
  dbus-send is able to read the properties of interface using GetAll. Those 
information include interface name, status, encryption method, etc. 
  The regression was introduced when someone try to have the Station attribute 
supported

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-10-10 Thread Michael Nazzareno Trimarchi
The attach is a debdiff. If it's not fine let me know

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to wpa in Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

Status in wpa package in Ubuntu:
  New

Bug description:
  dbus-send is able to read the properties of interface using GetAll. Those 
information include interface name, status, encryption method, etc. 
  The regression was introduced when someone try to have the Station attribute 
supported

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1899263] [NEW] Broken dbus GetAll message to wpa supplicant interface properties

2020-10-10 Thread Michael Nazzareno Trimarchi
Public bug reported:

dbus-send is able to read the properties of interface using GetAll. Those 
information include interface name, status, encryption method, etc. 
The regression was introduced when someone try to have the Station attribute 
supported

** Affects: wpa (Ubuntu)
 Importance: Undecided
 Status: New

** Patch added: "Fix dbus GetAll Interface on interface attribute"
   
https://bugs.launchpad.net/bugs/1899263/+attachment/5420443/+files/fix-dbus-debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to wpa in Ubuntu.
https://bugs.launchpad.net/bugs/1899263

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

Status in wpa package in Ubuntu:
  New

Bug description:
  dbus-send is able to read the properties of interface using GetAll. Those 
information include interface name, status, encryption method, etc. 
  The regression was introduced when someone try to have the Station attribute 
supported

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899263/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1899262] [NEW] Broken dbus GetAll message to wpa supplicant interface properties

2020-10-10 Thread Michael Nazzareno Trimarchi
Public bug reported:

dbus-send is able to read the properties of interface using GetAll. Those 
information include interface name, status, encryption method, etc. 
The regression was introduced when someone try to have the Station attribute 
supported

** Affects: wpa (Ubuntu)
 Importance: Undecided
 Status: New

** Patch added: "Fix dbus GetAll Interface on interface attribute"
   
https://bugs.launchpad.net/bugs/1899262/+attachment/5420442/+files/fix-dbus-debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to wpa in Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

Status in wpa package in Ubuntu:
  New

Bug description:
  dbus-send is able to read the properties of interface using GetAll. Those 
information include interface name, status, encryption method, etc. 
  The regression was introduced when someone try to have the Station attribute 
supported

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-10-11 Thread Michael Nazzareno Trimarchi
** Patch added: 
"0001-dbus-Fix-GetAll-message-if-ap_ifaces-are-not-availab.patch"
   
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+attachment/5420793/+files/0001-dbus-Fix-GetAll-message-if-ap_ifaces-are-not-availab.patch

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to wpa in Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

Status in wpa package in Ubuntu:
  New

Bug description:
  dbus-send is able to read the properties of interface using GetAll. Those 
information include interface name, status, encryption method, etc. 
  The regression was introduced when someone try to have the Station attribute 
supported

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-10-14 Thread Michael Nazzareno Trimarchi
wpa_supplicant exponse properties of the interface that you can read
using dbus command such as. Now if the property is empy you should just
expose as empty and not fail as it is in the code.

sudo dbus-send --system --print-reply --dest=fi.w1.wpa_supplicant1
/fi/w1/wpa_supplicant1/Interfaces/1
org.freedesktop.DBus.Properties.GetAll
string:fi.w1.wpa_supplicant1.Interface

This kind of interface is used by other network services aka connman. I
have tested on ubuntu-core and ubuntu 18.04

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to wpa in Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

Status in wpa package in Ubuntu:
  New

Bug description:
  dbus-send is able to read the properties of interface using GetAll. Those 
information include interface name, status, encryption method, etc. 
  The regression was introduced when someone try to have the Station attribute 
supported

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-12-01 Thread Michael Nazzareno Trimarchi
@Sebastien I will test it today. Sorry for the delay

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to wpa in Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

Status in wpa package in Ubuntu:
  Fix Released
Status in wpa source package in Bionic:
  Fix Committed

Bug description:
  * Impact
  One of the distro patch is incorrect and create issues when trying to query 
dbus properties

  * Test Case

  $ sudo dbus-send --system --print-reply --dest=fi.w1.wpa_supplicant1
  /fi/w1/wpa_supplicant1/Interfaces/1
  org.freedesktop.DBus.Properties.GetAll
  string:fi.w1.wpa_supplicant1.Interface

  shouldn't error out

  (the /1 reflect the interface number and could be a different value,
  check with d-feet if needed)

  * Regression potential

  The fixes is in the dbus interface, check that communication with
  desktop clients (indicator, applet, settings) still works correctly,
  returning expected informations on the signal, etc

  -

  dbus-send is able to read the properties of interface using GetAll. Those 
information include interface name, status, encryption method, etc.
  The regression was introduced when someone try to have the Station attribute 
supported

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-11-03 Thread Michael Nazzareno Trimarchi
As I said Interfaces/1 or /2 or /3 depends on how they are enumerated.
That is just an example

Using d-feet to find your interface. Today is /4 on my laptop (and must
be a wifi)

** Attachment added: "Screenshot from 2020-11-03 17-25-40.png"
   
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+attachment/5430694/+files/Screenshot%20from%202020-11-03%2017-25-40.png

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to wpa in Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

Status in wpa package in Ubuntu:
  New

Bug description:
  dbus-send is able to read the properties of interface using GetAll. Those 
information include interface name, status, encryption method, etc. 
  The regression was introduced when someone try to have the Station attribute 
supported

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-11-03 Thread Michael Nazzareno Trimarchi
debdiff show the difference between the 18.04 ubuntu. In the 20.04 wpa
supplicant was bump to newer version so station attribute was added in
the right way

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to wpa in Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

Status in wpa package in Ubuntu:
  New

Bug description:
  dbus-send is able to read the properties of interface using GetAll. Those 
information include interface name, status, encryption method, etc. 
  The regression was introduced when someone try to have the Station attribute 
supported

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-11-03 Thread Michael Nazzareno Trimarchi
Are you using ubuntu 18.04? or are you using Focal Fossa?

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to wpa in Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

Status in wpa package in Ubuntu:
  New

Bug description:
  dbus-send is able to read the properties of interface using GetAll. Those 
information include interface name, status, encryption method, etc. 
  The regression was introduced when someone try to have the Station attribute 
supported

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-10-22 Thread Michael Nazzareno Trimarchi
dbus getAll let you to download information of any interface. Each
interface has a reference number inside the wpa_supplicant. In my laptop
my wifi is interface 1. In order to ready wifi interface information I
can use dbus as shown in this example:

sudo dbus-send --system --print-reply --dest=fi.w1.wpa_supplicant1
/fi/w1/wpa_supplicant1/Interfaces/1
org.freedesktop.DBus.Properties.GetAll
string:fi.w1.wpa_supplicant1.Interface

The result of the command give you the an answer like:

sudo dbus-send --system --print-reply --dest=fi.w1.wpa_supplicant1 
/fi/w1/wpa_supplicant1/Interfaces/1 org.freedesktop.DBus.Properties.GetAll 
string:fi.w1.wpa_supplicant1.Interface
[sudo] password for michael: 
method return time=1603398113.528196 sender=:1.4 -> destination=:1.267 
serial=476 reply_serial=2
   array [
  dict entry(
 string "Capabilities"
 variant array [
   dict entry(
  string "Pairwise"
  variant  array [
string "ccmp"
string "tkip"
 ]
   )
   dict entry(
  string "Group"
  variant  array [
string "ccmp"
string "tkip"
string "wep104"
string "wep40"
 ]
   )
   dict entry(
  string "GroupMgmt"
  variant  array [
string "aes-128-cmac"
 ]
   )
   dict entry(
  string "KeyMgmt"
  variant  array [
string "none"
string "ieee8021x"
string "wpa-eap"
string "wpa-ft-eap"
string "wpa-eap-sha256"
string "wpa-psk"
string "wpa-ft-psk"
string "wpa-psk-sha256"
string "wps"
 ]
...

If one of the value can not reported the entire request just plain fail.
This is not happen on the same version without any addition patch. In
the debian package was added a patch to report the Stations attribue
that is a part of this answer and the fact that this is only valid on ap
mode does not let reply at all of this message. Now in connman for
example this getAll is used to get out the interface information as you
can find in this snipped code:


int supplicant_dbus_property_get_all(const char *path, const char *interface,
supplicant_dbus_property_function function,
void *user_data, gpointer caller)
{
struct property_call_data *property_call = NULL;
DBusMessage *message;
DBusPendingCall *call;

if (!connection)
return -EINVAL;

if (!path || !interface)
return -EINVAL;

property_call = g_try_new0(struct property_call_data, 1);
if (!property_call)
return -ENOMEM;

message = dbus_message_new_method_call(SUPPLICANT_SERVICE, path,
DBUS_INTERFACE_PROPERTIES, "GetAll");
if (!message) {
g_free(property_call);
return -ENOMEM;
}
...


static void interface_added(DBusMessageIter *iter, void *user_data)
{
...
   if (!properties_appended) {
supplicant_dbus_property_get_all(path,
SUPPLICANT_INTERFACE 
".Interface", << this call fail
interface_property, interface,
interface);
return;
}

...


This break all the other call try to access the Interface object in dbus 
dictionary

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to wpa in Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

Status in wpa package in Ubuntu:
  New

Bug description:
  dbus-send is able to read the properties of interface using GetAll. Those 
information include interface name, status, encryption method, etc. 
  The regression was introduced when someone try to have the Station attribute 
supported

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-11-04 Thread Michael Nazzareno Trimarchi
Dear Sebastian, the problem that the station patch was backported
already but wrongly. I have just fixed in this package

This is coming from change log

wpa (2:2.6-15ubuntu1) bionic; urgency=low

  * Merge from Debian unstable.  Remaining changes:
- debian/patches/wpa_service_ignore-on-isolate.patch: add
  IgnoreOnIsolate=yes so that when switching "runlevels" in oem-config
  will not kill off wpa and cause wireless to be unavailable on first
  boot.
- debian/patches/session-ticket.patch: disable the TLS Session Ticket
  extension to fix auth with 802.1x PEAP on some hardware.
- debian/patches/android_hal_fw_path_change.patch: add a DBus method
  for requesting a firmware change when working with the Android HAL;
  this is used to set a device in P2P or AP mode; conditional to
  CONFIG_ANDROID_HAL being enabled.
- debian/config/wpasupplicant/linux: enable CONFIG_ANDROID_HAL.
- debian/control: Build-Depends on android-headers to get the required
  wifi headers for the HAL support.
- debian/patches/dbus-available-sta.patch: Make the list of connected
  stations available on DBus for hotspot mode; along with some of the
  station properties, such as rx/tx packets, bytes, capabilities, etc.

Up you have the patch that break the package. I just made it working
properly patch the package



  * Updated debian/patches/dbus-available-sta.patch for new getter API

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to wpa in Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

Status in wpa package in Ubuntu:
  New

Bug description:
  dbus-send is able to read the properties of interface using GetAll. Those 
information include interface name, status, encryption method, etc. 
  The regression was introduced when someone try to have the Station attribute 
supported

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp