[Touch-packages] [Bug 1729357] Re: unprivileged user can drop supplementary groups

2018-02-19 Thread Aleksa Sarai
https://github.com/shadow-maint/shadow/pull/99 includes the allow_setgroups/deny_setgroups feature that we discussed earlier. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to shadow in Ubuntu.

[Touch-packages] [Bug 1729357] Re: unprivileged user can drop supplementary groups

2018-02-18 Thread Aleksa Sarai
** Bug watch added: bugzilla.opensuse.org/ #1081294 https://bugzilla.opensuse.org/show_bug.cgi?id=1081294 ** Changed in: shadow (openSUSE) Importance: Undecided => Unknown ** Changed in: shadow (openSUSE) Status: New => Unknown ** Changed in: shadow (openSUSE) Remote watch: None

[Touch-packages] [Bug 1729357] Re: unprivileged user can drop supplementary groups

2018-02-15 Thread Aleksa Sarai
CVE-2018-7169 is assigned for this issue. ** CVE added: https://cve.mitre.org/cgi-bin/cvename.cgi?name=2018-7169 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to shadow in Ubuntu. https://bugs.launchpad.net/bugs/1729357

[Touch-packages] [Bug 1729357] Re: unprivileged user can drop supplementary groups

2018-02-15 Thread Aleksa Sarai
** Also affects: shadow (openSUSE) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to shadow in Ubuntu. https://bugs.launchpad.net/bugs/1729357 Title: unprivileged user can drop

[Touch-packages] [Bug 1729357] Re: unprivileged user can drop supplementary groups

2018-02-15 Thread Aleksa Sarai
https://github.com/shadow-maint/shadow/pull/97 is my proposed patch. It currently only deals with the immediate security issue of allowing users that don't have % echo "$(whoami):$(id -g):1" >> /etc/setgid ... set up. I've tested this with a couple of different setups and it appears to

Re: [Touch-packages] [Bug 1729357] Re: unprivileged user can drop supplementary groups

2018-02-15 Thread Aleksa Sarai
MITRE. (Canonical is registered for example, but since this bug affects all distributions and not just Ubuntu I felt it made more sense to just submit directly.) There didn't appear to be any way for me to add you to Cc in the form (I could only provide a single contact address), but I can forward the mails t

Re: [Touch-packages] [Bug 1729357] Re: unprivileged user can drop supplementary groups

2018-02-15 Thread Aleksa Sarai
an Brauner <christian.brau...@canonical.com> wrote: > On Thu, Feb 15, 2018 at 11:29:03AM -, Aleksa Sarai wrote: >> I've just sent a request for a CVE. I'm working on the patch now. My > > I assume the CVE will at least be correctly attributed to Craig. > > Christian > &

[Touch-packages] [Bug 1729357] Re: unprivileged user can drop supplementary groups

2018-02-15 Thread Aleksa Sarai
I've just sent a request for a CVE. I'm working on the patch now. My current plan is that allow_setgroups will be the default for all mappings that are present in /etc/subgid -- but any "implicit" mappings (like mapping your own group) will be deny_setgroups by default (because that's the biggest

[Touch-packages] [Bug 1729357] Re: unprivileged user can drop supplementary groups

2018-02-14 Thread Aleksa Sarai
I had a preliminary patch written, but it was getting quite complicated (shadow's codebase is much more complicated than I expected -- and the /etc/subgid parsing code is intertwined with the parsing code for all of the other /etc/... files). I am working on it though. I've also email the SUSE

[Touch-packages] [Bug 1729357] Re: unprivileged user can drop supplementary groups

2018-01-15 Thread Aleksa Sarai
Oh, and we should definitely get a CVE assigned IMO. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to shadow in Ubuntu. https://bugs.launchpad.net/bugs/1729357 Title: unprivileged user can drop supplementary groups Status

[Touch-packages] [Bug 1729357] Re: unprivileged user can drop supplementary groups

2018-01-15 Thread Aleksa Sarai
Serge: I will submit a patch later today. However, I just thought that it's probably better that "allow_setgroups" should be "ignore_setgroups" and we retain the current behaviour (we don't write anything to /proc/$pid/setgroups) -- which allows a user (or runtime) to explicitly disable setgroups

[Touch-packages] [Bug 1729357] Re: unprivileged user can drop supplementary groups

2018-01-15 Thread Aleksa Sarai
> Thanks for replying Eric, but I'm having trouble reproducing what you've > posted. I can't write the gid map until I've written deny to > /prod/$pid/setgroups, not the other way around. There might be some nuance > I've missed. Yes, this is a security feature. setgroups must be written to