[Touch-packages] [Bug 740506]

2016-01-02 Thread Markus Kilås
Created attachment 120760 Considering offset 0 and signature only covering part of PDF Note that this patch has not been tested with a non-zero first offset document. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to poppler

[Touch-packages] [Bug 740506]

2016-01-02 Thread Markus Kilås
(In reply to Markus Wernig from comment #104) > I think the correct statement to issue in this case would be that a part > ("revision") of the PDF has been signed and to show the validation result > for that revision, ideally giving the user a chance to view only the signed > part. > > This might

[Touch-packages] [Bug 740506]

2016-01-02 Thread Markus Kilås
Created attachment 120758 Fix printf for unsigned int In pdfsig.cc the NetBeans IDE gave warning: Mismatching the argument type "unsigned int" and conversion specifier "d" The attached patch changes from %d to %u in the printf. -- You received this bug notification because you are a member of

[Touch-packages] [Bug 740506]

2015-12-05 Thread Markus Kilås
(In reply to Albert Astals Cid from comment #102) > So we're stuck on "need to use the offset" part, right? > > Could someone try to do make the code use it even if we don't have any pdf > that needs it? I am not sure if it is good to apply the robustness principle on security functions. In

[Touch-packages] [Bug 740506]

2015-10-31 Thread Markus Kilås
Created attachment 119174 Handle SEC_ERROR_UNTRUSTED_ISSUER When verifying a PDF signed by a certificate issued by a CA not in the trust store I would expect to get an error "Certificate isn't Trusted" however currently the error message actually is the more generic "Unknown issue with

[Touch-packages] [Bug 740506]

2015-10-31 Thread Markus Kilås
(In reply to Adrian Johnson from comment #91) > What is the output of "pkg-config --cflags nss"? [user@dev-21 poppler]$ pkg-config --cflags nss -I/usr/include/nss3 -I/usr/include/nspr4 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is

[Touch-packages] [Bug 740506]

2015-10-24 Thread Markus Kilås
(In reply to Adrian Johnson from comment #89) > (In reply to Markus Kilås from comment #88) > > I found a workaround for my build issue by creating symlinks: > > /usr/include/nspr -> /usr/include/nspr4 > > /usr/inclyde/nss -> /usr/include/nss3 > > Are you

[Touch-packages] [Bug 740506]

2015-10-24 Thread Markus Kilås
(In reply to Markus Kilås from comment #87) > I'm trying to build the branch (on Fedora 21) but obviously I am missing > some dependency or not having the right versions etc. Anyone having an idea? > > Build output: > --- > [user@dev-21 poppler]$ sudo yum install nspr-deve

[Touch-packages] [Bug 740506]

2015-10-24 Thread Markus Kilås
I'm trying to build the branch (on Fedora 21) but obviously I am missing some dependency or not having the right versions etc. Anyone having an idea? Build output: --- [user@dev-21 poppler]$ sudo yum install nspr-devel Loaded plugins: langpacks, post-transaction-actions, yum-qubes-hooks Package