[Touch-packages] [Bug 941673]

2018-06-08 Thread Rstrode
is it common practice on BSD to rsync /etc/passwd around? Maybe bsd could go back to using /etc/passwd? -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to accountsservice in Ubuntu. https://bugs.launchpad.net/bugs/941673 Title:

[Touch-packages] [Bug 941673]

2018-06-08 Thread Rstrode
Attachment 124799 pushed as c85b41d - user: check if user is in wheel more efficiently Attachment 124800 pushed as 98f4287 - daemon: get local users from /etc/shadow not /etc/passwd Attachment 124801 pushed as 14ca424 - daemon: don't call getspnam for local users Attachment 124802 pushed as

[Touch-packages] [Bug 941673]

2018-06-08 Thread Rstrode
Created attachment 124803 daemon: don't source user list from wtmp wtmp can get rather large on some systems from ssh logins. Furthermore it's pretty much completely redundant given the user cache in /var/lib/AccountService This commit changes the wtmp code to only get used for maintaining login

[Touch-packages] [Bug 941673]

2018-06-08 Thread Rstrode
Created attachment 124802 daemon: constrain max local users to 50 Systems with tens of thousands of users don't want all those users showing up in the user list. Set a cap at an even 50, which should cover the lion's share of use cases well. Of course, if a user not in the list explicitly logs

[Touch-packages] [Bug 941673]

2018-06-08 Thread Rstrode
i'm going to push these patches to master. They're loosely based on ritz work in this bug, but they diverge in some significant ways: 1) i set a limit on the number of local users returned (ala comment 2) 2) i redid the wheel check to avoid needing an admin user cache 3) i cache shadow

[Touch-packages] [Bug 941673]

2018-06-08 Thread Rstrode
Created attachment 124800 daemon: get local users from /etc/shadow not /etc/passwd For some sites, it's common practice to rsync around large /etc/passwd files containing the password entries for remote users. That means accountsservices' "assume /etc/passwd is local users" heuristic falls over.

[Touch-packages] [Bug 941673]

2018-06-08 Thread Rstrode
Created attachment 124799 user: check if user is in wheel more efficiently We currently get all the groups a user belongs to in one pass, then check each one to see if it's wheel. It's much more efficient to just get the wheel group and check if any of its members are the user. -- You received

[Touch-packages] [Bug 941673]

2018-06-08 Thread Rstrode
Created attachment 124801 daemon: don't call getspnam for local users We're already iterating over the whole shadow file, so just cache the entries instead of calling getspname a few lines later. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages,

[Touch-packages] [Bug 844081]

2015-09-10 Thread Rstrode
My understanding is this bug is obsolete. canonical contributed a more general accountsservice feature for storing arbitrary metadata alongside the user. See bug 63733 for details. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is

[Touch-packages] [Bug 844081]

2015-09-10 Thread Rstrode
okay, but that doesn't have anything to do with this bug. Canonical already added the infrastructure to accountsservice, whether or not lightdm uses the infrastructure is a different matter -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is

[Touch-packages] [Bug 844081]

2015-09-10 Thread Rstrode
sounds like you know more about it than I do, but regardless, I don't think there's anything left to accountsservice. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to lightdm in Ubuntu. https://bugs.launchpad.net/bugs/844081