[Touch-packages] [Bug 1576311] Re: Cancel search executes run() twice
This bug was fixed in the package unity-scopes-shell - 0.5.7+16.10.20160525-0ubuntu1 --- unity-scopes-shell (0.5.7+16.10.20160525-0ubuntu1) yakkety; urgency=medium [ Gary.Wzl ] * Stop typing timer when reset navigation tag(tapping cancel). Also make sure relevant signal(searchQueryChanged) is triggered to keep query string updated as query string is empty after tapping cancel (LP: #1576311) [ Marcus Tomlinson ] * Only create an empty settings file when attempting to write to one (LP: #1583055) [ Pawel Stolowski ] * Don't depend on qt5-default. * Reject preview widgets with duplicated IDs. (LP: #1581495) * Set internet connectivity status in ActionMetadata (previews and preview actions). (LP: #1502282) * Workaround dependency issue on yakkety. -- Pawel Stolowski Wed, 25 May 2016 08:16:27 + ** Changed in: unity-scopes-shell (Ubuntu) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unity-scopes-shell in Ubuntu. https://bugs.launchpad.net/bugs/1576311 Title: Cancel search executes run() twice Status in canonical-scopes-project: Triaged Status in unity-scopes-shell package in Ubuntu: Fix Released Bug description: OTA10: I find that on tapping Cancel after entering a search query, the scope's run() method executes twice. For example: calls-scope always prints "CALLS starting" on entering run(). While watching scope-registry.log: (launch or refresh calls-scope) CAllS starting (enter query string) CALLS starting (tap Cancel) CALLS starting CALLS starting There should not be two entries after tapping cancel. To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-scopes-project/+bug/1576311/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1576311] Re: Cancel search executes run() twice
//1.Tapping cancel will trigger Query::run twice Log: resetPrimaryNavigationTag() Filters changed Scope::processPrimaryNavigationTag(): tag is ' "" ' active filters count: 0 invalidateResults ---> Sender: QObject(0x0) Dispatching search: "untitled10.gary-wzl77_untitled10" "" "" Scope:: query// 1 invalidateResults ---> Sender: QTimer(0x16be7d8) Dispatching search: "untitled10.gary-wzl77_untitled10" "" "" [2016-05-04 14:11:05.624] ERROR: untitled10.gary-wzl77_untitled10: QueryBase::run(): Operation was aborted by an application callback: Callback aborted Scope:: query // 2 The second run is caused by m_typingTimer. I think the proper fixing should be not to trigger timeout from m_typingTimer when query string is empty e.g Tapping cancel. ** Changed in: unity-scopes-shell (Ubuntu) Assignee: (unassigned) => Gary.Wang (gary-wzl77) ** Changed in: unity-scopes-shell (Ubuntu) Status: New => In Progress ** Branch linked: lp:~gary-wzl77/unity-scopes-shell/fix_1576311 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unity-scopes-shell in Ubuntu. https://bugs.launchpad.net/bugs/1576311 Title: Cancel search executes run() twice Status in canonical-scopes-project: Triaged Status in unity-scopes-shell package in Ubuntu: In Progress Bug description: OTA10: I find that on tapping Cancel after entering a search query, the scope's run() method executes twice. For example: calls-scope always prints "CALLS starting" on entering run(). While watching scope-registry.log: (launch or refresh calls-scope) CAllS starting (enter query string) CALLS starting (tap Cancel) CALLS starting CALLS starting There should not be two entries after tapping cancel. To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-scopes-project/+bug/1576311/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp