[Touch-packages] [Bug 1700218] Re: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

2017-09-18 Thread Launchpad Bug Tracker
This bug was fixed in the package ubuntu-themes - 16.10+17.10.20170918-0ubuntu1 --- ubuntu-themes (16.10+17.10.20170918-0ubuntu1) artful; urgency=medium [ Carlo Lobrano ] * Added support for GtkTextView::monospace (LP: #1700218) * Fixes support GtkTreeView separators (LP:

[Touch-packages] [Bug 1700218] Re: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

2017-09-18 Thread Juraj
I disagree that a monospace context menu is expected - this is not the case anywhere in the rest of the OS, it shouldn't matter that the text editing font is monospaced. But sure, that can be moved to a separate issue. -- You received this bug notification because you are a member of Ubuntu

[Touch-packages] [Bug 1700218] Re: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

2017-09-06 Thread Carlo Lobrano
No worries. About gedit, I can't reproduce the issue. I changed gedit's font to Ubuntu regular (initially it was Ubuntu Mono, so a monospace context menu was expected, I guess) and the context menu is not in monospace. However, if you're still able to reproduce the issue with a not monospace

[Touch-packages] [Bug 1700218] Re: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

2017-09-06 Thread Juraj
Sorry, I haven't seen your patch, I see that you have done the same thing there as me above (I was referring to Hồng's original patch). -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-themes in Ubuntu.

[Touch-packages] [Bug 1700218] Re: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

2017-09-06 Thread Carlo Lobrano
Ok, I think this should have been discussed in patch's code review here https://code.launchpad.net/~c-lobrano/ubuntu- themes/fix-1700218/+merge/327422 however, the original patch should already take into account the context-menu's font style, at least in gitg it does. Let me have a look into

[Touch-packages] [Bug 1700218] Re: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

2017-09-06 Thread Juraj
Carlo, now I remember why I got confused. It happens in gedit (when right clicking the text area), with or without Hồng's patch. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-themes in Ubuntu.

[Touch-packages] [Bug 1700218] Re: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

2017-09-06 Thread Juraj
I mitigated this by clearing the property from children (such as the pop-up menu): /* Fix Gitg source view */ .monospace { font-family: "Monospace"; } .monospace * { font-family: initial; } -- You received this bug notification because you are a member of Ubuntu Touch seeded packages,

[Touch-packages] [Bug 1700218] Re: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

2017-09-06 Thread Juraj
Without the proposed patch. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-themes in Ubuntu. https://bugs.launchpad.net/bugs/1700218 Title: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace Status in

[Touch-packages] [Bug 1700218] Re: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

2017-09-06 Thread Juraj
Sorry, I messed up. With the proposed patch. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-themes in Ubuntu. https://bugs.launchpad.net/bugs/1700218 Title: Ambiance theme doesn't respect Gtk3's

[Touch-packages] [Bug 1700218] Re: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

2017-09-06 Thread Carlo Lobrano
Do you mean, using the proposed patch? -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-themes in Ubuntu. https://bugs.launchpad.net/bugs/1700218 Title: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

[Touch-packages] [Bug 1700218] Re: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

2017-09-06 Thread Juraj
By the way, if you right click on the diff in gitg, the menu font is monospaced, although it shouldn't be. Not sure if related. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-themes in Ubuntu.

[Touch-packages] [Bug 1700218] Re: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

2017-09-04 Thread Carlo Lobrano
Hi Juray, I replied in 1694303 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-themes in Ubuntu. https://bugs.launchpad.net/bugs/1700218 Title: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace Status in

[Touch-packages] [Bug 1700218] Re: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

2017-09-04 Thread Juraj
I have already reported this in #1694303 and unfortunately nobody responded. There is another issue mentioned there -- the commit description in gitg is unreadable, because it's white-on-white. Can someone take a look at that theming issue as well? -- You received this bug notification

[Touch-packages] [Bug 1700218] Re: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

2017-08-22 Thread Treviño
** Changed in: ubuntu-themes (Ubuntu) Importance: Undecided => Medium ** Changed in: ubuntu-themes (Ubuntu) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-themes in Ubuntu.

[Touch-packages] [Bug 1700218] Re: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

2017-07-17 Thread Carlo Lobrano
** Changed in: ubuntu-themes (Ubuntu) Assignee: (unassigned) => Carlo Lobrano (c-lobrano) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-themes in Ubuntu. https://bugs.launchpad.net/bugs/1700218 Title:

[Touch-packages] [Bug 1700218] Re: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

2017-07-14 Thread Carlo Lobrano
** Branch linked: lp:~c-lobrano/ubuntu-themes/fix-1700218 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-themes in Ubuntu. https://bugs.launchpad.net/bugs/1700218 Title: Ambiance theme doesn't respect Gtk3's

[Touch-packages] [Bug 1700218] Re: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

2017-07-11 Thread Carlo Lobrano
** Changed in: ubuntu-themes (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-themes in Ubuntu. https://bugs.launchpad.net/bugs/1700218 Title: Ambiance theme doesn't respect

[Touch-packages] [Bug 1700218] Re: Ambiance theme doesn't respect Gtk3's GtkTextView::monospace

2017-06-25 Thread Daniel van Vugt
** Summary changed: - Respect GtkTextView::monospace + Ambiance theme doesn't respect Gtk3's GtkTextView::monospace -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-themes in Ubuntu.