[Touch-packages] [Bug 1855893] Re: Properly let PCM leave suspended state when hardware doesn't support PCM resume
** Changed in: hwe-next Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to pulseaudio in Ubuntu. https://bugs.launchpad.net/bugs/1855893 Title: Properly let PCM leave suspended state when hardware doesn't support PCM resume Status in HWE Next: Fix Released Status in pulseaudio package in Ubuntu: Fix Released Status in pulseaudio source package in Bionic: Won't Fix Bug description: [Impact] Headset Mic plugged into Dell WD19TB dock stops working after suspend/resume. [Fix] According to alia-lib's document, to make PCM properly leave suspended state, we only use snd_pcm_resume() if hardware support PCM resume. For hardware that doesn't support PCM resume, like snd-usb-audio on WD19TB dock, we should use snd_pcm_prepare(), snd_pcm_drop() or snd_pcm_drain() to make device leave suspended state. This patch defaults to use snd_pcm_drop() to achieve the goal. [Test] 1. See if microphone on snd-usb-audio works in gnome-control-center/cheese. 2. Suspend/resume. 3. See if microphone still works in those apps. I can the issue is fixed after each suspend/resume cycle. [Regression Potential] Low. This fix makes PCM suspend/resume more reliable. No functional change intended. I also don't find any regression during some smoke test. To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/1855893/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1855893] Re: Properly let PCM leave suspended state when hardware doesn't support PCM resume
** Changed in: pulseaudio (Ubuntu Bionic) Status: In Progress => Won't Fix -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to pulseaudio in Ubuntu. https://bugs.launchpad.net/bugs/1855893 Title: Properly let PCM leave suspended state when hardware doesn't support PCM resume Status in HWE Next: New Status in pulseaudio package in Ubuntu: Fix Released Status in pulseaudio source package in Bionic: Won't Fix Bug description: [Impact] Headset Mic plugged into Dell WD19TB dock stops working after suspend/resume. [Fix] According to alia-lib's document, to make PCM properly leave suspended state, we only use snd_pcm_resume() if hardware support PCM resume. For hardware that doesn't support PCM resume, like snd-usb-audio on WD19TB dock, we should use snd_pcm_prepare(), snd_pcm_drop() or snd_pcm_drain() to make device leave suspended state. This patch defaults to use snd_pcm_drop() to achieve the goal. [Test] 1. See if microphone on snd-usb-audio works in gnome-control-center/cheese. 2. Suspend/resume. 3. See if microphone still works in those apps. I can the issue is fixed after each suspend/resume cycle. [Regression Potential] Low. This fix makes PCM suspend/resume more reliable. No functional change intended. I also don't find any regression during some smoke test. To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/1855893/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1855893] Re: Properly let PCM leave suspended state when hardware doesn't support PCM resume
I think it's okay to drop it since Focal is imminent. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to pulseaudio in Ubuntu. https://bugs.launchpad.net/bugs/1855893 Title: Properly let PCM leave suspended state when hardware doesn't support PCM resume Status in HWE Next: New Status in pulseaudio package in Ubuntu: Fix Released Status in pulseaudio source package in Bionic: In Progress Bug description: [Impact] Headset Mic plugged into Dell WD19TB dock stops working after suspend/resume. [Fix] According to alia-lib's document, to make PCM properly leave suspended state, we only use snd_pcm_resume() if hardware support PCM resume. For hardware that doesn't support PCM resume, like snd-usb-audio on WD19TB dock, we should use snd_pcm_prepare(), snd_pcm_drop() or snd_pcm_drain() to make device leave suspended state. This patch defaults to use snd_pcm_drop() to achieve the goal. [Test] 1. See if microphone on snd-usb-audio works in gnome-control-center/cheese. 2. Suspend/resume. 3. See if microphone still works in those apps. I can the issue is fixed after each suspend/resume cycle. [Regression Potential] Low. This fix makes PCM suspend/resume more reliable. No functional change intended. I also don't find any regression during some smoke test. To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/1855893/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1855893] Re: Properly let PCM leave suspended state when hardware doesn't support PCM resume
@Kai-Heng, you unassigned yourself, does it mean it's not important anymore for bionic and the target should be dropped? -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to pulseaudio in Ubuntu. https://bugs.launchpad.net/bugs/1855893 Title: Properly let PCM leave suspended state when hardware doesn't support PCM resume Status in HWE Next: New Status in pulseaudio package in Ubuntu: Fix Released Status in pulseaudio source package in Bionic: In Progress Bug description: [Impact] Headset Mic plugged into Dell WD19TB dock stops working after suspend/resume. [Fix] According to alia-lib's document, to make PCM properly leave suspended state, we only use snd_pcm_resume() if hardware support PCM resume. For hardware that doesn't support PCM resume, like snd-usb-audio on WD19TB dock, we should use snd_pcm_prepare(), snd_pcm_drop() or snd_pcm_drain() to make device leave suspended state. This patch defaults to use snd_pcm_drop() to achieve the goal. [Test] 1. See if microphone on snd-usb-audio works in gnome-control-center/cheese. 2. Suspend/resume. 3. See if microphone still works in those apps. I can the issue is fixed after each suspend/resume cycle. [Regression Potential] Low. This fix makes PCM suspend/resume more reliable. No functional change intended. I also don't find any regression during some smoke test. To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/1855893/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1855893] Re: Properly let PCM leave suspended state when hardware doesn't support PCM resume
** Changed in: pulseaudio (Ubuntu Bionic) Assignee: Kai-Heng Feng (kaihengfeng) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to pulseaudio in Ubuntu. https://bugs.launchpad.net/bugs/1855893 Title: Properly let PCM leave suspended state when hardware doesn't support PCM resume Status in HWE Next: New Status in pulseaudio package in Ubuntu: Fix Released Status in pulseaudio source package in Bionic: In Progress Bug description: [Impact] Headset Mic plugged into Dell WD19TB dock stops working after suspend/resume. [Fix] According to alia-lib's document, to make PCM properly leave suspended state, we only use snd_pcm_resume() if hardware support PCM resume. For hardware that doesn't support PCM resume, like snd-usb-audio on WD19TB dock, we should use snd_pcm_prepare(), snd_pcm_drop() or snd_pcm_drain() to make device leave suspended state. This patch defaults to use snd_pcm_drop() to achieve the goal. [Test] 1. See if microphone on snd-usb-audio works in gnome-control-center/cheese. 2. Suspend/resume. 3. See if microphone still works in those apps. I can the issue is fixed after each suspend/resume cycle. [Regression Potential] Low. This fix makes PCM suspend/resume more reliable. No functional change intended. I also don't find any regression during some smoke test. To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/1855893/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1855893] Re: Properly let PCM leave suspended state when hardware doesn't support PCM resume
The fix is in the current pulseaudio version/Ubuntu serie ** Tags removed: rls-bb-incoming ** Also affects: pulseaudio (Ubuntu Bionic) Importance: Undecided Status: New ** Changed in: pulseaudio (Ubuntu Bionic) Importance: Undecided => High ** Changed in: pulseaudio (Ubuntu Bionic) Status: New => In Progress ** Changed in: pulseaudio (Ubuntu Bionic) Assignee: (unassigned) => Kai-Heng Feng (kaihengfeng) ** Changed in: pulseaudio (Ubuntu) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to pulseaudio in Ubuntu. https://bugs.launchpad.net/bugs/1855893 Title: Properly let PCM leave suspended state when hardware doesn't support PCM resume Status in HWE Next: New Status in pulseaudio package in Ubuntu: Fix Released Status in pulseaudio source package in Bionic: In Progress Bug description: [Impact] Headset Mic plugged into Dell WD19TB dock stops working after suspend/resume. [Fix] According to alia-lib's document, to make PCM properly leave suspended state, we only use snd_pcm_resume() if hardware support PCM resume. For hardware that doesn't support PCM resume, like snd-usb-audio on WD19TB dock, we should use snd_pcm_prepare(), snd_pcm_drop() or snd_pcm_drain() to make device leave suspended state. This patch defaults to use snd_pcm_drop() to achieve the goal. [Test] 1. See if microphone on snd-usb-audio works in gnome-control-center/cheese. 2. Suspend/resume. 3. See if microphone still works in those apps. I can the issue is fixed after each suspend/resume cycle. [Regression Potential] Low. This fix makes PCM suspend/resume more reliable. No functional change intended. I also don't find any regression during some smoke test. To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/1855893/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1855893] Re: Properly let PCM leave suspended state when hardware doesn't support PCM resume
** Changed in: pulseaudio (Ubuntu) Status: New => In Progress ** Changed in: pulseaudio (Ubuntu) Assignee: (unassigned) => Kai-Heng Feng (kaihengfeng) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to pulseaudio in Ubuntu. https://bugs.launchpad.net/bugs/1855893 Title: Properly let PCM leave suspended state when hardware doesn't support PCM resume Status in HWE Next: New Status in pulseaudio package in Ubuntu: In Progress Bug description: [Impact] Headset Mic plugged into Dell WD19TB dock stops working after suspend/resume. [Fix] According to alia-lib's document, to make PCM properly leave suspended state, we only use snd_pcm_resume() if hardware support PCM resume. For hardware that doesn't support PCM resume, like snd-usb-audio on WD19TB dock, we should use snd_pcm_prepare(), snd_pcm_drop() or snd_pcm_drain() to make device leave suspended state. This patch defaults to use snd_pcm_drop() to achieve the goal. [Test] 1. See if microphone on snd-usb-audio works in gnome-control-center/cheese. 2. Suspend/resume. 3. See if microphone still works in those apps. I can the issue is fixed after each suspend/resume cycle. [Regression Potential] Low. This fix makes PCM suspend/resume more reliable. No functional change intended. I also don't find any regression during some smoke test. To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/1855893/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1855893] Re: Properly let PCM leave suspended state when hardware doesn't support PCM resume
** Tags added: rls-bb-incoming -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to pulseaudio in Ubuntu. https://bugs.launchpad.net/bugs/1855893 Title: Properly let PCM leave suspended state when hardware doesn't support PCM resume Status in HWE Next: New Status in pulseaudio package in Ubuntu: New Bug description: [Impact] Headset Mic plugged into Dell WD19TB dock stops working after suspend/resume. [Fix] According to alia-lib's document, to make PCM properly leave suspended state, we only use snd_pcm_resume() if hardware support PCM resume. For hardware that doesn't support PCM resume, like snd-usb-audio on WD19TB dock, we should use snd_pcm_prepare(), snd_pcm_drop() or snd_pcm_drain() to make device leave suspended state. This patch defaults to use snd_pcm_drop() to achieve the goal. [Test] 1. See if microphone on snd-usb-audio works in gnome-control-center/cheese. 2. Suspend/resume. 3. See if microphone still works in those apps. I can the issue is fixed after each suspend/resume cycle. [Regression Potential] Low. This fix makes PCM suspend/resume more reliable. No functional change intended. I also don't find any regression during some smoke test. To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/1855893/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1855893] Re: Properly let PCM leave suspended state when hardware doesn't support PCM resume
Doesn't seem to be have an upstream bug. Here's the upstream commit: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/f7b3537bbf9a6916ee3fd72a82025519b4c346f5 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to pulseaudio in Ubuntu. https://bugs.launchpad.net/bugs/1855893 Title: Properly let PCM leave suspended state when hardware doesn't support PCM resume Status in HWE Next: New Status in pulseaudio package in Ubuntu: New Bug description: [Impact] Headset Mic plugged into Dell WD19TB dock stops working after suspend/resume. [Fix] According to alia-lib's document, to make PCM properly leave suspended state, we only use snd_pcm_resume() if hardware support PCM resume. For hardware that doesn't support PCM resume, like snd-usb-audio on WD19TB dock, we should use snd_pcm_prepare(), snd_pcm_drop() or snd_pcm_drain() to make device leave suspended state. This patch defaults to use snd_pcm_drop() to achieve the goal. [Test] 1. See if microphone on snd-usb-audio works in gnome-control-center/cheese. 2. Suspend/resume. 3. See if microphone still works in those apps. I can the issue is fixed after each suspend/resume cycle. [Regression Potential] Low. This fix makes PCM suspend/resume more reliable. No functional change intended. I also don't find any regression during some smoke test. To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/1855893/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1855893] Re: Properly let PCM leave suspended state when hardware doesn't support PCM resume
Also please provide links to upstream changes/bugs in the patch, and/or here. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to pulseaudio in Ubuntu. https://bugs.launchpad.net/bugs/1855893 Title: Properly let PCM leave suspended state when hardware doesn't support PCM resume Status in HWE Next: New Status in pulseaudio package in Ubuntu: New Bug description: [Impact] Headset Mic plugged into Dell WD19TB dock stops working after suspend/resume. [Fix] According to alia-lib's document, to make PCM properly leave suspended state, we only use snd_pcm_resume() if hardware support PCM resume. For hardware that doesn't support PCM resume, like snd-usb-audio on WD19TB dock, we should use snd_pcm_prepare(), snd_pcm_drop() or snd_pcm_drain() to make device leave suspended state. This patch defaults to use snd_pcm_drop() to achieve the goal. [Test] 1. See if microphone on snd-usb-audio works in gnome-control-center/cheese. 2. Suspend/resume. 3. See if microphone still works in those apps. I can the issue is fixed after each suspend/resume cycle. [Regression Potential] Low. This fix makes PCM suspend/resume more reliable. No functional change intended. I also don't find any regression during some smoke test. To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/1855893/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1855893] Re: Properly let PCM leave suspended state when hardware doesn't support PCM resume
I just noticed the above patch. Now added to git: https://git.launchpad.net/~ubuntu-audio-dev/pulseaudio/log/?h=ubuntu- bionic Please remember to put proposed changes in git so everyone is working with the same source. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to pulseaudio in Ubuntu. https://bugs.launchpad.net/bugs/1855893 Title: Properly let PCM leave suspended state when hardware doesn't support PCM resume Status in HWE Next: New Status in pulseaudio package in Ubuntu: New Bug description: [Impact] Headset Mic plugged into Dell WD19TB dock stops working after suspend/resume. [Fix] According to alia-lib's document, to make PCM properly leave suspended state, we only use snd_pcm_resume() if hardware support PCM resume. For hardware that doesn't support PCM resume, like snd-usb-audio on WD19TB dock, we should use snd_pcm_prepare(), snd_pcm_drop() or snd_pcm_drain() to make device leave suspended state. This patch defaults to use snd_pcm_drop() to achieve the goal. [Test] 1. See if microphone on snd-usb-audio works in gnome-control-center/cheese. 2. Suspend/resume. 3. See if microphone still works in those apps. I can the issue is fixed after each suspend/resume cycle. [Regression Potential] Low. This fix makes PCM suspend/resume more reliable. No functional change intended. I also don't find any regression during some smoke test. To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/1855893/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1855893] Re: Properly let PCM leave suspended state when hardware doesn't support PCM resume
** Changed in: pulseaudio (Ubuntu) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to pulseaudio in Ubuntu. https://bugs.launchpad.net/bugs/1855893 Title: Properly let PCM leave suspended state when hardware doesn't support PCM resume Status in HWE Next: New Status in pulseaudio package in Ubuntu: New Bug description: [Impact] Headset Mic plugged into Dell WD19TB dock stops working after suspend/resume. [Fix] According to alia-lib's document, to make PCM properly leave suspended state, we only use snd_pcm_resume() if hardware support PCM resume. For hardware that doesn't support PCM resume, like snd-usb-audio on WD19TB dock, we should use snd_pcm_prepare(), snd_pcm_drop() or snd_pcm_drain() to make device leave suspended state. This patch defaults to use snd_pcm_drop() to achieve the goal. [Test] 1. See if microphone on snd-usb-audio works in gnome-control-center/cheese. 2. Suspend/resume. 3. See if microphone still works in those apps. I can the issue is fixed after each suspend/resume cycle. [Regression Potential] Low. This fix makes PCM suspend/resume more reliable. No functional change intended. I also don't find any regression during some smoke test. To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/1855893/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1855893] Re: Properly let PCM leave suspended state when hardware doesn't support PCM resume
The attachment "pulseaudio_11.1-1ubuntu7.6.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to pulseaudio in Ubuntu. https://bugs.launchpad.net/bugs/1855893 Title: Properly let PCM leave suspended state when hardware doesn't support PCM resume Status in HWE Next: New Status in pulseaudio package in Ubuntu: New Bug description: [Impact] Headset Mic plugged into Dell WD19TB dock stops working after suspend/resume. [Fix] According to alia-lib's document, to make PCM properly leave suspended state, we only use snd_pcm_resume() if hardware support PCM resume. For hardware that doesn't support PCM resume, like snd-usb-audio on WD19TB dock, we should use snd_pcm_prepare(), snd_pcm_drop() or snd_pcm_drain() to make device leave suspended state. This patch defaults to use snd_pcm_drop() to achieve the goal. [Test] 1. See if microphone on snd-usb-audio works in gnome-control-center/cheese. 2. Suspend/resume. 3. See if microphone still works in those apps. I can the issue is fixed after each suspend/resume cycle. [Regression Potential] Low. This fix makes PCM suspend/resume more reliable. No functional change intended. I also don't find any regression during some smoke test. To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/1855893/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1855893] Re: Properly let PCM leave suspended state when hardware doesn't support PCM resume
** Patch added: "pulseaudio_11.1-1ubuntu7.6.debdiff" https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/1855893/+attachment/5311477/+files/pulseaudio_11.1-1ubuntu7.6.debdiff ** Tags added: oem-priority originate-from-1849812 somerville -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to pulseaudio in Ubuntu. https://bugs.launchpad.net/bugs/1855893 Title: Properly let PCM leave suspended state when hardware doesn't support PCM resume Status in HWE Next: New Status in pulseaudio package in Ubuntu: New Bug description: [Impact] Headset Mic plugged into Dell WD19TB dock stops working after suspend/resume. [Fix] According to alia-lib's document, to make PCM properly leave suspended state, we only use snd_pcm_resume() if hardware support PCM resume. For hardware that doesn't support PCM resume, like snd-usb-audio on WD19TB dock, we should use snd_pcm_prepare(), snd_pcm_drop() or snd_pcm_drain() to make device leave suspended state. This patch defaults to use snd_pcm_drop() to achieve the goal. [Test] 1. See if microphone on snd-usb-audio works in gnome-control-center/cheese. 2. Suspend/resume. 3. See if microphone still works in those apps. I can the issue is fixed after each suspend/resume cycle. [Regression Potential] Low. This fix makes PCM suspend/resume more reliable. No functional change intended. I also don't find any regression during some smoke test. To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/1855893/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
