[Touch-packages] [Bug 1964506] Re: Ping: checks payloads incorrectly, ignores all mismatch replies

2024-01-09 Thread Launchpad Bug Tracker
This bug was fixed in the package iputils - 3:20190709-3ubuntu1 --- iputils (3:20190709-3ubuntu1) focal; urgency=medium * debian/patches/git_revert_strict_pattern_matching.patch: - cherrypick of an upstream revert of a buggy commit which was leading to incorrect ping

[Touch-packages] [Bug 1964506] Re: Ping: checks payloads incorrectly, ignores all mismatch replies

2024-01-02 Thread Andreas Hasenack
Focal verification # Reproducing the bug ubuntu@f-ping-1964506:~$ apt-cache policy iputils-ping iputils-ping: Installed: 3:20190709-3 Candidate: 3:20190709-3 Version table: *** 3:20190709-3 500 500 http://br.archive.ubuntu.com/ubuntu focal/main amd64 Packages 100

[Touch-packages] [Bug 1964506] Re: Ping: checks payloads incorrectly, ignores all mismatch replies

2023-09-29 Thread Andreas Hasenack
The DEP8 tests are green now, but we still need verification on this bug. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to iputils in Ubuntu. https://bugs.launchpad.net/bugs/1964506 Title: Ping: checks payloads incorrectly,

[Touch-packages] [Bug 1964506] Re: Ping: checks payloads incorrectly, ignores all mismatch replies

2022-10-24 Thread Dan Bungert
The armhf test seems to have been broken for a bit, in root-unittests: test_exec_dynamicuser: exec-dynamicuser-statedir.service: exit status 1, expected 0 FAIL: test-execute (code: 134) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is

[Touch-packages] [Bug 1964506] Re: Ping: checks payloads incorrectly, ignores all mismatch replies

2022-10-21 Thread Utkarsh Gupta
Re-triggered the failing autopkgtest on armhf. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to iputils in Ubuntu. https://bugs.launchpad.net/bugs/1964506 Title: Ping: checks payloads incorrectly, ignores all mismatch

[Touch-packages] [Bug 1964506] Re: Ping: checks payloads incorrectly, ignores all mismatch replies

2022-10-21 Thread Timo Aaltonen
Hello Matt, or anyone else affected, Accepted iputils into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/iputils/3:20190709-3ubuntu1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Touch-packages] [Bug 1964506] Re: Ping: checks payloads incorrectly, ignores all mismatch replies

2022-09-21 Thread Ante Karamatić
I agree with Seb. Behavior is broken, not different. It's not just about printing information; it's the fact that ping is not checking csum, not checking duplicates... Ideally, both this and bug 1551020 should be fixed. But if I'd have to pick only one, this would be the one. -- You received

[Touch-packages] [Bug 1964506] Re: Ping: checks payloads incorrectly, ignores all mismatch replies

2022-09-14 Thread Sebastien Bacher
The description of the patch explains why the current behavior is buggy and not just different in a way users would be relying on the difference of behavior. It's not that it works differently, it is that it reports wrong information. The patch didn't apply directly so I've adapted it and

[Touch-packages] [Bug 1964506] Re: Ping: checks payloads incorrectly, ignores all mismatch replies

2022-09-14 Thread Robie Basak
I'm not doubting that the revert was correct for upstream. But we have a different context in a stable release, where users may be relying on behaviours that upstream are at liberty to change in their main development branch, but we are not in our stable releases. Further, we can't just assume

[Touch-packages] [Bug 1964506] Re: Ping: checks payloads incorrectly, ignores all mismatch replies

2022-09-14 Thread Sebastien Bacher
@Robie, the patch description has details on the change. The github report also discuss why the patch was broken and not just doing what is intended and why the revert is right. I'm not involved in iputils and will not be able to provide more information that was in there. Note that the revert is

[Touch-packages] [Bug 1964506] Re: Ping: checks payloads incorrectly, ignores all mismatch replies

2022-09-14 Thread Robie Basak
This is definitely a bug that we want to fix in Focal. But is this particular code change the correct way to do it? Won't reverting this commit regress the fix that was introduced by the commit in the first place? I think this needs a proper analysis of the possible implications for unaffected

[Touch-packages] [Bug 1964506] Re: Ping: checks payloads incorrectly, ignores all mismatch replies

2022-09-14 Thread Andreas Hasenack
I checked that jammy and later indeed has the same commit reverted. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to iputils in Ubuntu. https://bugs.launchpad.net/bugs/1964506 Title: Ping: checks payloads incorrectly,

[Touch-packages] [Bug 1964506] Re: Ping: checks payloads incorrectly, ignores all mismatch replies

2022-09-13 Thread Sebastien Bacher
and I've uploaded a focal SRU candidate to the review queue now ** Changed in: iputils (Ubuntu Focal) Importance: Undecided => Low ** Changed in: iputils (Ubuntu Focal) Status: New => Fix Committed ** Description changed: + = Impact = + + the ping statistics are incorrect when

[Touch-packages] [Bug 1964506] Re: Ping: checks payloads incorrectly, ignores all mismatch replies

2022-09-13 Thread Sebastien Bacher
The issue is fixed in the version available in the current Ubuntu serie ** Changed in: iputils (Ubuntu) Importance: Undecided => Low ** Changed in: iputils (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Touch seeded

[Touch-packages] [Bug 1964506] Re: Ping: checks payloads incorrectly, ignores all mismatch replies

2022-09-13 Thread Brian Murray
** Also affects: iputils (Ubuntu Focal) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to iputils in Ubuntu. https://bugs.launchpad.net/bugs/1964506 Title: Ping: checks payloads