[Touch-packages] [Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
** Description changed: + Impact + == + + Under most circumstances, the impact is minimal (a few extra redundant + comment lines in apt sources. However, if users are automating source + removal / addition on a machine (as in comment 11), there is the + potential to wind up with an excessively large (and thus slow to parse) + apt sources configuration. + + Test Case + = + + * sudo add-apt-repository -y ppa:deadsnakes/ppa + * cat /etc/apt/sources.list.d/deadsnakes*.list + * Note the presence of one uncommented "deb" line, and one commented "deb-src" line + * sudo add-apt-repository -y ppa:deadsnakes/ppa + * cat /etc/apt/sources.list.d/deadsnakes*.list + * Note the uncommented "deb" line is still there but the commented "deb-src" line has now been duplicated + * Upgrade python-apt to 1.9.3ubuntu2 (or later) + * sudo add-apt-repository -y ppa:deadsnakes/ppa + * cat /etc/apt/sources.list.d/deadsnakes*.list + * Note there has been no further duplication of the commented "deb-src" line + + Regression Potential + + + Minimal; test cases have been added to cover the duplication case, and + to cover the enabling of sources (which was not covered by existing + tests, but was part of the code altered to fix the duplication case), + and insertion of sources at a position (again, not covered by existing + tests but modified as part of the fix). The test case has been used + successfully on all targeted releases (xenial, bionic, and eoan). + + Original Description + + Trusty Tahr 14.04 - 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list + 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) OK 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d# That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https://bugs.launchpad.net/ubuntu/+source/python- apt/+bug/1042916 .) ** Summary changed: - apt-add-repository adds duplicate commented/disabled source lines + [SRU] apt-add-repository adds duplicate commented/disabled source lines ** Description changed: Impact == Under most circumstances, the impact is minimal (a few extra redundant comment lines in apt sources. However, if users are automating source removal / addition on a machine (as in comment 11), there is the potential to wind up with an excessively large (and thus slow to parse) apt sources configuration. Test Case = * sudo add-apt-repository -y ppa:deadsnakes/ppa * cat /etc/apt/sources.list.d/deadsnakes*.list * Note the presence of one uncommented "deb" line, and one commented "deb-src" line * sudo add-apt-repository -y ppa:deadsnakes/ppa * cat /etc/apt/sources.list.d/deadsnakes*.list * Note the uncommented "deb" line is still there but the commented "deb-src" line has now been duplicated - * Upgrade python-apt to 1.9.3ubuntu2 (or later) + * sudo add-apt-repository ppa:waveform/python-apt + * sudo apt upgrade # update python-apt to fixed version * sudo add-apt-repository -y ppa:deadsnakes/ppa * cat /etc/apt/sources.list.d/deadsnakes*.list * Note there has been no further duplication of the commented "deb-src" line Regression Potential Minimal; test cases have been added to cover the duplication case, and to cover the enabling of sources (which was not covered by existing tests, but was part of the code altered to fix the duplication case), and insertion of sources at a position (again, not covered by existing tests but modified as part of the fix). The test case has been used successfully on all targeted releases (xenial, bionic, and eoan). Original Description Trusty Tahr 14.04 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository
[Touch-packages] [Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
** Also affects: python-apt (Ubuntu Eoan) Importance: Undecided Status: New ** Also affects: software-properties (Ubuntu Eoan) Importance: Undecided Status: New ** Also affects: python-apt (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: software-properties (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: python-apt (Ubuntu Bionic) Importance: Undecided Status: New ** Also affects: software-properties (Ubuntu Bionic) Importance: Undecided Status: New ** No longer affects: software-properties (Ubuntu) ** No longer affects: software-properties (Ubuntu Xenial) ** No longer affects: software-properties (Ubuntu Bionic) ** No longer affects: software-properties (Ubuntu Eoan) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to python-apt in Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines Status in python-apt package in Ubuntu: Fix Released Status in python-apt source package in Xenial: New Status in python-apt source package in Bionic: New Status in python-apt source package in Eoan: New Bug description: Trusty Tahr 14.04 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) OK 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d# That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https://bugs.launchpad.net/ubuntu/+source/python- apt/+bug/1042916 .) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
This bug was fixed in the package python-apt - 1.9.3ubuntu2 --- python-apt (1.9.3ubuntu2) focal; urgency=medium * Revert "apt.Cache: cache apt.package.Origin objects by id" -- Julian Andres Klode Tue, 17 Dec 2019 19:24:36 +0100 ** Changed in: python-apt (Ubuntu) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to python-apt in Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines Status in python-apt package in Ubuntu: Fix Released Status in software-properties package in Ubuntu: Triaged Bug description: Trusty Tahr 14.04 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) OK 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d# That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https://bugs.launchpad.net/ubuntu/+source/python- apt/+bug/1042916 .) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
I have an updated patch available from the following branch for focal: https://code.launchpad.net/~waveform/ubuntu/+source/python-apt/+git /python-apt/+ref/fix-dupe-ppa Currently building a test package in the following PPA: https://launchpad.net/~waveform/+archive/ubuntu/python-apt/+packages I realize most of the people affected by this are on older distributions, so I'm just in the process of back-porting the patch to bionic, xenial, and trusty, and will provide test builds in the same PPA once that's done. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to python-apt in Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines Status in python-apt package in Ubuntu: Triaged Status in software-properties package in Ubuntu: Triaged Bug description: Trusty Tahr 14.04 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) OK 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d# That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https://bugs.launchpad.net/ubuntu/+source/python- apt/+bug/1042916 .) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
Julian, unfort. testing the patch above against a bionic system didn't help, I'm still getting duplicate deb-src entries # deb-src http://ppa.launchpad.net/juju/stable/ubuntu bionic main # deb-src http://ppa.launchpad.net/juju/stable/ubuntu bionic main # deb-src http://ppa.launchpad.net/juju/stable/ubuntu bionic main # deb-src http://ppa.launchpad.net/juju/stable/ubuntu bionic main Thanks. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to python-apt in Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines Status in python-apt package in Ubuntu: Triaged Status in software-properties package in Ubuntu: Triaged Bug description: Trusty Tahr 14.04 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) OK 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d# That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https://bugs.launchpad.net/ubuntu/+source/python- apt/+bug/1042916 .) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
** Tags added: id-5d65087107d6ae450d988462 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to python-apt in Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines Status in python-apt package in Ubuntu: Triaged Status in software-properties package in Ubuntu: Triaged Bug description: Trusty Tahr 14.04 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) OK 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d# That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https://bugs.launchpad.net/ubuntu/+source/python- apt/+bug/1042916 .) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
Can you check the patch I posted in comment #10? -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to python-apt in Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines Status in python-apt package in Ubuntu: Triaged Status in software-properties package in Ubuntu: Triaged Bug description: Trusty Tahr 14.04 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) OK 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d# That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https://bugs.launchpad.net/ubuntu/+source/python- apt/+bug/1042916 .) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
Subscribing field-medium, we're seeing this repeatedly -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to python-apt in Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines Status in python-apt package in Ubuntu: Triaged Status in software-properties package in Ubuntu: Triaged Bug description: Trusty Tahr 14.04 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) OK 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d# That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https://bugs.launchpad.net/ubuntu/+source/python- apt/+bug/1042916 .) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
** Changed in: python-apt (Ubuntu) Importance: Low => Medium ** Changed in: python-apt (Ubuntu) Importance: Medium => Critical ** Changed in: python-apt (Ubuntu) Importance: Critical => High -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to python-apt in Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines Status in python-apt package in Ubuntu: Triaged Status in software-properties package in Ubuntu: Triaged Bug description: Trusty Tahr 14.04 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) OK 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d# That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https://bugs.launchpad.net/ubuntu/+source/python- apt/+bug/1042916 .) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
clarification: breaking regex parsing at /usr/lib/python3/dist- packages/aptsources/sourceslist.py that is -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to python-apt in Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines Status in python-apt package in Ubuntu: Triaged Status in software-properties package in Ubuntu: Triaged Bug description: Trusty Tahr 14.04 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) OK 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d# That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https://bugs.launchpad.net/ubuntu/+source/python- apt/+bug/1042916 .) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
We're seeing this in the context of a charm where add-apt-repository is called periodically. We ended up with a sources.list file weighing in at 2.6Mb, which created problems for the regex engine there. In light of this can I ask to reconsider the "low" importance of this bug? FTR. this is Bionic, software-properties ver 0.96.24.32.7 ** Tags added: canonical-bootstack -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to python-apt in Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines Status in python-apt package in Ubuntu: Triaged Status in software-properties package in Ubuntu: Triaged Bug description: Trusty Tahr 14.04 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) OK 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d# That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https://bugs.launchpad.net/ubuntu/+source/python- apt/+bug/1042916 .) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
This might be enough to fix it - I just compare the values against each other rather than doing 4 explicit cases. I call bool() on them first before comparing them as we want a boolean comparison here, and that should work even if you pass None or "" or whatever I guess. diff --git a/aptsources/sourceslist.py b/aptsources/sourceslist.py index 89cef642..d4e52c4d 100644 --- a/aptsources/sourceslist.py +++ b/aptsources/sourceslist.py @@ -332,10 +332,10 @@ class SourcesList(object): for source in sources: # if there is a repo with the same (type, uri, dist) just add the # components -if source.disabled and set(source.comps) == set(comps): -source.disabled = False +if bool(source.disabled) != bool(disabled) and set(source.comps) == set(comps): +source.disabled = bool(disabled) return source -elif not source.disabled: +elif bool(disabled) == bool(source.disabled): source.comps = uniq(source.comps + comps) return source # there isn't any matching source, so create a new line and parse it -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to python-apt in Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines Status in python-apt package in Ubuntu: Triaged Status in software-properties package in Ubuntu: Triaged Bug description: Trusty Tahr 14.04 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) OK 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d# That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https://bugs.launchpad.net/ubuntu/+source/python- apt/+bug/1042916 .) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
Analysis *before* situation: The loop after the __find call did not really match the __find call before - it was looking only for non- disabled sources, but then had an if case for disabled ones to enable them if the components match - which was never reached. Now, I think the patch is slightly wrong: The if case is reachable now, so it would enable an existing disabled source even if we passed disabled=True. The for loop thus needs 4 cases now, the existing ones corresponding to disabled=False and two variants of them for disabled=True (might be possible to write with less cases). -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to python-apt in Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines Status in python-apt package in Ubuntu: Triaged Status in software-properties package in Ubuntu: Triaged Bug description: Trusty Tahr 14.04 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) OK 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d# That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https://bugs.launchpad.net/ubuntu/+source/python- apt/+bug/1042916 .) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to python-apt in Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines Status in python-apt package in Ubuntu: Triaged Status in software-properties package in Ubuntu: Triaged Bug description: Trusty Tahr 14.04 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) OK 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d# That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https://bugs.launchpad.net/ubuntu/+source/python- apt/+bug/1042916 .) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
Julian - Do you have an opinion on this change to python-apt to handle adding disabled sources? -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to python-apt in Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines Status in python-apt package in Ubuntu: Triaged Status in software-properties package in Ubuntu: Triaged Bug description: Trusty Tahr 14.04 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) OK 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d# That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https://bugs.launchpad.net/ubuntu/+source/python- apt/+bug/1042916 .) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
It's actually python3-apt's sourceslist.py which does the duplicate checking and software properties is passing a type, '# deb-src', which I think is an abuse of what python-apt expects. I believe it'd want a 'deb' or 'deb-src' type. So we end up in this strange situation where are not searching for the right type and cannot see if the entry we want to add is a disabled one. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to software-properties in Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines Status in python-apt package in Ubuntu: Triaged Status in software-properties package in Ubuntu: Triaged Bug description: Trusty Tahr 14.04 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) OK 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d# That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https://bugs.launchpad.net/ubuntu/+source/python- apt/+bug/1042916 .) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
And here's the patch for python-apt. ** Patch added: "bug-1311056-apt.patch" https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1311056/+attachment/5026187/+files/bug-1311056-apt.patch ** Also affects: python-apt (Ubuntu) Importance: Undecided Status: New ** Changed in: python-apt (Ubuntu) Status: New => Triaged ** Changed in: python-apt (Ubuntu) Importance: Undecided => Low -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to software-properties in Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines Status in python-apt package in Ubuntu: Triaged Status in software-properties package in Ubuntu: Triaged Bug description: Trusty Tahr 14.04 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) OK 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d# That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https://bugs.launchpad.net/ubuntu/+source/python- apt/+bug/1042916 .) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
Here's a patch to software-properties. ** Patch added: "bug-1311056.patch" https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1311056/+attachment/5026186/+files/bug-1311056.patch ** Changed in: software-properties (Ubuntu) Status: Confirmed => Triaged -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to software-properties in Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines Status in python-apt package in Ubuntu: Triaged Status in software-properties package in Ubuntu: Triaged Bug description: Trusty Tahr 14.04 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) OK 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d# That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https://bugs.launchpad.net/ubuntu/+source/python- apt/+bug/1042916 .) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: software-properties (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to software-properties in Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines Status in software-properties package in Ubuntu: Confirmed Bug description: Trusty Tahr 14.04 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) OK 0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main 0 root@osprey:/etc/apt/sources.list.d# That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https://bugs.launchpad.net/ubuntu/+source/python- apt/+bug/1042916 .) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1311056/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp