[Touch-packages] [Bug 1708635] Re: Valgrind reports " Uninitialised value was created by a stack allocation" in __uuid_generate_random

2017-08-22 Thread Launchpad Bug Tracker
This bug was fixed in the package util-linux - 2.30.1-0ubuntu3

---
util-linux (2.30.1-0ubuntu3) artful; urgency=medium

  * Cherrypick upstream patches to support getrandom() fallbacks on older
kernels. LP: #1708635

 -- Dimitri John Ledkov   Mon, 14 Aug 2017 11:15:20
+0100

** Changed in: util-linux (Ubuntu)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to util-linux in Ubuntu.
https://bugs.launchpad.net/bugs/1708635

Title:
  Valgrind reports " Uninitialised value was created by a stack
  allocation" in  __uuid_generate_random

Status in util-linux package in Ubuntu:
  Fix Released

Bug description:
  This has shown up in lp:mir CI on Artful amd64 (and no other
  architecture or series we're using)

  For example:

  https://mir-jenkins.ubuntu.com/job/build-2-binpkg-
  mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4870/consoleFull

  Marking the memory with VALGRIND_MAKE_MEM_DEFINED() suppresses the
  error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1708635/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1708635] Re: Valgrind reports " Uninitialised value was created by a stack allocation" in __uuid_generate_random

2017-08-14 Thread Dimitri John Ledkov
** Changed in: util-linux (Ubuntu)
   Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to util-linux in Ubuntu.
https://bugs.launchpad.net/bugs/1708635

Title:
  Valgrind reports " Uninitialised value was created by a stack
  allocation" in  __uuid_generate_random

Status in util-linux package in Ubuntu:
  Fix Committed

Bug description:
  This has shown up in lp:mir CI on Artful amd64 (and no other
  architecture or series we're using)

  For example:

  https://mir-jenkins.ubuntu.com/job/build-2-binpkg-
  mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4870/consoleFull

  Marking the memory with VALGRIND_MAKE_MEM_DEFINED() suppresses the
  error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1708635/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1708635] Re: Valgrind reports " Uninitialised value was created by a stack allocation" in __uuid_generate_random

2017-08-07 Thread Chris Halse Rogers
Already have done: https://github.com/karelzak/util-linux/pull/492 ☺

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to util-linux in Ubuntu.
https://bugs.launchpad.net/bugs/1708635

Title:
  Valgrind reports " Uninitialised value was created by a stack
  allocation" in  __uuid_generate_random

Status in util-linux package in Ubuntu:
  New

Bug description:
  This has shown up in lp:mir CI on Artful amd64 (and no other
  architecture or series we're using)

  For example:

  https://mir-jenkins.ubuntu.com/job/build-2-binpkg-
  mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4870/consoleFull

  Marking the memory with VALGRIND_MAKE_MEM_DEFINED() suppresses the
  error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1708635/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1708635] Re: Valgrind reports " Uninitialised value was created by a stack allocation" in __uuid_generate_random

2017-08-07 Thread Dimitri John Ledkov
Hi,

Please provide minimal example of how to reproduce this. Ideally without
the CI - as I see it tries to setup ccache / clang etc. And I'm not sure
if all of that is relevant.

You mention an older kernel, what kernel is that? I would have thought a
reasonable kernel to test on, is latest xenial-security kernel.

Instead of uploading fixes to util-linux, ideally an upstream bug report
/ pull request is open about the issue with as much details as possible.

Regards,

Dimitri.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to util-linux in Ubuntu.
https://bugs.launchpad.net/bugs/1708635

Title:
  Valgrind reports " Uninitialised value was created by a stack
  allocation" in  __uuid_generate_random

Status in util-linux package in Ubuntu:
  New

Bug description:
  This has shown up in lp:mir CI on Artful amd64 (and no other
  architecture or series we're using)

  For example:

  https://mir-jenkins.ubuntu.com/job/build-2-binpkg-
  mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4870/consoleFull

  Marking the memory with VALGRIND_MAKE_MEM_DEFINED() suppresses the
  error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1708635/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1708635] Re: Valgrind reports " Uninitialised value was created by a stack allocation" in __uuid_generate_random

2017-08-06 Thread Chris Halse Rogers
** Changed in: util-linux (Ubuntu)
 Assignee: (unassigned) => Chris Halse Rogers (raof)

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to util-linux in Ubuntu.
https://bugs.launchpad.net/bugs/1708635

Title:
  Valgrind reports " Uninitialised value was created by a stack
  allocation" in  __uuid_generate_random

Status in util-linux package in Ubuntu:
  New

Bug description:
  This has shown up in lp:mir CI on Artful amd64 (and no other
  architecture or series we're using)

  For example:

  https://mir-jenkins.ubuntu.com/job/build-2-binpkg-
  mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4870/consoleFull

  Marking the memory with VALGRIND_MAKE_MEM_DEFINED() suppresses the
  error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1708635/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1708635] Re: Valgrind reports " Uninitialised value was created by a stack allocation" in __uuid_generate_random

2017-08-04 Thread Alan Griffiths
Not sure how to test this, but...

index b93b9ba47..cfa82d13c 100644
--- a/lib/randutils.c
+++ b/lib/randutils.c
@@ -81,8 +81,10 @@ void random_get_bytes(void *buf, size_t nbytes)
while (n > 0) {
ssize_t x = read(fd, cp, n);
if (x <= 0) {
-   if (lose_counter++ > 16)
+   if (lose_counter++ > 16) {
+   while (n--) *cp++ = rand();
break;
+   }
continue;
}
n -= x;

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to util-linux in Ubuntu.
https://bugs.launchpad.net/bugs/1708635

Title:
  Valgrind reports " Uninitialised value was created by a stack
  allocation" in  __uuid_generate_random

Status in util-linux package in Ubuntu:
  New

Bug description:
  This has shown up in lp:mir CI on Artful amd64 (and no other
  architecture or series we're using)

  For example:

  https://mir-jenkins.ubuntu.com/job/build-2-binpkg-
  mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4870/consoleFull

  Marking the memory with VALGRIND_MAKE_MEM_DEFINED() suppresses the
  error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1708635/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1708635] Re: Valgrind reports " Uninitialised value was created by a stack allocation" in __uuid_generate_random

2017-08-04 Thread Alan Griffiths
PS I suspect this only manifests in CI because the builders have an
older kernel than development machines.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to util-linux in Ubuntu.
https://bugs.launchpad.net/bugs/1708635

Title:
  Valgrind reports " Uninitialised value was created by a stack
  allocation" in  __uuid_generate_random

Status in util-linux package in Ubuntu:
  New

Bug description:
  This has shown up in lp:mir CI on Artful amd64 (and no other
  architecture or series we're using)

  For example:

  https://mir-jenkins.ubuntu.com/job/build-2-binpkg-
  mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4870/consoleFull

  Marking the memory with VALGRIND_MAKE_MEM_DEFINED() suppresses the
  error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1708635/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1708635] Re: Valgrind reports " Uninitialised value was created by a stack allocation" in __uuid_generate_random

2017-08-04 Thread Alan Griffiths
Looking at the util-linux source it seems that this could arise if:

1. opening /dev/urandom succeeds; and,
2. a subsequent read() fails

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to util-linux in Ubuntu.
https://bugs.launchpad.net/bugs/1708635

Title:
  Valgrind reports " Uninitialised value was created by a stack
  allocation" in  __uuid_generate_random

Status in util-linux package in Ubuntu:
  New

Bug description:
  This has shown up in lp:mir CI on Artful amd64 (and no other
  architecture or series we're using)

  For example:

  https://mir-jenkins.ubuntu.com/job/build-2-binpkg-
  mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4870/consoleFull

  Marking the memory with VALGRIND_MAKE_MEM_DEFINED() suppresses the
  error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1708635/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1708635] Re: Valgrind reports " Uninitialised value was created by a stack allocation" in __uuid_generate_random

2017-08-04 Thread Alan Griffiths
** Also affects: util-linux (Ubuntu)
   Importance: Undecided
   Status: New

** No longer affects: valgrind (Ubuntu)

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to util-linux in Ubuntu.
https://bugs.launchpad.net/bugs/1708635

Title:
  Valgrind reports " Uninitialised value was created by a stack
  allocation" in  __uuid_generate_random

Status in util-linux package in Ubuntu:
  New

Bug description:
  This has shown up in lp:mir CI on Artful amd64 (and no other
  architecture or series we're using)

  For example:

  https://mir-jenkins.ubuntu.com/job/build-2-binpkg-
  mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4870/consoleFull

  Marking the memory with VALGRIND_MAKE_MEM_DEFINED() suppresses the
  error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1708635/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp