[Touch-packages] [Bug 1852772] Re: test_updates_interval fails on focal

2019-12-20 Thread Francis Ginther
** Tags added: id-5ddff3a8c61a0a7a58a83a70

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to software-properties in
Ubuntu.
https://bugs.launchpad.net/bugs/1852772

Title:
  test_updates_interval fails on focal

Status in software-properties package in Ubuntu:
  Fix Released

Bug description:
  ==

  FAIL: test_updates_interval (tests.test_dbus.TestDBus)

  --

  Traceback (most recent call last):

File "/build/software-properties-0.98.6/tests/test_dbus.py", line 332, in 
test_updates_interval 
  self.assertTrue('APT::Periodic::Update-Package-Lists "1";' in config) 

  
  AssertionError: False is not true   

  Looking closer, while in the SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py, days is of
  dbus.Int32 type. A simple print output shows:

  days=dbus.Int32(1)

  D-Bus is statically typed, unlike python. More details at:
  https://dbus.freedesktop.org/doc/dbus-python/tutorial.html#data-types

  I think once we're in the dbus method (SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py) we can convert the
  dbus.Int32 to an int.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1852772/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1852772] Re: test_updates_interval fails on focal

2019-12-05 Thread Launchpad Bug Tracker
This bug was fixed in the package software-properties - 0.98.6

---
software-properties (0.98.6) focal; urgency=medium

  * cloudarchive: Enable support for the Ussuri Ubuntu Cloud Archive on
18.04 (LP: #1852489).
  * softwareproperties/dbus/SoftwarePropertiesDBus.py: In SetUpdateInterval,
convert days argument from dbus.Int32 to int before passing to
set_update_interval. This fixes a test failures as apt_pkg.config.set
didn't understand a dbus.Int32 type (LP: #1852772).
  * debian/control: Add gpg and gpg-agent to Build-Depends to fix failing
unit tests (LP: #1852773).

 -- Corey Bryant   Wed, 13 Nov 2019 16:00:59
-0500

** Changed in: software-properties (Ubuntu)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to software-properties in
Ubuntu.
https://bugs.launchpad.net/bugs/1852772

Title:
  test_updates_interval fails on focal

Status in software-properties package in Ubuntu:
  Fix Released

Bug description:
  ==

  FAIL: test_updates_interval (tests.test_dbus.TestDBus)

  --

  Traceback (most recent call last):

File "/build/software-properties-0.98.6/tests/test_dbus.py", line 332, in 
test_updates_interval 
  self.assertTrue('APT::Periodic::Update-Package-Lists "1";' in config) 

  
  AssertionError: False is not true   

  Looking closer, while in the SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py, days is of
  dbus.Int32 type. A simple print output shows:

  days=dbus.Int32(1)

  D-Bus is statically typed, unlike python. More details at:
  https://dbus.freedesktop.org/doc/dbus-python/tutorial.html#data-types

  I think once we're in the dbus method (SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py) we can convert the
  dbus.Int32 to an int.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1852772/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1852772] Re: test_updates_interval fails on focal

2019-12-05 Thread Mathieu Trudel-Lapierre
** Changed in: software-properties (Ubuntu)
   Status: Triaged => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to software-properties in
Ubuntu.
https://bugs.launchpad.net/bugs/1852772

Title:
  test_updates_interval fails on focal

Status in software-properties package in Ubuntu:
  Fix Committed

Bug description:
  ==

  FAIL: test_updates_interval (tests.test_dbus.TestDBus)

  --

  Traceback (most recent call last):

File "/build/software-properties-0.98.6/tests/test_dbus.py", line 332, in 
test_updates_interval 
  self.assertTrue('APT::Periodic::Update-Package-Lists "1";' in config) 

  
  AssertionError: False is not true   

  Looking closer, while in the SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py, days is of
  dbus.Int32 type. A simple print output shows:

  days=dbus.Int32(1)

  D-Bus is statically typed, unlike python. More details at:
  https://dbus.freedesktop.org/doc/dbus-python/tutorial.html#data-types

  I think once we're in the dbus method (SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py) we can convert the
  dbus.Int32 to an int.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1852772/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1852772] Re: test_updates_interval fails on focal

2019-12-05 Thread Brian Murray
** Tags removed: rls-ff-incoming
** Tags added: rls-ff-notfixing

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to software-properties in
Ubuntu.
https://bugs.launchpad.net/bugs/1852772

Title:
  test_updates_interval fails on focal

Status in software-properties package in Ubuntu:
  Fix Committed

Bug description:
  ==

  FAIL: test_updates_interval (tests.test_dbus.TestDBus)

  --

  Traceback (most recent call last):

File "/build/software-properties-0.98.6/tests/test_dbus.py", line 332, in 
test_updates_interval 
  self.assertTrue('APT::Periodic::Update-Package-Lists "1";' in config) 

  
  AssertionError: False is not true   

  Looking closer, while in the SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py, days is of
  dbus.Int32 type. A simple print output shows:

  days=dbus.Int32(1)

  D-Bus is statically typed, unlike python. More details at:
  https://dbus.freedesktop.org/doc/dbus-python/tutorial.html#data-types

  I think once we're in the dbus method (SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py) we can convert the
  dbus.Int32 to an int.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1852772/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1852772] Re: test_updates_interval fails on focal

2019-12-02 Thread Corey Bryant
Thanks Mathieu. Fixed in focal via https://launchpad.net/ubuntu/+source
/software-properties/0.98.6

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to software-properties in
Ubuntu.
https://bugs.launchpad.net/bugs/1852772

Title:
  test_updates_interval fails on focal

Status in software-properties package in Ubuntu:
  Triaged

Bug description:
  ==

  FAIL: test_updates_interval (tests.test_dbus.TestDBus)

  --

  Traceback (most recent call last):

File "/build/software-properties-0.98.6/tests/test_dbus.py", line 332, in 
test_updates_interval 
  self.assertTrue('APT::Periodic::Update-Package-Lists "1";' in config) 

  
  AssertionError: False is not true   

  Looking closer, while in the SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py, days is of
  dbus.Int32 type. A simple print output shows:

  days=dbus.Int32(1)

  D-Bus is statically typed, unlike python. More details at:
  https://dbus.freedesktop.org/doc/dbus-python/tutorial.html#data-types

  I think once we're in the dbus method (SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py) we can convert the
  dbus.Int32 to an int.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1852772/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1852772] Re: test_updates_interval fails on focal

2019-11-28 Thread Mathieu Trudel-Lapierre
I see no objection at all; that fix looks obviously correct and does fix
the test.

** Changed in: software-properties (Ubuntu)
 Assignee: (unassigned) => Corey Bryant (corey.bryant)

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to software-properties in
Ubuntu.
https://bugs.launchpad.net/bugs/1852772

Title:
  test_updates_interval fails on focal

Status in software-properties package in Ubuntu:
  Triaged

Bug description:
  ==

  FAIL: test_updates_interval (tests.test_dbus.TestDBus)

  --

  Traceback (most recent call last):

File "/build/software-properties-0.98.6/tests/test_dbus.py", line 332, in 
test_updates_interval 
  self.assertTrue('APT::Periodic::Update-Package-Lists "1";' in config) 

  
  AssertionError: False is not true   

  Looking closer, while in the SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py, days is of
  dbus.Int32 type. A simple print output shows:

  days=dbus.Int32(1)

  D-Bus is statically typed, unlike python. More details at:
  https://dbus.freedesktop.org/doc/dbus-python/tutorial.html#data-types

  I think once we're in the dbus method (SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py) we can convert the
  dbus.Int32 to an int.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1852772/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1852772] Re: test_updates_interval fails on focal

2019-11-20 Thread Corey Bryant
My proposed fix for this is:

diff --git a/softwareproperties/dbus/SoftwarePropertiesDBus.py 
b/softwareproperties/dbus/SoftwarePropertiesDBus.py
index c22f43b..7683a1a 100644
--- a/softwareproperties/dbus/SoftwarePropertiesDBus.py
+++ b/softwareproperties/dbus/SoftwarePropertiesDBus.py
@@ -266,7 +266,7 @@ class SoftwarePropertiesDBus(dbus.service.Object, 
SoftwareProperties):
 def SetUpdateInterval(self, days, sender=None, conn=None):
 self._check_policykit_privilege(
 sender, conn, "com.ubuntu.softwareproperties.applychanges")
-self.set_update_interval(days)
+self.set_update_interval(int(days))

I'd like to get a +1 before uploading that though.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to software-properties in
Ubuntu.
https://bugs.launchpad.net/bugs/1852772

Title:
  test_updates_interval fails on focal

Status in software-properties package in Ubuntu:
  Triaged

Bug description:
  ==

  FAIL: test_updates_interval (tests.test_dbus.TestDBus)

  --

  Traceback (most recent call last):

File "/build/software-properties-0.98.6/tests/test_dbus.py", line 332, in 
test_updates_interval 
  self.assertTrue('APT::Periodic::Update-Package-Lists "1";' in config) 

  
  AssertionError: False is not true   

  Looking closer, while in the SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py, days is of
  dbus.Int32 type. A simple print output shows:

  days=dbus.Int32(1)

  D-Bus is statically typed, unlike python. More details at:
  https://dbus.freedesktop.org/doc/dbus-python/tutorial.html#data-types

  I think once we're in the dbus method (SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py) we can convert the
  dbus.Int32 to an int.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1852772/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1852772] Re: test_updates_interval fails on focal

2019-11-19 Thread Corey Bryant
I should have mentioned that I have a fix for this just running it by
mvo.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to software-properties in
Ubuntu.
https://bugs.launchpad.net/bugs/1852772

Title:
  test_updates_interval fails on focal

Status in software-properties package in Ubuntu:
  Triaged

Bug description:
  ==

  FAIL: test_updates_interval (tests.test_dbus.TestDBus)

  --

  Traceback (most recent call last):

File "/build/software-properties-0.98.6/tests/test_dbus.py", line 332, in 
test_updates_interval 
  self.assertTrue('APT::Periodic::Update-Package-Lists "1";' in config) 

  
  AssertionError: False is not true   

  Looking closer, while in the SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py, days is of
  dbus.Int32 type. A simple print output shows:

  days=dbus.Int32(1)

  D-Bus is statically typed, unlike python. More details at:
  https://dbus.freedesktop.org/doc/dbus-python/tutorial.html#data-types

  I think once we're in the dbus method (SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py) we can convert the
  dbus.Int32 to an int.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1852772/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1852772] Re: test_updates_interval fails on focal

2019-11-19 Thread Brian Murray
** Tags added: rls-ff-incoming

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to software-properties in
Ubuntu.
https://bugs.launchpad.net/bugs/1852772

Title:
  test_updates_interval fails on focal

Status in software-properties package in Ubuntu:
  Triaged

Bug description:
  ==

  FAIL: test_updates_interval (tests.test_dbus.TestDBus)

  --

  Traceback (most recent call last):

File "/build/software-properties-0.98.6/tests/test_dbus.py", line 332, in 
test_updates_interval 
  self.assertTrue('APT::Periodic::Update-Package-Lists "1";' in config) 

  
  AssertionError: False is not true   

  Looking closer, while in the SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py, days is of
  dbus.Int32 type. A simple print output shows:

  days=dbus.Int32(1)

  D-Bus is statically typed, unlike python. More details at:
  https://dbus.freedesktop.org/doc/dbus-python/tutorial.html#data-types

  I think once we're in the dbus method (SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py) we can convert the
  dbus.Int32 to an int.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1852772/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1852772] Re: test_updates_interval fails on focal

2019-11-15 Thread Corey Bryant
** Changed in: software-properties (Ubuntu)
   Status: New => Triaged

** Changed in: software-properties (Ubuntu)
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to software-properties in
Ubuntu.
https://bugs.launchpad.net/bugs/1852772

Title:
  test_updates_interval fails on focal

Status in software-properties package in Ubuntu:
  Triaged

Bug description:
  ==

  FAIL: test_updates_interval (tests.test_dbus.TestDBus)

  --

  Traceback (most recent call last):

File "/build/software-properties-0.98.6/tests/test_dbus.py", line 332, in 
test_updates_interval 
  self.assertTrue('APT::Periodic::Update-Package-Lists "1";' in config) 

  
  AssertionError: False is not true   

  Looking closer, while in the SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py, days is of
  dbus.Int32 type. A simple print output shows:

  days=dbus.Int32(1)

  D-Bus is statically typed, unlike python. More details at:
  https://dbus.freedesktop.org/doc/dbus-python/tutorial.html#data-types

  I think once we're in the dbus method (SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py) we can convert the
  dbus.Int32 to an int.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1852772/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp