[Touch-packages] [Bug 1870058] Re: Collect deleted users

2020-07-02 Thread Launchpad Bug Tracker
This bug was fixed in the package zsys - 0.4.6

---
zsys (0.4.6) focal; urgency=medium

  [ Jean-Baptiste Lallement ]
  [ Didier Roche ]
  * Fix infinite GC loop (LP: #1870461)
  * Enhance timeout handling to avoid error rpc error: code = DeadlineExceeded
desc = context deadline exceeded while the daemon is doing work
(LP: #1875564)
  * Stop taking automated or manual snapshot when there is less than 20% of
free disk space (LP: #1876334)
  * Enable trim support for upgrading users (LP: #1881540)
  * Only clean up previously linked user datasets when unlinked under USERDATA
(LP: #1881538)
  * Strategy for deleted user datasets via a new hidden command called by
userdel (LP: #1870058)
  * Get better auto snapshots message when integrated to apt (LP: #1875420)
  * Update LastUsed on shutdown via a new hidden command service call
(LP: #1881536)
  * Prevent segfault immediately after install when zfs kernel module isn't
loaded (LP: #1881541)
  * Don’t try to autosave gdm user (and in general non system user), even if
systemd --user is started for them. (LP: #1881539)
  * Prevent apt printing errors when zsys is removed without purge
(LP: #1881535)
  * Some tests enhancements:
- new tests for all the above
- allow setting a different local socket for debugging/tests purposes only
- ascii order datasets in golden files
  * Typos and messages fixes. Direct prints are not prefixed with INFO
anymore.
  * Refreshed po and readme with the above.

 -- Didier Roche   Mon, 01 Jun 2020 09:26:52 +0200

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to shadow in Ubuntu.
https://bugs.launchpad.net/bugs/1870058

Title:
  Collect deleted users

Status in shadow package in Ubuntu:
  Fix Released
Status in zsys package in Ubuntu:
  Fix Released
Status in shadow source package in Focal:
  Fix Released
Status in zsys source package in Focal:
  Fix Released

Bug description:
  [Impact]
   * Deleting users were preserving corresponding ZFS user datasets, without 
marking them for cleanup.
   * This is covered by dedicated use cases.

  [Test Case]
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. Check that rpool/USERDATA/foo_ has its content removed and is not 
mounted
   4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
  ---
  Other use case:
   1.Ensure you have a foo user:
   2. Run userdel foo
   3. Check that rpool/USERDATA/foo_ still has its content, but is not 
mounted.
   4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
  ---
  On a non ZFS installation :
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. The user is deleted, no error occured.
  ---
  On a non ZFS installation with ZSys installed :
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. The user is deleted, no error occured.

  [Regression Potential]
   * A new hidden command is added, triggered by userdel.
   * Tests are covering this new command and GRPC request.
   * The methodology is similar to useradd and usermod. The dependency between 
shadow and zsys is weak on purpose:
   - the ZSys hidden command is available and is a no-op if not called
   - if calling the command failed on userdel, nothing is done on ZSys side, 
but the code path is similar to ZSys not being installed or running on a non 
ZFS system.

  

  Ideally, we would untag them as part of GC so that we can clean them
  up later. However, those can be linked to states on other pools with
  same pool name than targetted one, and it will be hard to match them.

  Give a command for users to see them in status and then manually
  remove suspicious datasets ?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/shadow/+bug/1870058/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1870058] Re: Collect deleted users

2020-07-02 Thread Launchpad Bug Tracker
This bug was fixed in the package shadow - 1:4.8.1-1ubuntu5.20.04

---
shadow (1:4.8.1-1ubuntu5.20.04) focal; urgency=medium

  * debian/patches/1015_add_zsys_support.patch:
- Add support for ZSys user deletion (LP: #1870058)
- Fix a build warning

 -- Didier Roche   Thu, 28 May 2020 08:37:47 +0200

** Changed in: shadow (Ubuntu Focal)
   Status: Fix Committed => Fix Released

** Changed in: zsys (Ubuntu Focal)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to shadow in Ubuntu.
https://bugs.launchpad.net/bugs/1870058

Title:
  Collect deleted users

Status in shadow package in Ubuntu:
  Fix Released
Status in zsys package in Ubuntu:
  Fix Released
Status in shadow source package in Focal:
  Fix Released
Status in zsys source package in Focal:
  Fix Released

Bug description:
  [Impact]
   * Deleting users were preserving corresponding ZFS user datasets, without 
marking them for cleanup.
   * This is covered by dedicated use cases.

  [Test Case]
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. Check that rpool/USERDATA/foo_ has its content removed and is not 
mounted
   4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
  ---
  Other use case:
   1.Ensure you have a foo user:
   2. Run userdel foo
   3. Check that rpool/USERDATA/foo_ still has its content, but is not 
mounted.
   4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
  ---
  On a non ZFS installation :
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. The user is deleted, no error occured.
  ---
  On a non ZFS installation with ZSys installed :
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. The user is deleted, no error occured.

  [Regression Potential]
   * A new hidden command is added, triggered by userdel.
   * Tests are covering this new command and GRPC request.
   * The methodology is similar to useradd and usermod. The dependency between 
shadow and zsys is weak on purpose:
   - the ZSys hidden command is available and is a no-op if not called
   - if calling the command failed on userdel, nothing is done on ZSys side, 
but the code path is similar to ZSys not being installed or running on a non 
ZFS system.

  

  Ideally, we would untag them as part of GC so that we can clean them
  up later. However, those can be linked to states on other pools with
  same pool name than targetted one, and it will be hard to match them.

  Give a command for users to see them in status and then manually
  remove suspicious datasets ?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/shadow/+bug/1870058/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1870058] Re: Collect deleted users

2020-06-24 Thread Jean-Baptiste Lallement
SRU verification for Focal:
I have reproduced the problem in focal and have verified that the version of 
zsys 0.4.6 and shadow 1:4.8.1-1ubuntu5.20.04 in -proposed fixes the issue.

Marking as verification-done


** Tags removed: verification-needed verification-needed-focal
** Tags added: verification-done verification-done-focal

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to shadow in Ubuntu.
https://bugs.launchpad.net/bugs/1870058

Title:
  Collect deleted users

Status in shadow package in Ubuntu:
  Fix Released
Status in zsys package in Ubuntu:
  Fix Released
Status in shadow source package in Focal:
  Fix Committed
Status in zsys source package in Focal:
  Fix Committed

Bug description:
  [Impact]
   * Deleting users were preserving corresponding ZFS user datasets, without 
marking them for cleanup.
   * This is covered by dedicated use cases.

  [Test Case]
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. Check that rpool/USERDATA/foo_ has its content removed and is not 
mounted
   4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
  ---
  Other use case:
   1.Ensure you have a foo user:
   2. Run userdel foo
   3. Check that rpool/USERDATA/foo_ still has its content, but is not 
mounted.
   4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
  ---
  On a non ZFS installation :
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. The user is deleted, no error occured.
  ---
  On a non ZFS installation with ZSys installed :
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. The user is deleted, no error occured.

  [Regression Potential]
   * A new hidden command is added, triggered by userdel.
   * Tests are covering this new command and GRPC request.
   * The methodology is similar to useradd and usermod. The dependency between 
shadow and zsys is weak on purpose:
   - the ZSys hidden command is available and is a no-op if not called
   - if calling the command failed on userdel, nothing is done on ZSys side, 
but the code path is similar to ZSys not being installed or running on a non 
ZFS system.

  

  Ideally, we would untag them as part of GC so that we can clean them
  up later. However, those can be linked to states on other pools with
  same pool name than targetted one, and it will be hard to match them.

  Give a command for users to see them in status and then manually
  remove suspicious datasets ?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/shadow/+bug/1870058/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1870058] Re: Collect deleted users

2020-06-23 Thread Brian Murray
Hello Didier, or anyone else affected,

Accepted shadow into focal-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/shadow/1:4.8.1-1ubuntu5.20.04 in a
few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
focal to verification-done-focal. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-focal. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: shadow (Ubuntu Focal)
   Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to shadow in Ubuntu.
https://bugs.launchpad.net/bugs/1870058

Title:
  Collect deleted users

Status in shadow package in Ubuntu:
  Fix Released
Status in zsys package in Ubuntu:
  Fix Released
Status in shadow source package in Focal:
  Fix Committed
Status in zsys source package in Focal:
  Fix Committed

Bug description:
  [Impact]
   * Deleting users were preserving corresponding ZFS user datasets, without 
marking them for cleanup.
   * This is covered by dedicated use cases.

  [Test Case]
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. Check that rpool/USERDATA/foo_ has its content removed and is not 
mounted
   4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
  ---
  Other use case:
   1.Ensure you have a foo user:
   2. Run userdel foo
   3. Check that rpool/USERDATA/foo_ still has its content, but is not 
mounted.
   4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
  ---
  On a non ZFS installation :
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. The user is deleted, no error occured.
  ---
  On a non ZFS installation with ZSys installed :
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. The user is deleted, no error occured.

  [Regression Potential]
   * A new hidden command is added, triggered by userdel.
   * Tests are covering this new command and GRPC request.
   * The methodology is similar to useradd and usermod. The dependency between 
shadow and zsys is weak on purpose:
   - the ZSys hidden command is available and is a no-op if not called
   - if calling the command failed on userdel, nothing is done on ZSys side, 
but the code path is similar to ZSys not being installed or running on a non 
ZFS system.

  

  Ideally, we would untag them as part of GC so that we can clean them
  up later. However, those can be linked to states on other pools with
  same pool name than targetted one, and it will be hard to match them.

  Give a command for users to see them in status and then manually
  remove suspicious datasets ?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/shadow/+bug/1870058/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1870058] Re: Collect deleted users

2020-06-19 Thread Timo Aaltonen
Hello Didier, or anyone else affected,

Accepted zsys into focal-proposed. The package will build now and be
available at https://launchpad.net/ubuntu/+source/zsys/0.4.6 in a few
hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
focal to verification-done-focal. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-focal. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: zsys (Ubuntu Focal)
   Status: New => Fix Committed

** Tags added: verification-needed verification-needed-focal

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to shadow in Ubuntu.
https://bugs.launchpad.net/bugs/1870058

Title:
  Collect deleted users

Status in shadow package in Ubuntu:
  Fix Released
Status in zsys package in Ubuntu:
  Fix Released
Status in shadow source package in Focal:
  New
Status in zsys source package in Focal:
  Fix Committed

Bug description:
  [Impact]
   * Deleting users were preserving corresponding ZFS user datasets, without 
marking them for cleanup.
   * This is covered by dedicated use cases.

  [Test Case]
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. Check that rpool/USERDATA/foo_ has its content removed and is not 
mounted
   4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
  ---
  Other use case:
   1.Ensure you have a foo user:
   2. Run userdel foo
   3. Check that rpool/USERDATA/foo_ still has its content, but is not 
mounted.
   4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
  ---
  On a non ZFS installation :
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. The user is deleted, no error occured.
  ---
  On a non ZFS installation with ZSys installed :
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. The user is deleted, no error occured.

  [Regression Potential]
   * A new hidden command is added, triggered by userdel.
   * Tests are covering this new command and GRPC request.
   * The methodology is similar to useradd and usermod. The dependency between 
shadow and zsys is weak on purpose:
   - the ZSys hidden command is available and is a no-op if not called
   - if calling the command failed on userdel, nothing is done on ZSys side, 
but the code path is similar to ZSys not being installed or running on a non 
ZFS system.

  

  Ideally, we would untag them as part of GC so that we can clean them
  up later. However, those can be linked to states on other pools with
  same pool name than targetted one, and it will be hard to match them.

  Give a command for users to see them in status and then manually
  remove suspicious datasets ?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/shadow/+bug/1870058/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1870058] Re: Collect deleted users

2020-06-10 Thread Seth Arnold
Thanks Didier, that's perfect. :)

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to shadow in Ubuntu.
https://bugs.launchpad.net/bugs/1870058

Title:
  Collect deleted users

Status in shadow package in Ubuntu:
  Fix Released
Status in zsys package in Ubuntu:
  Fix Released
Status in shadow source package in Focal:
  New
Status in zsys source package in Focal:
  New

Bug description:
  [Impact]
   * Deleting users were preserving corresponding ZFS user datasets, without 
marking them for cleanup.
   * This is covered by dedicated use cases.

  [Test Case]
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. Check that rpool/USERDATA/foo_ has its content removed and is not 
mounted
   4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
  ---
  Other use case:
   1.Ensure you have a foo user:
   2. Run userdel foo
   3. Check that rpool/USERDATA/foo_ still has its content, but is not 
mounted.
   4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
  ---
  On a non ZFS installation :
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. The user is deleted, no error occured.
  ---
  On a non ZFS installation with ZSys installed :
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. The user is deleted, no error occured.

  [Regression Potential]
   * A new hidden command is added, triggered by userdel.
   * Tests are covering this new command and GRPC request.
   * The methodology is similar to useradd and usermod. The dependency between 
shadow and zsys is weak on purpose:
   - the ZSys hidden command is available and is a no-op if not called
   - if calling the command failed on userdel, nothing is done on ZSys side, 
but the code path is similar to ZSys not being installed or running on a non 
ZFS system.

  

  Ideally, we would untag them as part of GC so that we can clean them
  up later. However, those can be linked to states on other pools with
  same pool name than targetted one, and it will be hard to match them.

  Give a command for users to see them in status and then manually
  remove suspicious datasets ?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/shadow/+bug/1870058/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1870058] Re: Collect deleted users

2020-06-10 Thread Didier Roche
ZFS installation without ZSys installed is equivalent to non ZFS
installation without ZSys. userdel calls ZSys which does the cleanup. If
you don’t have it, nothing will change from today’s behavior.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to shadow in Ubuntu.
https://bugs.launchpad.net/bugs/1870058

Title:
  Collect deleted users

Status in shadow package in Ubuntu:
  Fix Released
Status in zsys package in Ubuntu:
  Fix Released
Status in shadow source package in Focal:
  New
Status in zsys source package in Focal:
  New

Bug description:
  [Impact]
   * Deleting users were preserving corresponding ZFS user datasets, without 
marking them for cleanup.
   * This is covered by dedicated use cases.

  [Test Case]
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. Check that rpool/USERDATA/foo_ has its content removed and is not 
mounted
   4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
  ---
  Other use case:
   1.Ensure you have a foo user:
   2. Run userdel foo
   3. Check that rpool/USERDATA/foo_ still has its content, but is not 
mounted.
   4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
  ---
  On a non ZFS installation :
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. The user is deleted, no error occured.
  ---
  On a non ZFS installation with ZSys installed :
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. The user is deleted, no error occured.

  [Regression Potential]
   * A new hidden command is added, triggered by userdel.
   * Tests are covering this new command and GRPC request.
   * The methodology is similar to useradd and usermod. The dependency between 
shadow and zsys is weak on purpose:
   - the ZSys hidden command is available and is a no-op if not called
   - if calling the command failed on userdel, nothing is done on ZSys side, 
but the code path is similar to ZSys not being installed or running on a non 
ZFS system.

  

  Ideally, we would untag them as part of GC so that we can clean them
  up later. However, those can be linked to states on other pools with
  same pool name than targetted one, and it will be hard to match them.

  Give a command for users to see them in status and then manually
  remove suspicious datasets ?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/shadow/+bug/1870058/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


Re: [Touch-packages] [Bug 1870058] Re: Collect deleted users

2020-06-09 Thread Seth Arnold
On Tue, Jun 09, 2020 at 09:04:00AM -, Didier Roche wrote:
> + Other use case:
> + On a non ZFS installation :
> + On a non ZFS installation with ZSys installed :

Can I suggest a ZFS installation that doesn't have zsys installed, as
well? There's at least a dozen of us that used the guide from the ZFS On
Linux wiki on running Ubuntu on ZFS on LUKS, and may not have zsys
installed (I'm a bit afraid of trying it myself, perhaps assumptions it
makes aren't assumptions I made.)

Thanks

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to shadow in Ubuntu.
https://bugs.launchpad.net/bugs/1870058

Title:
  Collect deleted users

Status in shadow package in Ubuntu:
  Fix Released
Status in zsys package in Ubuntu:
  Fix Released
Status in shadow source package in Focal:
  New
Status in zsys source package in Focal:
  New

Bug description:
  [Impact]
   * Deleting users were preserving corresponding ZFS user datasets, without 
marking them for cleanup.
   * This is covered by dedicated use cases.

  [Test Case]
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. Check that rpool/USERDATA/foo_ has its content removed and is not 
mounted
   4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
  ---
  Other use case:
   1.Ensure you have a foo user:
   2. Run userdel foo
   3. Check that rpool/USERDATA/foo_ still has its content, but is not 
mounted.
   4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
  ---
  On a non ZFS installation :
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. The user is deleted, no error occured.
  ---
  On a non ZFS installation with ZSys installed :
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. The user is deleted, no error occured.

  [Regression Potential]
   * A new hidden command is added, triggered by userdel.
   * Tests are covering this new command and GRPC request.
   * The methodology is similar to useradd and usermod. The dependency between 
shadow and zsys is weak on purpose:
   - the ZSys hidden command is available and is a no-op if not called
   - if calling the command failed on userdel, nothing is done on ZSys side, 
but the code path is similar to ZSys not being installed or running on a non 
ZFS system.

  

  Ideally, we would untag them as part of GC so that we can clean them
  up later. However, those can be linked to states on other pools with
  same pool name than targetted one, and it will be hard to match them.

  Give a command for users to see them in status and then manually
  remove suspicious datasets ?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/shadow/+bug/1870058/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1870058] Re: Collect deleted users

2020-06-09 Thread Didier Roche
** Description changed:

+ [Impact]
+  * Deleting users were preserving corresponding ZFS user datasets, without 
marking them for cleanup.
+  * This is covered by dedicated use cases.
+ 
+ [Test Case]
+  1. Ensure you have a foo user:
+  2. Run userdel --remove foo
+  3. Check that rpool/USERDATA/foo_ has its content removed and is not 
mounted
+  4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
+ ---
+ Other use case:
+  1.Ensure you have a foo user:
+  2. Run userdel foo
+  3. Check that rpool/USERDATA/foo_ still has its content, but is not 
mounted.
+  4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
+ ---
+ On a non ZFS installation :
+  1. Ensure you have a foo user:
+  2. Run userdel --remove foo
+  3. The user is deleted, no error occured.
+ ---
+ On a non ZFS installation with ZSys installed :
+  1. Ensure you have a foo user:
+  2. Run userdel --remove foo
+  3. The user is deleted, no error occured.
+ 
+ [Regression Potential]
+  * A new hidden command is added, triggered by userdel.
+  * Tests are covering this new command and GRPC request.
+  * The methodology is similar to useradd and usermod. The dependency between 
shadow and zsys is weak on purpose:
+  - the ZSys hidden command is available and is a no-op if not called
+  - if calling the command failed on userdel, nothing is done on ZSys side, 
but the code path is similar to ZSys not being installed or running on a non 
ZFS system.
+ 
+ 
+ 
  Ideally, we would untag them as part of GC so that we can clean them up
  later. However, those can be linked to states on other pools with same
  pool name than targetted one, and it will be hard to match them.
  
  Give a command for users to see them in status and then manually remove
  suspicious datasets ?

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to shadow in Ubuntu.
https://bugs.launchpad.net/bugs/1870058

Title:
  Collect deleted users

Status in shadow package in Ubuntu:
  Fix Released
Status in zsys package in Ubuntu:
  Fix Released
Status in shadow source package in Focal:
  New
Status in zsys source package in Focal:
  New

Bug description:
  [Impact]
   * Deleting users were preserving corresponding ZFS user datasets, without 
marking them for cleanup.
   * This is covered by dedicated use cases.

  [Test Case]
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. Check that rpool/USERDATA/foo_ has its content removed and is not 
mounted
   4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
  ---
  Other use case:
   1.Ensure you have a foo user:
   2. Run userdel foo
   3. Check that rpool/USERDATA/foo_ still has its content, but is not 
mounted.
   4. zfs get com.ubuntu.zsys:bootfs-dataset rpool/USERDATA/foo_ is not 
associated with current system dataset
  ---
  On a non ZFS installation :
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. The user is deleted, no error occured.
  ---
  On a non ZFS installation with ZSys installed :
   1. Ensure you have a foo user:
   2. Run userdel --remove foo
   3. The user is deleted, no error occured.

  [Regression Potential]
   * A new hidden command is added, triggered by userdel.
   * Tests are covering this new command and GRPC request.
   * The methodology is similar to useradd and usermod. The dependency between 
shadow and zsys is weak on purpose:
   - the ZSys hidden command is available and is a no-op if not called
   - if calling the command failed on userdel, nothing is done on ZSys side, 
but the code path is similar to ZSys not being installed or running on a non 
ZFS system.

  

  Ideally, we would untag them as part of GC so that we can clean them
  up later. However, those can be linked to states on other pools with
  same pool name than targetted one, and it will be hard to match them.

  Give a command for users to see them in status and then manually
  remove suspicious datasets ?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/shadow/+bug/1870058/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1870058] Re: Collect deleted users

2020-06-09 Thread Didier Roche
** Changed in: shadow (Ubuntu)
   Importance: Undecided => Medium

** Changed in: shadow (Ubuntu)
 Assignee: (unassigned) => Didier Roche (didrocks)

** Changed in: zsys (Ubuntu)
 Assignee: (unassigned) => Didier Roche (didrocks)

** Also affects: shadow (Ubuntu Focal)
   Importance: Undecided
   Status: New

** Also affects: zsys (Ubuntu Focal)
   Importance: Undecided
   Status: New

** Changed in: shadow (Ubuntu Focal)
 Assignee: (unassigned) => Didier Roche (didrocks)

** Changed in: shadow (Ubuntu Focal)
   Importance: Undecided => Medium

** Changed in: zsys (Ubuntu Focal)
 Assignee: (unassigned) => Didier Roche (didrocks)

** Changed in: zsys (Ubuntu Focal)
   Importance: Undecided => Medium

** Changed in: shadow (Ubuntu)
   Status: New => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to shadow in Ubuntu.
https://bugs.launchpad.net/bugs/1870058

Title:
  Collect deleted users

Status in shadow package in Ubuntu:
  Fix Released
Status in zsys package in Ubuntu:
  Fix Released
Status in shadow source package in Focal:
  New
Status in zsys source package in Focal:
  New

Bug description:
  Ideally, we would untag them as part of GC so that we can clean them
  up later. However, those can be linked to states on other pools with
  same pool name than targetted one, and it will be hard to match them.

  Give a command for users to see them in status and then manually
  remove suspicious datasets ?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/shadow/+bug/1870058/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1870058] Re: Collect deleted users

2020-06-02 Thread Launchpad Bug Tracker
This bug was fixed in the package zsys - 0.5.0

---
zsys (0.5.0) groovy; urgency=medium

  [ Jean-Baptiste Lallement ]
  [ Didier Roche ]
  * Fix infinite GC loop (LP: #1870461)
  * Enhance timeout handling to avoid error rpc error: code = DeadlineExceeded
desc = context deadline exceeded while the daemon is doing work
(LP: #1875564)
  * Stop taking automated or manual snapshot when there is less than 20% of
free disk space (LP: #1876334)
  * Enable trim support for upgrading users (LP: #1881540)
  * Only clean up previously linked user datasets when unlinked under USERDATA
(LP: #1881538)
  * Strategy for deleted user datasets via a new hidden command called by
userdel (LP: #1870058)
  * Get better auto snapshots message when integrated to apt (LP: #1875420)
  * Update LastUsed on shutdown via a new hidden command service call
(LP: #1881536)
  * Prevent segfault immediately after install when zfs kernel module isn't
loaded (LP: #1881541)
  * Don’t try to autosave gdm user (and in general non system user), even if
systemd --user is started for them. (LP: #1881539)
  * Prevent apt printing errors when zsys is removed without purge
(LP: #1881535)
  * Some tests enhancements:
- new tests for all the above
- allow setting a different local socket for debugging/tests purposes only
- ascii order datasets in golden files
  * Typos and messages fixes. Direct prints are not prefixed with INFO
anymore.
  * Refreshed po and readme with the above.

 -- Didier Roche   Mon, 01 Jun 2020 09:26:52 +0200

** Changed in: zsys (Ubuntu)
   Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to shadow in Ubuntu.
https://bugs.launchpad.net/bugs/1870058

Title:
  Collect deleted users

Status in shadow package in Ubuntu:
  New
Status in zsys package in Ubuntu:
  Fix Released

Bug description:
  Ideally, we would untag them as part of GC so that we can clean them
  up later. However, those can be linked to states on other pools with
  same pool name than targetted one, and it will be hard to match them.

  Give a command for users to see them in status and then manually
  remove suspicious datasets ?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/shadow/+bug/1870058/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1870058] Re: Collect deleted users

2020-06-01 Thread Didier Roche
** Summary changed:

- Collect unmatched bootfs-datasets on all userdata
+ Collect deleted users

** Also affects: shadow (Ubuntu)
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to shadow in Ubuntu.
https://bugs.launchpad.net/bugs/1870058

Title:
  Collect deleted users

Status in shadow package in Ubuntu:
  New
Status in zsys package in Ubuntu:
  Triaged

Bug description:
  Ideally, we would untag them as part of GC so that we can clean them
  up later. However, those can be linked to states on other pools with
  same pool name than targetted one, and it will be hard to match them.

  Give a command for users to see them in status and then manually
  remove suspicious datasets ?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/shadow/+bug/1870058/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp