[Touch-packages] [Bug 1889166] Re: mir: build failure on s390x

2021-01-05 Thread Launchpad Bug Tracker
This bug was fixed in the package mir - 2.2.0-0ubuntu2 --- mir (2.2.0-0ubuntu2) hirsute; urgency=medium * debian/patches/disable-stringop-truncation.patch: - Disable -Werror=stringop-truncation on imported xcursor.c file. This trggers on s390x (and only s390x?), but the

[Touch-packages] [Bug 1889166] Re: mir: build failure on s390x

2020-12-16 Thread Alan Griffiths
In src/miral/CMakeLists.txt Change: set_source_files_properties(xcursor.c PROPERTIES COMPILE_DEFINITIONS _GNU_SOURCE) to set_source_files_properties(xcursor.c PROPERTIES COMPILE_DEFINITIONS _GNU_SOURCE COMPILE_FLAGS "-Wno-error=stringop-truncation" ) -- You

[Touch-packages] [Bug 1889166] Re: mir: build failure on s390x

2020-07-30 Thread Gianfranco Costamagna
@raof this is probably true if the path is long, but I can't figure out how to patch it... -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to mir in Ubuntu. https://bugs.launchpad.net/bugs/1889166 Title: mir: build failure on

[Touch-packages] [Bug 1889166] Re: mir: build failure on s390x

2020-07-30 Thread Chris Halse Rogers
While it's true this won't result in an unterminated char*, I think (but am not sure) that it *is* a logic bug. Because it will be truncating the string by overwriting the final (non-null) character with null? -- You received this bug notification because you are a member of Ubuntu Touch seeded

[Touch-packages] [Bug 1889166] Re: mir: build failure on s390x

2020-07-28 Thread Gianfranco Costamagna
I'm not closing this bug, because overriding the build flag is not a fix... -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to mir in Ubuntu. https://bugs.launchpad.net/bugs/1889166 Title: mir: build failure on s390x Status

[Touch-packages] [Bug 1889166] Re: mir: build failure on s390x

2020-07-28 Thread Gianfranco Costamagna
Yep, I created a minimal test case on my laptop, and couldn't figure out why there was this warning in first place. At the end, I ended up in something like this: http://launchpadlibrarian.net/490452795/mir_1.7.1-0ubuntu6_1.7.1-0ubuntu7.diff.gz -- You received this bug notification because you

[Touch-packages] [Bug 1889166] Re: mir: build failure on s390x

2020-07-28 Thread Alan Griffiths
Looking at the code, it is written correctly and handles the case where strncpy() "truncates before the terminating nul". It is unfortunate that this triggers a warning. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to mir in

[Touch-packages] [Bug 1889166] Re: mir: build failure on s390x

2020-07-28 Thread Gianfranco Costamagna
** Description changed: Hello, looks like we are missing one "+1" from somewhere, but I don't have enough knowledge on this code... can you please have a look? in the - meanwhile I0n giubg to disable that error + meanwhile I'm probably going to disable that error cd

[Touch-packages] [Bug 1889166] Re: mir: build failure on s390x

2020-07-28 Thread Hans Joachim Desserud
** Tags added: ftbfs -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to mir in Ubuntu. https://bugs.launchpad.net/bugs/1889166 Title: mir: build failure on s390x Status in mir package in Ubuntu: New Bug description: