[Touch-packages] [Bug 1932010] Re: [21.10 FEAT] zlib CRC32 optimization for s390x
** Changed in: ubuntu-z-systems Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to zlib in Ubuntu. https://bugs.launchpad.net/bugs/1932010 Title: [21.10 FEAT] zlib CRC32 optimization for s390x Status in Ubuntu on IBM z Systems: Fix Released Status in zlib package in Ubuntu: Fix Released Bug description: Use SIMD instructions to accelerate the zlib CRC32 implementation. Business value: Performance improvement in database area The zlib CRC32 optimization for IBM Z is currently being discussed for inclusion into zlib-ng: https://github.com/zlib-ng/zlib-ng/pull/912 The patch for zlib will be based on that. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1932010/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1932010] Re: [21.10 FEAT] zlib CRC32 optimization for s390x
This bug was fixed in the package zlib - 1:1.2.11.dfsg-2ubuntu7 --- zlib (1:1.2.11.dfsg-2ubuntu7) impish; urgency=medium [ Simon Chopin ] * d/rules: use configure options for dfltcc instead of hardcoding the CFLAGS * d/p/lp1932010-ibm-z-add-vectorized-crc32-implementation.patch ported from zlib-ng #912, adding a vectorized implementation of CRC32 on s390x architectures based on kernel code. LP: #1932010 [ Michael Hudson-Doyle ] * d/p/lp1932010-ibm-z-add-vectorized-crc32-implementation.patch: adjust to not make a PLT call in an ifunc on s390/s390x. -- Simon Chopin Thu, 12 Aug 2021 15:45:49 +1200 ** Changed in: zlib (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to zlib in Ubuntu. https://bugs.launchpad.net/bugs/1932010 Title: [21.10 FEAT] zlib CRC32 optimization for s390x Status in Ubuntu on IBM z Systems: Fix Committed Status in zlib package in Ubuntu: Fix Released Bug description: Use SIMD instructions to accelerate the zlib CRC32 implementation. Business value: Performance improvement in database area The zlib CRC32 optimization for IBM Z is currently being discussed for inclusion into zlib-ng: https://github.com/zlib-ng/zlib-ng/pull/912 The patch for zlib will be based on that. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1932010/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1932010] Re: [21.10 FEAT] zlib CRC32 optimization for s390x
Since the updated package version arrived in impish-proposed: zlib | 1:1.2.11.dfsg-2ubuntu7 | impish-proposed | source I'm updating the status to Fix Committed. ** Changed in: zlib (Ubuntu) Status: In Progress => Fix Committed ** Changed in: ubuntu-z-systems Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to zlib in Ubuntu. https://bugs.launchpad.net/bugs/1932010 Title: [21.10 FEAT] zlib CRC32 optimization for s390x Status in Ubuntu on IBM z Systems: Fix Committed Status in zlib package in Ubuntu: Fix Committed Bug description: Use SIMD instructions to accelerate the zlib CRC32 implementation. Business value: Performance improvement in database area The zlib CRC32 optimization for IBM Z is currently being discussed for inclusion into zlib-ng: https://github.com/zlib-ng/zlib-ng/pull/912 The patch for zlib will be based on that. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1932010/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1932010] Re: [21.10 FEAT] zlib CRC32 optimization for s390x
** Changed in: zlib (Ubuntu) Importance: Undecided => High -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to zlib in Ubuntu. https://bugs.launchpad.net/bugs/1932010 Title: [21.10 FEAT] zlib CRC32 optimization for s390x Status in Ubuntu on IBM z Systems: In Progress Status in zlib package in Ubuntu: In Progress Bug description: Use SIMD instructions to accelerate the zlib CRC32 implementation. Business value: Performance improvement in database area The zlib CRC32 optimization for IBM Z is currently being discussed for inclusion into zlib-ng: https://github.com/zlib-ng/zlib-ng/pull/912 The patch for zlib will be based on that. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1932010/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1932010] Re: [21.10 FEAT] zlib CRC32 optimization for s390x
I made the changes iii suggested and uploaded. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to zlib in Ubuntu. https://bugs.launchpad.net/bugs/1932010 Title: [21.10 FEAT] zlib CRC32 optimization for s390x Status in Ubuntu on IBM z Systems: In Progress Status in zlib package in Ubuntu: In Progress Bug description: Use SIMD instructions to accelerate the zlib CRC32 implementation. Business value: Performance improvement in database area The zlib CRC32 optimization for IBM Z is currently being discussed for inclusion into zlib-ng: https://github.com/zlib-ng/zlib-ng/pull/912 The patch for zlib will be based on that. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1932010/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1932010] Re: [21.10 FEAT] zlib CRC32 optimization for s390x
I don't have access to your bugzilla, so I'm assuming you pointed to your own patch and its crc32.c section where you pass hwcap by argument and call it earlier in the stack? If so, I've implemented this approach in this new debdiff, and the PPA has been updated as well :-). Michael, if you're wondering why the s390_crc32_vx has migrated to crc32.c, it's because the GLibc documentation mentions something about ifunc only working properly if the deported functions are in the same translation unit. In the end, my version of the patch doesn't look that different to Ilya's ;-) ** Patch added: "zlib.debdiff" https://bugs.launchpad.net/ubuntu/+source/zlib/+bug/1932010/+attachment/5517342/+files/zlib.debdiff -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to zlib in Ubuntu. https://bugs.launchpad.net/bugs/1932010 Title: [21.10 FEAT] zlib CRC32 optimization for s390x Status in Ubuntu on IBM z Systems: In Progress Status in zlib package in Ubuntu: In Progress Bug description: Use SIMD instructions to accelerate the zlib CRC32 implementation. Business value: Performance improvement in database area The zlib CRC32 optimization for IBM Z is currently being discussed for inclusion into zlib-ng: https://github.com/zlib-ng/zlib-ng/pull/912 The patch for zlib will be based on that. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1932010/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1932010] Re: [21.10 FEAT] zlib CRC32 optimization for s390x
Indeed, nice catch! The _32 and _64 variants weren't used anymore, either. Updated debdiff attached, and a ~ppa2 version has been uploaded to my PPA. ** Patch added: "zlib.debdiff" https://bugs.launchpad.net/ubuntu/+source/zlib/+bug/1932010/+attachment/5517264/+files/zlib.debdiff -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to zlib in Ubuntu. https://bugs.launchpad.net/bugs/1932010 Title: [21.10 FEAT] zlib CRC32 optimization for s390x Status in Ubuntu on IBM z Systems: In Progress Status in zlib package in Ubuntu: In Progress Bug description: Use SIMD instructions to accelerate the zlib CRC32 implementation. Business value: Performance improvement in database area The zlib CRC32 optimization for IBM Z is currently being discussed for inclusion into zlib-ng: https://github.com/zlib-ng/zlib-ng/pull/912 The patch for zlib will be based on that. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1932010/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1932010] Re: [21.10 FEAT] zlib CRC32 optimization for s390x
At a very quick glance, Simon's patch looks a bit closer to the pull request than the one in comment #4, so if you could test that soon that would be good. Simon, aside from debian/patches/lp1932010-ibm-z-add-vectorized- crc32-implementation.patch which I'm not sure I'm competent to review beyond seeing how it compares to the pull request, your patch looks mostly fine but it seems you've duplicated the definition of CONFIGURE_* in debian/rules? You probably don't want to do that? -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to zlib in Ubuntu. https://bugs.launchpad.net/bugs/1932010 Title: [21.10 FEAT] zlib CRC32 optimization for s390x Status in Ubuntu on IBM z Systems: In Progress Status in zlib package in Ubuntu: In Progress Bug description: Use SIMD instructions to accelerate the zlib CRC32 implementation. Business value: Performance improvement in database area The zlib CRC32 optimization for IBM Z is currently being discussed for inclusion into zlib-ng: https://github.com/zlib-ng/zlib-ng/pull/912 The patch for zlib will be based on that. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1932010/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1932010] Re: [21.10 FEAT] zlib CRC32 optimization for s390x
** Changed in: ubuntu-z-systems Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to zlib in Ubuntu. https://bugs.launchpad.net/bugs/1932010 Title: [21.10 FEAT] zlib CRC32 optimization for s390x Status in Ubuntu on IBM z Systems: In Progress Status in zlib package in Ubuntu: In Progress Bug description: Use SIMD instructions to accelerate the zlib CRC32 implementation. Business value: Performance improvement in database area The zlib CRC32 optimization for IBM Z is currently being discussed for inclusion into zlib-ng: https://github.com/zlib-ng/zlib-ng/pull/912 The patch for zlib will be based on that. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1932010/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1932010] Re: [21.10 FEAT] zlib CRC32 optimization for s390x
You'll find a built version of the package in my PPA : https://launchpad.net/~schopin/+archive/ubuntu/test- ppa/+sourcepub/12641334/+listing-archive-extra -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to zlib in Ubuntu. https://bugs.launchpad.net/bugs/1932010 Title: [21.10 FEAT] zlib CRC32 optimization for s390x Status in Ubuntu on IBM z Systems: Triaged Status in zlib package in Ubuntu: In Progress Bug description: Use SIMD instructions to accelerate the zlib CRC32 implementation. Business value: Performance improvement in database area The zlib CRC32 optimization for IBM Z is currently being discussed for inclusion into zlib-ng: https://github.com/zlib-ng/zlib-ng/pull/912 The patch for zlib will be based on that. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1932010/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1932010] Re: [21.10 FEAT] zlib CRC32 optimization for s390x
Here's a debdiff containing a backported version of the feature. There is also a small refactoring as it allowed me to easily integrate the new feature in the build process. ** Changed in: zlib (Ubuntu) Assignee: Canonical Foundations Team (canonical-foundations) => Simon Chopin (schopin) ** Changed in: zlib (Ubuntu) Status: New => In Progress ** Patch added: "zlib.debdiff" https://bugs.launchpad.net/ubuntu/+source/zlib/+bug/1932010/+attachment/5517082/+files/zlib.debdiff ** Information type changed from Private to Public -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to zlib in Ubuntu. https://bugs.launchpad.net/bugs/1932010 Title: [21.10 FEAT] zlib CRC32 optimization for s390x Status in Ubuntu on IBM z Systems: Triaged Status in zlib package in Ubuntu: In Progress Bug description: Use SIMD instructions to accelerate the zlib CRC32 implementation. Business value: Performance improvement in database area The zlib CRC32 optimization for IBM Z is currently being discussed for inclusion into zlib-ng: https://github.com/zlib-ng/zlib-ng/pull/912 The patch for zlib will be based on that. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1932010/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
