Re: [Toybox] [PATCH] ifconfig FTBFS here-needs sys/un.h

2013-04-22 Thread Rob Landley
On 04/21/2013 06:56:03 PM, Isaac Dunham wrote: Hello, I did make allyesconfig; make (to test ifconfig) and get this: Compile toybox... toys/pending/ifconfig.c: In function 'is_host_unix': toys/pending/ifconfig.c:121: error: invalid application of 'sizeof' to incomplete type 'struct

Re: [Toybox] More find cleanup

2013-04-22 Thread Felix Janda
On 04/21/13 at 11:01pm, Rob Landley wrote: [snip] Ok, I thought more about the extra jumping around than about the integer checks. But actually it should only 2 additional jumps (jumping to the case label and jumping out of the switch with break). Disk access should totally dominate

[Toybox] Differences between modinfo in toybox and standard version

2013-04-22 Thread Isaac Dunham
Hello, The kernel maps all occurences of '-' in module names to '_', so that if you load a module such as snd-pcm-oss.ko or phc-k8.ko, it is presented by lsmod and /proc/modules as module snd_pcm_oss or phc_k8. Modinfo from module-init-tools makes up for that by reversing the logic and treating

Re: [Toybox] [CLEANUP] [PATCH] stat: Some cleanup

2013-04-22 Thread Rob Landley
On 04/22/2013 04:27:56 PM, Felix Janda wrote: On 04/21/13 at 11:30pm, Rob Landley wrote: Should %T be implemented? I'd wait for somebody to complain about its absence. I like that approach. Attached is another patch removing unimplemented options/formats and doing a bit of cleanup (mainly

Re: [Toybox] Differences between modinfo in toybox and standard version

2013-04-22 Thread Rob Landley
On 04/22/2013 05:40:28 PM, Isaac Dunham wrote: Hello, The kernel maps all occurences of '-' in module names to '_', so that if you load a module such as snd-pcm-oss.ko or phc-k8.ko, it is presented by lsmod and /proc/modules as module snd_pcm_oss or phc_k8. Modinfo from module-init-tools

Re: [Toybox] Differences between modinfo in toybox and standard version

2013-04-22 Thread idunham
On Mon, Apr 22, 2013 at 07:36:18PM -0500, Rob Landley wrote: On 04/22/2013 05:40:28 PM, Isaac Dunham wrote: Hello, The kernel maps all occurences of '-' in module names to '_', so that if you load a module such as snd-pcm-oss.ko or phc-k8.ko, it is presented by lsmod and /proc/modules as