Re: [Toybox] - Add route

2013-09-07 Thread Ashwini Sharma
On Sat, Sep 7, 2013 at 11:47 PM, Isaac wrote: > On Mon, Sep 02, 2013 at 11:15:14AM +0900, Ashwini Sharma wrote: > > HI Rob & list, > > > > Attached is the patch for _route_ command. It does display, add and del > > functions for routing tables. > > Have a look at it. > > > > regards, > > Ashwin

Re: [Toybox] [PATCH] tail fixes

2013-09-07 Thread Felix Janda
> > >// If lseek() doesn't work on this stream, return now. > > > - if (pos<0) return 0; > > > + if (pos == -1) return 0; > > > > And yet you compare it with a negative. Maybe the bit patterns work > > out, but I'm uncomfortable with that. I can see a compiler optimizing > > this out sim

Re: [Toybox] - Add route

2013-09-07 Thread Isaac
On Mon, Sep 02, 2013 at 11:15:14AM +0900, Ashwini Sharma wrote: > HI Rob & list, > > Attached is the patch for _route_ command. It does display, add and del > functions for routing tables. > Have a look at it. > > regards, > Ashwini Kumar OK, I took a quick look through it. First, thanks for d

Re: [Toybox] - Add fsck

2013-09-07 Thread Ashwini Sharma
On Sat, Sep 7, 2013 at 6:41 PM, Rob Landley wrote: > On 09/03/2013 03:00:50 AM, Ashwini Sharma wrote: > >> Hi Rob, >> >> Attached is the patch for _fsck_ toy. >> >> This will parse _/etc/fstab_ for devices and their properties and then >> does >> a _fork_ _exec_ for the >> fsck. tool. >> > > I'm

Re: [Toybox] [PATCH] tail fixes

2013-09-07 Thread Felix Janda
Rob Landley wrote: > On 08/31/2013 05:53:09 AM, Felix Janda wrote: > > This should now hopefully fix the earlier segfaults. > > > > In the case that lseek doesn't work and we count from the end > > the algorithms for tail -n and tail -c are now more separate. > > (tail -c is now more efficient sin

Re: [Toybox] - Add fsck

2013-09-07 Thread Rob Landley
On 09/03/2013 03:00:50 AM, Ashwini Sharma wrote: Hi Rob, Attached is the patch for _fsck_ toy. This will parse _/etc/fstab_ for devices and their properties and then does a _fork_ _exec_ for the fsck. tool. I'm in the process of adding the /etc/fstab parsing code for umount (for user mou