[Toybox] [CLEANUP] makedevs

2014-06-25 Thread Rob Landley
Commit 1362: http://landley.net/hg/toybox/rev/1362 First question: Are there any test command lines I can use for this? The 64 byte limitation on name is arbitrary, it's the start of the string so we might as well just null terminate and use that memory. The help text says to feed '-' to

[Toybox] [CLEANUP] mkpasswd.c

2014-06-25 Thread Rob Landley
Commit 1363: http://landley.net/hg/toybox/rev/1363 Ok, starting with toys/pending/mkpasswd.c: The is_salt_valid() function is only called from one place, and using a regex to check isalnum() or two punctuation characters is a bit overkill. (Since we did not use TOYFLAG_LOCALE we're in the C

Re: [Toybox] [CLEANUP] mkpasswd.c

2014-06-25 Thread Isaac Dunham
On Wed, Jun 25, 2014 at 11:02:03PM -0500, Rob Landley wrote: We don't need -m help when we can put the list of supported types in the help text itself. (Unless this is used programmatically to autodetect support? The ubuntu version outputs a lot of extra verbiage that would make parsing hard,