Re: [Toybox] [PATCH] acpi: change when to recurse

2014-10-06 Thread Isaac Dunham
On Mon, Oct 06, 2014 at 12:36:08AM -0500, Rob Landley wrote: On 10/05/14 23:13, Isaac Dunham wrote: On Sun, Oct 05, 2014 at 04:28:21PM -0500, Rob Landley wrote: On 10/04/14 15:52, Isaac Dunham wrote: acpi: never follow symlinks, always recurse in dirs. /sys/class contains several

Re: [Toybox] [PATCH] acpi: change when to recurse

2014-10-06 Thread Rob Landley
On 10/06/14 17:23, Isaac Dunham wrote: On Mon, Oct 06, 2014 at 12:36:08AM -0500, Rob Landley wrote: On 10/05/14 23:13, Isaac Dunham wrote: On Sun, Oct 05, 2014 at 04:28:21PM -0500, Rob Landley wrote: On 10/04/14 15:52, Isaac Dunham wrote: acpi: never follow symlinks, always recurse in dirs.

[Toybox] [Patches] - Some more static analysis fixes

2014-10-06 Thread Ashwini Sharma
Hi Rob, List, Attached are few more static analysis fixes. This includes issues like resource leaks, logical dead codes etc... chgrp.c: Issue is in case when CFG_FREE and verbose mode enabled. Garbage output was there. comm.c: loop error id.c: single build issue for OLD_TOYs, same issue is