Re: [Toybox] [PATCH 1/4] Implement hostname lookups in display_routes

2020-06-02 Thread Rob Landley
On 6/2/20 4:13 PM, Eric Molitor wrote: > Mmh, I just switched my dev machine from Alpine to Ubuntu before working on > this, normally I would have caught this. > > Rob, what are your thoughts on using GitHub actions to build toybox on Alpine, > Ubuntu and MacOS and running through the test suite?

Re: [Toybox] [PATCH 1/4] Implement hostname lookups in display_routes

2020-06-02 Thread Eric Molitor
Mmh, I just switched my dev machine from Alpine to Ubuntu before working on this, normally I would have caught this. Rob, what are your thoughts on using GitHub actions to build toybox on Alpine, Ubuntu and MacOS and running through the test suite? This would have caught this earlier. I'm happy

Re: [Toybox] [PATCH 1/4] Implement hostname lookups in display_routes

2020-06-02 Thread Rich Felker
On Tue, Jun 02, 2020 at 12:42:41PM -0500, Rob Landley wrote: > On 6/2/20 12:25 PM, Rich Felker wrote: > > This likely needs a new __UAPI_* macro to suppress it. It's likely > > that nobody has hit it because sys/sysinfo.h is a pretty obscure > > header and it's usually not included anywhere except

Re: [Toybox] [PATCH 1/4] Implement hostname lookups in display_routes

2020-06-02 Thread Rich Felker
On Tue, Jun 02, 2020 at 12:42:41PM -0500, Rob Landley wrote: > On 6/2/20 12:25 PM, Rich Felker wrote: > > This likely needs a new __UAPI_* macro to suppress it. It's likely > > that nobody has hit it because sys/sysinfo.h is a pretty obscure > > header and it's usually not included anywhere except

Re: [Toybox] [PATCH 1/4] Implement hostname lookups in display_routes

2020-06-02 Thread Rob Landley
On 6/2/20 12:25 PM, Rich Felker wrote: > This likely needs a new __UAPI_* macro to suppress it. It's likely > that nobody has hit it because sys/sysinfo.h is a pretty obscure > header and it's usually not included anywhere except uptime(1), etc. > Having it in lib/portability.h, rather than just

Re: [Toybox] [PATCH 1/4] Implement hostname lookups in display_routes

2020-06-02 Thread Rich Felker
On Tue, Jun 02, 2020 at 10:56:37AM -0500, Rob Landley wrote: > On 6/1/20 10:56 AM, Eric Molitor wrote: > > --- > > toys/pending/route.c | 46 +++- > > 1 file changed, 33 insertions(+), 13 deletions(-) > > FYI route.c doesn't build with musl-cross-make

Re: [Toybox] [PATCH 1/4] Implement hostname lookups in display_routes

2020-06-02 Thread Rob Landley
On 6/1/20 10:56 AM, Eric Molitor wrote: > --- > toys/pending/route.c | 46 +++- > 1 file changed, 33 insertions(+), 13 deletions(-) FYI route.c doesn't build with musl-cross-make because: