On Thu, Jan 25, 2024 at 10:00 PM Rob Landley wrote:
> On 1/25/24 17:46, enh wrote:
> > On Wed, Jan 24, 2024 at 11:56 PM Rob Landley wrote:
> > Should the mlock() be optional? (Maybe -m? Or for backwards
> compatibility keep
> > it the default and -M to _not_ lock? Dirtying isn't optional
On Fri, Jan 26, 2024 at 3:41 PM Rob Landley wrote:
> On 1/26/24 11:28, enh via Toybox wrote:
> > The ULONG_MAX turns into -1 here, which isn't what was intended.
>
> Ah. That one ONLY works on 32 bit. Oops.
>
(yeah, sorry, i realized after sending my patch that my LP64 bigotry was
showing
On 1/26/24 11:28, enh via Toybox wrote:
> The ULONG_MAX turns into -1 here, which isn't what was intended.
Ah. That one ONLY works on 32 bit. Oops.
(I went down a research rathole trying to work out whether the spectre/meltdown
mitigations that unmapped the kernel from normal userspace brought
hilariously, i now realize my grep fix was still incomplete... follow-on
patch sent.
(when you get round to the "we should generate rather than duplicate the
`usage: ${toy_name}` prefix" issue you sometimes talk about, i plan on
bugging you to see if you can do at least the switches :-) )
On
Since this is my second attempt over a fairly short period of time,
I'm not 100% confident this is really all of them -- and this casts
doubt on the other toys I checked too! -- but until the machines
take over this task, meatbots like me will have to keep trying...
---
toys/posix/grep.c | 2 +-
The ULONG_MAX turns into -1 here, which isn't what was intended.
I'll avoid the bikeshed of the least worst full fix and take half
the range which is plenty for my purposes.
Also fix the array indexing to not segfault.
---
toys/other/memeater.c | 4 ++--
1 file changed, 2 insertions(+), 2
On 1/25/24 13:51, enh wrote:
> ping? (one of these [grep] came up again today...)
I moved my local changes out of the way to apply it, and they MOSTLY made it
back. I only have to manually fix up:
patching file toys/net/netcat.c
Hunk #2 succeeded at 27 with fuzz 1.
patching file
