Re: [Toybox] [CLEANUP] mkpasswd.c

2014-06-26 Thread Isaac Dunham
On Thu, Jun 26, 2014 at 07:18:31AM -0500, Rob Landley wrote: On 06/26/14 00:20, Isaac Dunham wrote: On Wed, Jun 25, 2014 at 11:02:03PM -0500, Rob Landley wrote: We don't need -m help when we can put the list of supported types in the help text itself. (Unless this is used programmatically

[Toybox] [CLEANUP] mkpasswd.c

2014-06-25 Thread Rob Landley
Commit 1363: http://landley.net/hg/toybox/rev/1363 Ok, starting with toys/pending/mkpasswd.c: The is_salt_valid() function is only called from one place, and using a regex to check isalnum() or two punctuation characters is a bit overkill. (Since we did not use TOYFLAG_LOCALE we're in the C

Re: [Toybox] [CLEANUP] mkpasswd.c

2014-06-25 Thread Isaac Dunham
On Wed, Jun 25, 2014 at 11:02:03PM -0500, Rob Landley wrote: We don't need -m help when we can put the list of supported types in the help text itself. (Unless this is used programmatically to autodetect support? The ubuntu version outputs a lot of extra verbiage that would make parsing hard,