Re: [Toybox] [PATCH] mount: avoid deferencing NULL.

2024-03-21 Thread enh via Toybox
yeah, that looks neater anyway, and seems to work. thanks! On Wed, Mar 20, 2024 at 5:56 PM Rob Landley wrote: > > On 3/20/24 16:07, enh via Toybox wrote: > > I don't know why I wasn't seeing this yesterday > > Because /sys was mounted, so readfile() returned a string with its contents. > (And/or

Re: [Toybox] [PATCH] mount: avoid deferencing NULL.

2024-03-20 Thread Rob Landley
On 3/20/24 16:07, enh via Toybox wrote: > I don't know why I wasn't seeing this yesterday Because /sys was mounted, so readfile() returned a string with its contents. (And/or race condition of the mount going away between reading /proc/mounts and asking for follow-up data about a specific mount

[Toybox] [PATCH] mount: avoid deferencing NULL.

2024-03-20 Thread enh via Toybox
I don't know why I wasn't seeing this yesterday, but I can't _not_ see it today: newfstatat(AT_FDCWD, "/dev/block/loop6", {st_mode=S_IFBLK|0600, st_rdev=makedev(7, 48), ...}, 0) = 0 openat(AT_FDCWD, "/sys/block/loop48/loop/backing_file", O_RDONLY) = -1 ENOENT (No such file or directory) ---