Re: [Toybox] strlower() bug

2024-06-01 Thread Rob Landley
On 5/31/24 12:53, enh wrote: >> Let's see... Ah: >> >> https://www.unicode.org/L2/L1999/UnicodeData.html >> >> That's a bit long. My suggestion had 9 decimal numbers, this has "IDEOGRAPHIC >> TELEGRAPH SYMBOL FOR JANUARY" as one of fifteen fields, with " 0031 >> 6708" being another single field. Ho

Re: [Toybox] strlower() bug

2024-05-31 Thread enh via Toybox
On Fri, May 31, 2024 at 12:30 PM Rob Landley wrote: > > On 5/30/24 16:12, enh wrote: > >> > hmm... looking at Apple's online FreeBSD code, it looks like they have > >> > very different (presumably older) FreeBSD code > >> > [https://opensource.apple.com/source/Libc/Libc-320.1.3/locale/FreeBSD/tolo

Re: [Toybox] strlower() bug

2024-05-31 Thread Rob Landley
On 5/30/24 16:12, enh wrote: >> > hmm... looking at Apple's online FreeBSD code, it looks like they have >> > very different (presumably older) FreeBSD code >> > [https://opensource.apple.com/source/Libc/Libc-320.1.3/locale/FreeBSD/tolower.c.auto.html], >> > and the footer of the file that reads im

Re: [Toybox] strlower() bug

2024-05-30 Thread enh via Toybox
On Wed, May 29, 2024 at 5:50 AM Rob Landley wrote: > > On 5/22/24 09:30, enh wrote: > > On Tue, May 14, 2024 at 2:58 PM Rob Landley wrote: > >> It looks like macos towlower() refuses to return expanding unicode > >> characters. > >> Possibly to avoid exactly the kind of bug this fixed, in exchan

Re: [Toybox] strlower() bug

2024-05-29 Thread Rob Landley
On 5/22/24 09:30, enh wrote: > On Tue, May 14, 2024 at 2:58 PM Rob Landley wrote: >> It looks like macos towlower() refuses to return expanding unicode >> characters. >> Possibly to avoid exactly the kind of bug this fixed, in exchange for >> corrupting >> the data. > > yeah, i don't know wheth

Re: [Toybox] strlower() bug

2024-05-22 Thread enh via Toybox
On Tue, May 14, 2024 at 2:58 PM Rob Landley wrote: > > > > On 5/14/24 12:12, enh wrote: > > On Tue, May 14, 2024 at 1:04 PM Rob Landley wrote: > >> > >> On 5/14/24 07:10, enh wrote: > >> > macOS tests seem to be broken since this commit? > >> > > >> > FAIL: find strlower edge case > >> > echo -ne

Re: [Toybox] strlower() bug

2024-05-14 Thread Rob Landley
On 5/14/24 12:12, enh wrote: > On Tue, May 14, 2024 at 1:04 PM Rob Landley wrote: >> >> On 5/14/24 07:10, enh wrote: >> > macOS tests seem to be broken since this commit? >> > >> > FAIL: find strlower edge case >> > echo -ne '' | touch aⱥ; find . -iname aȺ >> > --- expect

Re: [Toybox] strlower() bug

2024-05-14 Thread enh via Toybox
On Tue, May 14, 2024 at 1:04 PM Rob Landley wrote: > > On 5/14/24 07:10, enh wrote: > > macOS tests seem to be broken since this commit? > > > > FAIL: find strlower edge case > > echo -ne '' | touch aⱥ; find . -iname aȺ > > --- expected 2024-05-10 17:32:56.0 + >

Re: [Toybox] strlower() bug

2024-05-14 Thread Rob Landley
On 5/14/24 07:10, enh wrote: > macOS tests seem to be broken since this commit? > > FAIL: find strlower edge case > echo -ne '' | touch aⱥ; find . -iname aȺ > --- expected 2024-05-10 17:32:56.0 + > +++ actual 2024-05-10 17:32:56.0 + > @@ -1 +0,0 @@ >

Re: [Toybox] strlower() bug

2024-05-14 Thread enh via Toybox
macOS tests seem to be broken since this commit? FAIL: find strlower edge case echo -ne '' | touch aⱥ; find . -iname aȺ --- expected 2024-05-10 17:32:56.0 + +++ actual 2024-05-10 17:32:56.0 + @@ -1 +0,0 @@ -./aⱥ On Wed, May 8, 2024 at 9:

Re: [Toybox] strlower() bug

2024-05-10 Thread Rob Landley
On 5/8/24 16:27, Ray Gardner wrote: > BTW I was a bit surprised that mentioning my awk for toybox got no reaction. Oh I'm interested, but somebody (probably you) mentioned they were looking into it before, and I'll wait to see some code first. :) (The problem with asking to see code early is pend

Re: [Toybox] strlower() bug

2024-05-08 Thread Ray Gardner
On 5/8/24 06:48, Rob Landley wrote: > On 5/6/24 17:12, Ray Gardner wrote: >> While working on an awk implementation for toybox, I found a bug in >> strlower(), which is used only in find.c. I've attached some tests to >> put in find.test to reveal it. I can't put them here directly because >> I don

Re: [Toybox] strlower() bug

2024-05-08 Thread Rob Landley
On 5/6/24 17:12, Ray Gardner wrote: > While working on an awk implementation for toybox, I found a bug in > strlower(), which is used only in find.c. I've attached some tests to > put in find.test to reveal it. I can't put them here directly because > I don't think the UTF-8 names will come through

[Toybox] strlower() bug

2024-05-06 Thread Ray Gardner
While working on an awk implementation for toybox, I found a bug in strlower(), which is used only in find.c. I've attached some tests to put in find.test to reveal it. I can't put them here directly because I don't think the UTF-8 names will come through. (I modelled my awk tolower()/toupper() cod