Re: [Toybox] More expand cleanups

2012-12-01 Thread Felix Janda
On 12/01/12 at 12:42am, Rob Landley wrote: On 11/30/2012 12:56:06 PM, Felix Janda wrote: On 11/30/12 at 02:51am, Rob Landley wrote: I updated wc to theoretically deal with buffer wraps better. In reality I haven't got UTF8 test data to run through this, and should probably find

Re: [Toybox] More expand cleanups

2012-11-30 Thread Rob Landley
On 11/28/2012 03:34:59 AM, Jonathan Clairembault wrote: Back to expand_file(). The downside of using readall() is that interactive granularity goes way down. I had this problem with tee once upon a time, it meant that piping the output of anything through tee made it appear in 4k

Re: [Toybox] More expand cleanups

2012-11-30 Thread Jonathan Clairembault
Possibly I should turn that into an actual automated testy thing. I shared a test script with expand code. Though I forgot to make it executable. Everything pass except backspace handling with the current version. Of course it does not test for utf-8 compatibility yet. Jonathan

Re: [Toybox] More expand cleanups

2012-11-30 Thread Felix Janda
On 11/30/12 at 02:51am, Rob Landley wrote: I updated wc to theoretically deal with buffer wraps better. In reality I haven't got UTF8 test data to run through this, and should probably find some at some point. Didn't the original version already deal well with it. (That's what the strange

Re: [Toybox] More expand cleanups

2012-11-28 Thread Jonathan Clairembault
On Wed, Nov 28, 2012 at 8:51 AM, Rob Landley r...@landley.net wrote: I don't like adding new types to global headers which are only used in one command, so change global tablist to be a void *... That will be used in unexpand but void * is fine anyway. Also, in the help text I'm tempted to