Re: [Toybox] [PATCH] env: fix case where a variable is replaced.

2019-05-03 Thread enh via Toybox
Thanks, it's there now. I'll see how that goes... *From:*Rob Landley *Date:*Fri, May 3, 2019, 13:29 *To:*enh, toybox Forgot to push, sorry. > > Rob > > On 5/3/19 2:47 PM, enh via Toybox wrote: > > ping? > > > > On Thu, May 2, 2019 at 6:47 PM enh wrote: > >> > >> Found when trying to update the

Re: [Toybox] [PATCH] env: fix case where a variable is replaced.

2019-05-03 Thread Rob Landley
Forgot to push, sorry. Rob On 5/3/19 2:47 PM, enh via Toybox wrote: > ping? > > On Thu, May 2, 2019 at 6:47 PM enh wrote: >> >> Found when trying to update the toybox prebuilt used for the Android >> build. >> >> Also add the corresponding test. >> --- >> lib/env.c | 4 +--- >>

Re: [Toybox] [PATCH] man: support MANPATH.

2019-05-03 Thread Rob Landley
On 4/29/19 7:36 PM, makepost wrote: > On Mon, Apr 29, 2019 at 04:33:07PM -0700, enh via Toybox wrote: > + if (!TT.M) TT.M = getenv("MANPATH"); > > Breaks unfortunately, distros e.g. gentoo are prefixing the main path in > the variable with colon divided binutils and gcc dirs, apparently for >

Re: [Toybox] [PATCH] Android moved the scheduler policy functions in Q.

2019-05-03 Thread enh via Toybox
On Fri, May 3, 2019 at 11:41 AM Rob Landley wrote: > > On 5/2/19 12:37 PM, enh wrote: > > On Thu, May 2, 2019 at 9:35 AM Rob Landley wrote: > >> > >> On 5/1/19 5:40 PM, enh via Toybox wrote: > >>> They're forwarded to libprocessgroup, but we may as well go straight to > >>> the source since

Re: [Toybox] [PATCH] env: fix case where a variable is replaced.

2019-05-03 Thread enh via Toybox
(long version: the version of tar in Q is a mess, so even at this late stage i'm tempted to try to sync with AOSP master, but i can't move forward because env is broken.) On Fri, May 3, 2019 at 12:47 PM enh wrote: > > ping? > > On Thu, May 2, 2019 at 6:47 PM enh wrote: > > > > Found when trying

Re: [Toybox] [PATCH] env: fix case where a variable is replaced.

2019-05-03 Thread enh via Toybox
ping? On Thu, May 2, 2019 at 6:47 PM enh wrote: > > Found when trying to update the toybox prebuilt used for the Android > build. > > Also add the corresponding test. > --- > lib/env.c | 4 +--- > tests/env.test | 2 ++ > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [Toybox] FYI: kernel builds rely on GNU expr extensions

2019-05-03 Thread enh via Toybox
On Fri, May 3, 2019 at 11:28 AM Rob Landley wrote: > > On 5/2/19 4:20 PM, enh wrote: > > (fwiw, with an instrumented build of the 4.19 Android common kernel, i > > only see `expr 4 * 65536 + 019 * 256 + 037`. so i don't know what > > they're _really_ doing to hit this.) > > Back under Aboriginal

Re: [Toybox] pathological case in sed s///g

2019-05-03 Thread enh via Toybox
On Fri, May 3, 2019 at 11:59 AM Rob Landley wrote: > > On 5/3/19 1:56 PM, Rob Landley wrote: > > On 5/3/19 1:05 PM, enh wrote: > > But yeah, the new pessimal case after the change I'm making now would be a > > megabyte of xyxyxyxy with 's/xy/x/g' _THAT_ would need the one output buffer > >

Re: [Toybox] pathological case in sed s///g

2019-05-03 Thread Rob Landley
On 5/3/19 1:05 PM, enh wrote: > BSD seems to avoid all the copying? i think they have a "source" and > "destination" and only write to the latter (solving your issue), but > only move forwards (so i don't think they try to maintain it as "what > the whole result would look like if we only did this

Re: [Toybox] pathological case in sed s///g

2019-05-03 Thread Rob Landley
On 5/3/19 1:56 PM, Rob Landley wrote: > On 5/3/19 1:05 PM, enh wrote: > But yeah, the new pessimal case after the change I'm making now would be a > megabyte of xyxyxyxy with 's/xy/x/g' _THAT_ would need the one output buffer > thing... And it can be avoided by an in-place copy that remembers

Re: [Toybox] [PATCH] Android moved the scheduler policy functions in Q.

2019-05-03 Thread Rob Landley
On 5/2/19 12:37 PM, enh wrote: > On Thu, May 2, 2019 at 9:35 AM Rob Landley wrote: >> >> On 5/1/19 5:40 PM, enh via Toybox wrote: >>> They're forwarded to libprocessgroup, but we may as well go straight to >>> the source since neither library is in the NDK anyway. >>> >>> This code is unfortunate

Re: [Toybox] FYI: kernel builds rely on GNU expr extensions

2019-05-03 Thread Rob Landley
On 5/2/19 4:20 PM, enh wrote: > (fwiw, with an instrumented build of the 4.19 Android common kernel, i > only see `expr 4 * 65536 + 019 * 256 + 037`. so i don't know what > they're _really_ doing to hit this.) Back under Aboriginal Linux what I'd do is prepare two parallel package build folders,

Re: [Toybox] pathological case in sed s///g

2019-05-03 Thread enh via Toybox
BSD seems to avoid all the copying? i think they have a "source" and "destination" and only write to the latter (solving your issue), but only move forwards (so i don't think they try to maintain it as "what the whole result would look like if we only did this many replacements", rather "here's

Re: [Toybox] pathological case in sed s///g

2019-05-03 Thread Rob Landley
On 5/3/19 12:40 PM, Rob Landley wrote: > On 5/2/19 9:46 PM, enh via Toybox wrote: >> i've known about this for a couple of days and haven't had time to >> look at it properly yet, so i should mention it here... >> >> if you have a file with a 1MiB line of 'x'es and you sed 's/x/y/g', >> BSD or GNU

Re: [Toybox] pathological case in sed s///g

2019-05-03 Thread Rob Landley
On 5/2/19 9:46 PM, enh via Toybox wrote: > i've known about this for a couple of days and haven't had time to > look at it properly yet, so i should mention it here... > > if you have a file with a 1MiB line of 'x'es and you sed 's/x/y/g', > BSD or GNU sed finishes immediately, but toybox takes