Thomas wrote:
> > Wait, your git --describe is finding a random tarball in some other
> > directory?
> >
> > That's really broken.
> ...
> > That's a pretty clear yocto bug (one I can't reproduce), but if you're
> > adding a workaround for this yocto bug the easy thing to do is keep
> > GITHASH if
Just commenting on this:
Rob Landley wrote:
> As for the lib/portability.h patch: FreeBSD doesn't have features.h, but
> Linux and MacOS X agree on that one? Odd. Speaking of which, we have
> __FreeBSD__ without #including features.h?
The compiler might define it similarly to how it defines
Rich Felker wrote:
...
> > glibc is the process of deprecating, and musl/uClibc would follow suit,
> > if not just drop the include altogether.
>
> musl has never had the issue. :-) because we don't implicitly include
> sys/sysmacros.h at all. The set of programs that have any use for
> these
Lipi C. H. Lee wrote:
> implement simple 'wget' and port name can be specified in URL if default
> port 80 is not used.
> It may be added to toys/pending directory.
Thanks for your submission!
Some comments below.
In general, try simplifying the error messages:
Rob Landley wrote:
On 05/02/2015 02:54 PM, enh wrote:
anyone else having trouble with make menuconfig? getprop and setprop
aren't showing up for me, and i don't see where to set
CONFIG_TOYBOX_ON_ANDROID and generated/mkflags segfaults if i have ls
configured and...
actually,
enh wrote:
On Mon, May 4, 2015 at 10:57 AM, Felix Janda felix.ja...@posteo.de wrote:
[..]
I just wanted to say that not everything is yet fixed. For example
'ls --color' does not work at all. (Seems to be related to the option
parsing.)
works for me. are you sure you have LS_COLOR
Rob Landley wrote:
On 03/28/2015 04:31 PM, Felix Janda wrote:
---
toys/posix/head.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/toys/posix/head.c b/toys/posix/head.c
index 42f945b..8e77b01 100644
--- a/toys/posix/head.c
+++ b/toys/posix/head.c
@@ -56,6
$ answer=42
$ var=$(for i in $(seq $answer); do printf a; done)
$ printf %s\n\n $var file
$ toybox grep -x $var file
aa
Segmentation fault
I haven't yet investigated the cause.
42 is the minimal value for the segfault to trigger.
Possibly relevant: I'm
This seems to be a bug in musl which will be fixed in musl-1.1.8.
Felix
___
Toybox mailing list
Toybox@lists.landley.net
http://lists.landley.net/listinfo.cgi/toybox-landley.net
Rob Landley wrote:
On 03/28/2015 04:31 PM, Felix Janda wrote:
---
toys/posix/head.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/toys/posix/head.c b/toys/posix/head.c
index 42f945b..8e77b01 100644
--- a/toys/posix/head.c
+++ b/toys/posix/head.c
@@ -56,6
---
toys/other/inotifyd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/toys/other/inotifyd.c b/toys/other/inotifyd.c
index f2e11ca..86f1a67 100644
--- a/toys/other/inotifyd.c
+++ b/toys/other/inotifyd.c
@@ -55,7 +55,6 @@ void inotifyd_main(void)
if (!masks) mask = 0xfff; // default
Rob Landley wrote:
On 01/08/2015 03:38 PM, Felix Janda wrote:
sed doesn't allow embedded newlines in the replacement for s///, e.g.
s/walrus/wal\
rus/
Indeed, that's the next sed bug I'm wrestling with right now.
It is not obvious to me how to fix this. There is some code
Rob Landley wrote:
[..]
I believe the toybox behavior is right?
We can simplify the above test by removing the p; entries that don't add
a line to the output:
echo -ne '1\n2\n3\n4\n' | sed -n '1{N;N;d};2,3p;4p'
Toybox just prints one 4, and gnu prints two of them. The difference is
Rob Landley wrote:
Clarification received from The Austin Group.
(Unfortunately the PDF he mentions costs $2500, and is thus completely
irrelevant in 2014.)
It also seems to be rendered correctly on the POSIX man page.
Isaac Dunham wrote:
[..]
A trickier bug is that rm -r dir will skip dir, saying
rm: dir: is a directory
I guess the fix involves rm -r calling rmdir instead of unlink.
unlinkat() also removes directories when given AT_REMOVEDIR.
The following patch makes rm pass the tests and it still asks
me
See the attached patch. Now all du tests are passed.
Felix
# HG changeset patch
# User Felix Janda felix.ja...@posteo.de
# Date 1411230095 -7200
# Sat Sep 20 18:21:35 2014 +0200
# Node ID edb1ee770843fb2528e42a77d40fbbdbc96e56ca
# Parent 434c4ae19f0559ab3ba6cd3d0a288b44c3c23949
Fix du test
luck...@vp.pl wrote:
[..]
getty.c requires sys/ttydefaults.h. Error of my compilation:
toys/pending/getty.c:168:29: error: 'CERASE' undeclared (first use in
this function)
The CERASE macro and more similar macros just are defined at
sys/ttydefaults.h in
musl libc. This header file
Rob Landley wrote:
On 04/13/14 17:18, Felix Janda wrote:
Rob Landley wrote:
[..]
Really the only interesting errno case from iconv is illegal sequence.
The rest just say ran out of input or ran out of output which is
what you expect from a conversion that's not at the end of the file yet
Rob Landley wrote:
Taking the remaining holiday time to close old reply windows and such.
I've ahd this one open a while... :)
On 09/06/2013 05:35:27 PM, Felix Janda wrote:
[...]
Are we normally blocking a lot of signals in other commands? Using
the
6 argument version instead
Rob Landley wrote:
[...]
D) Full of unicode characters where multiple input bytes become one
output character. (I am assuming fixed width font even for unicode; any
non-english speaker think that's a really bad assumption?)
A unicode character can consume 0, 1 or 2 columns on the terminal.
Ashwini Sharma wrote:
Hi Rob, All,
Attached is the TFTPD implementation.
Add it to hg, if you find it fine.
Let me know for any comments/improvements.
-Ashwini
Thanks for your submission. Some comments sprinkled into the code below.
Felix
/* tftpd.c - TFTP server.
*
* Copyright
Rob Landley wrote:
On 09/10/2013 04:22:41 PM, Felix Janda wrote:
Rob Landley wrote:
And yet a call to pselect needs its own sigprocmask() call as setup?
So... why are we using pselect again?
Didn't I say so? Before the call to pselect we block everything.
But why do we do
Rob Landley wrote:
Catching up on email while waiting at the airport. (Ohio Linuxfest!)
On 09/06/2013 04:48:10 PM, Felix Janda wrote:
Rob Landley wrote:
What The Hurd implements is not. Those religious fanatics are simply
not relevant, except sometimes as a warning of what _not_ to do
Ashwini Sharma wrote:
On Wed, Sep 11, 2013 at 5:30 AM, Felix Janda felix.ja...@posteo.de wrote:
Ashwini Sharma wrote:
[...]
Didn't use show_help(), as this doesn't exit whereas an exit is intended
for route.
may be show_help() can be updated to do
Ashwini Sharma wrote:
On Sat, Sep 7, 2013 at 11:47 PM, Isaac ibid...@gmail.com wrote:
On Mon, Sep 02, 2013 at 11:15:14AM +0900, Ashwini Sharma wrote:
HI Rob list,
Attached is the patch for _route_ command. It does display, add and del
functions for routing tables.
Have a
Rob Landley wrote:
On 09/01/2013 08:54:27 AM, Felix Janda wrote:
diff -r 587b7572aac2 -r 752d22ece0fe lib/lib.h
--- a/lib/lib.h Sun Sep 01 15:13:58 2013 +0200
+++ b/lib/lib.h Sun Sep 01 15:25:08 2013 +0200
@@ -201,4 +201,7 @@
char *astrcat (char *, char *);
char *xastrcat
in the foreground syslogd will daemonize() again when restarting. Could
one detect in daemonize() whether daemonizing is necessary?
Felix
# HG changeset patch
# User Felix Janda felix.ja...@posteo.de
# Date 1378041908 -7200
# Node ID 752d22ece0fe3fa9763fd0b6e231e653cc173890
# Parent
differently when a file occurs on the command
line more than once.
# HG changeset patch
# User Felix Janda felix.ja...@posteo.de
# Date 1377945041 -7200
# Node ID 3cd61d16aabec82505da96a142663cedbba8d12a
# Parent 9a059e9b3a17a372fc8b225f512af57c72f4eeaa
tail: Some fixes
- Rewrite most
a usual
logging file, it opens /dev/console instead.
Is there a system behind this? How about just failing when
something goes wrong before entering the select loop? Do we care
about cleaning up the socket files when we crash?
# HG changeset patch
# User Felix Janda felix.ja...@posteo.de
# Date
Rob Landley wrote:
On 08/24/2013 05:20:06 AM, Felix Janda wrote:
[...]
If none of these have been applied yet, I could prepare new patches
which don't leave the toy broken in between them.
I like the incremental nature of it, but I'm still not sure why patch 4
_doesn't_ seem to break
Rob Landley wrote:
On 08/20/2013 12:29:08 PM, Felix Janda wrote:
Rob Landley wrote:
On 08/19/2013 02:26:55 PM, Felix Janda wrote:
Hi,
I saw the comment in changeset 1017 on possible bugs in GNU grep.
The failing tests are for me:
testing grep -vo grep -vo one
Rob Landley wrote:
On 08/19/2013 02:26:55 PM, Felix Janda wrote:
Hi,
I saw the comment in changeset 1017 on possible bugs in GNU grep.
The failing tests are for me:
testing grep -vo grep -vo one input two\nthree\n
onetwoonethreeone\n
testing grep -Fx '' grep -Fx '' input
Rob Landley wrote:
On 08/18/2013 11:55:22 AM, Felix Janda wrote:
Rob Landley wrote:
On 08/10/2013 04:22:58 PM, Felix Janda wrote:
Right now syslogd.c contains code from sys/syslog.h declaring
the
arrays
prioritynames and facilitynames, which map human readable strings
# HG changeset patch
# User Felix Janda felix.ja...@posteo.de
# Date 1377033348 -7200
# Node ID c8e6b5f10c57bcca7859b4c2891dfdf346ecac6d
# Parent f9271a80fedc23b91559f0527da8e9c22d152b5d
syslogd: cleanup
- Remove structure fd_pair so that sigfd can go into GLOBALS
- Remove struct typedefs
Isaac wrote:
On Fri, Aug 02, 2013 at 10:35:30PM +0200, Felix Janda wrote:
Isaac wrote:
On Sat, Jul 27, 2013 at 09:56:53AM +0200, Felix Janda wrote:
[...]
Anyway Isaac is doing (or planning to do) a major rewrite enabling lspci
to read the pciid database for human readable names
Strake wrote:
On 28/07/2013, Felix Janda felix.ja...@posteo.de wrote:
Some comments below.
Thanks.
Thanks for your new patch.
[...]
+ for (ii = 0; ii toys.optc; ii++) {
You don't really need the index. Just loop over toys.optargs, which are
conveniently null terminated.
To me
Isaac wrote:
On Wed, Jul 24, 2013 at 09:20:51PM +0200, Felix Janda wrote:
Attached Isaac's toy edited to use toybuf instead of
dynamic memory allocation. It could look prettier, though...
Felix
Broken:
/toybox lspci -e
00:00.0 Class 0600: 8086
:27ac
00:02.0 Class 0300: 8086
Attached Isaac's toy edited to use toybuf instead of
dynamic memory allocation. It could look prettier, though...
Felix
/*
* lspci - written by Isaac Dunham
USE_LSPCI(NEWTOY(lspci, emkns:, TOYFLAG_USR|TOYFLAG_BIN))
config LSPCI
bool lspci
default n
help
usage: lspci [-ekmn]
List
Various fixes to logger in below patch.
Mainly inline parse_priority(). Many other small changes e.g. s/const//,
move around some variables, ...
-Felix
# HG changeset patch
# User Felix Janda felix.ja...@posteo.de
# Date 1374706109 -7200
# Node ID 8cc26924c2ef2e862c975a31167a685e18f555ec
Georgi Chorbadzhiyski wrote:
On 7/22/13 10:05 PM, Felix Janda wrote:
Isaac wrote:
I've written an lspci implementation.
Cool.
Currently it supports -emkn; -e is an extension (class is a 24-bit
number,
but lspci only shows 16 bits; one person on the Puppy forums mentioned
Rob Landley wrote:
Description of the paste cleanup that accidentally got checked in
during commit 944 because hg import -f has side effects.
http://landley.net/hg/toybox/rev/944
(Yes, that commit description is actively ironic. Scroll down to
patch.c.)
[...]
The accidental
Rob Landley wrote:
[...]
than count*sizeof(toybuf) and contain no newlines.
Count is initialized in a for loop and starts at 0 on line 164 so I
dunno what this means...
Sorry for the confusion. I meant the number of lines tail is told to
output.
[...]
diff -r f8db1f6ec4ab
. Are many shell
scripts in the wild using these options? Should they be implemented,
it looks like some code could be shared with find.
Maybe it would be better to use a goto for the error handling in test.c.
Felix
# HG changeset patch
# User Felix Janda felix.ja...@posteo.de
# Date 1374189502 -7200
Isaac wrote:
On Wed, Jul 03, 2013 at 08:56:46PM +0200, Felix Janda wrote:
Rob Landley wrote:
Tail has a double free somewhere. (Aboriginal's more/buildall.sh is
complaining, that uses toybox in host-tools.) Haven't had time to track
it down yet, wondering if anybody else could spot
Rob Landley wrote:
Tail has a double free somewhere. (Aboriginal's more/buildall.sh is
complaining, that uses toybox in host-tools.) Haven't had time to track
it down yet, wondering if anybody else could spot it.
From the behavior it's looking like it's on file close...
[...]
It seems
Hello,
the build of toybox was broken if CONFIG_TOYBOX_HELP was enabled but
CONFIG_HELP was disabled (and help.h was not yet generated). The
attached patch fixes it.
Felix
# HG changeset patch
# User Felix Janda felix.ja...@posteo.de
# Date 1367349103 -7200
# Node ID
Hi,
find -mtime didn't work as expected in the first place and I've broken
it even more with the cleanups. The attached patch should fix it (and
simplify the relevant code a bit).
Felix
# HG changeset patch
# User Felix Janda felix.ja...@posteo.de
# Date 1367010929 -7200
# Node ID
On 04/21/13 at 11:01pm, Rob Landley wrote:
[snip]
Ok, I thought more about the extra jumping around than about the
integer
checks. But actually it should only 2 additional jumps (jumping to the
case label and jumping out of the switch with break).
Disk access should totally dominate
On 04/21/13 at 12:38pm, Rob Landley wrote:
On 04/20/2013 01:39:10 PM, Felix Janda wrote:
Hello,
some more find cleanup in an attached patch.
The main change was to make some code in build_filter_list() less
repetitive using a suitable struct and a loop.
Problem: you defined
On 04/21/13 at 12:09am, Rob Landley wrote:
On 04/19/2013 05:28:27 PM, Felix Janda wrote:
[snip]
The functionality of get_access_str() is also implemented in the ls
toy
(likely much better). Should something like it be in the library?
Once code can be shared by a second command
(void)
{
/* parse filters, if present */
build_filter_list();
/* FIXTHIS - parse actions, if present */
dirtree_read(TT.dir, check_node_callback);
}
That seems to be obsolete (or I don't understand it at all).
Felix
# HG changeset patch
# User Felix Janda felix.ja...@posteo.de
# Date
in build_filter_list().
Felix
BTW: POSIX-1.2008 TC1 is out
# HG changeset patch
# User Felix Janda felix.ja...@posteo.de
# Date 1366471541 -7200
# Node ID 9419e28b582891a34eb1734dbec1643e573a1f3d
# Parent 1700c6bfc8f5d87b9f382bb8e334d43bda5f0720
More find cleanup
diff -r 1700c6bfc8f5 -r 9419e28b5828 toys/pending
.
find now passes the tests I've written but these miss out still a lot of
stuff which can go wrong.
Cheers,
Felix
# HG changeset patch
# User Felix Janda felix.ja...@posteo.de
# Date 1366317429 -7200
# Node ID 4985115191be966c915d8111da696b14495adc9f
# Parent
On 04/16/13 at 10:41am, Isaac Dunham wrote:
...
I forget where Landley commented on this, but he mentioned a few issues:
Here:
http://lists.landley.net/pipermail/toybox-landley.net/2013-April/000891.html
Felix
___
Toybox mailing list
Hello,
attached is a patch with a test script for find.
It tests only the expression handling and uses only primaries which are
currently implemented in the find toy.
Felix
# HG changeset patch
# User Felix Janda felix.ja...@posteo.de
# Date 1365936336 -7200
# Node ID
...
I'm not following this.
Rob
I'm sorry for the confusion. I was talking about the evaluate() function
in find.c (should have added the brackets ()) which evaluates a pre-fix
expression (which is not directly the command line to find). But Tim's
mail has cleared that up, hasn't it?
Felix
On 04/11/13 at 05:53pm, Tim Bird wrote:
On 04/11/2013 03:12 PM, Rob Landley wrote:
On 04/11/2013 04:37:36 PM, Felix Janda wrote:
Now I think that I know better how this toy works and see that my
cleanup
has broken it.
if (filter-op==OP_OR) {
- result
On 04/10/13 at 07:34pm, Rob Landley wrote:
snip
I think that some function parameters should be made const and that
the code could be made less repetitive.
I specify static because it allows the compiler to produce better
code, but I've never found const to actually produce better code.
Now I think that I know better how this toy works and see that my cleanup
has broken it.
if (filter-op==OP_OR) {
- result = evaluate(filter-next, node, fnext);
- result2 = evaluate(*fnext, node, fnext);
- if (result) {
- return result;
-
Hi Tim,
thanks for your feedback.
On 04/10/13 at 11:12am, Tim Bird wrote:
...
The cleanup was mainly mechanical and I still don't understand the toy
well. (Before and after the cleanup) there seems to be a problem with
the rule parsing/interpretation. For example
find . \( -type f
Tim, thanks for your thourough review.
Some (rather selective) comments:
Regarding the == 0 vs ! thing: Maybe I was too eager here. I think
that it does not make a great difference in readability but should be
uniform along in all the toys. Grepping in toys/posix ! is used
much more often but
Sorry for this repeated hair-splitting.
On 01/12/13 at 11:33pm, Rob Landley wrote:
On 01/10/2013 02:25:13 PM, Felix Janda wrote:
On 01/02/13 at 12:41am, Rob Landley wrote:
What I did was disable #3 in the case where cwd doesn't exist. So
the
new rule #3 is:
3) If cwd exists
On 12/30/12 at 05:47pm, Rob Landley wrote:
On 12/30/2012 05:16:41 AM, Felix Janda wrote:
On 12/30/12 at 04:43am, Rob Landley wrote:
POSIX contains many surprises. In the section on environment
variables it
says that $PWD should be set if pwd -P was specified. What happens
Hi,
the first patch adds the -L and -P options to pwd as specified by POSIX.
The test script again uses stat. This time in order to get inode numbers
of directories.
Felix
# HG changeset patch
# User Felix Janda felix.ja...@posteo.de
# Date 1356627399 -3600
# Node ID
When trying to implement the remaining options for pwd I could also test
toybox's group option handling.
The option string I wanted to use is: 0LP[!LP]
(It's the same for LP[!LP].)
With the current argparsing I get a segfault for pwd -L -P. When enabling
TOYBOX_DEBUG it says pwd: trailing [!LP].
Similar patches for mkfifo. mkfifo -m was actually already implemented
although the comments in mkfifo.c said it still had to be done. The tests
are very similar to the mkdir ones.
Felix
# HG changeset patch
# User Felix Janda felix.ja...@posteo.de
# Date 1356627134 -3600
# Node ID
On 12/01/12 at 12:42am, Rob Landley wrote:
On 11/30/2012 12:56:06 PM, Felix Janda wrote:
On 11/30/12 at 02:51am, Rob Landley wrote:
I updated wc to theoretically deal with buffer wraps better. In
reality
I haven't got UTF8 test data to run through this, and should
probably
find
On 11/30/12 at 02:51am, Rob Landley wrote:
I updated wc to theoretically deal with buffer wraps better. In reality
I haven't got UTF8 test data to run through this, and should probably
find some at some point.
Didn't the original version already deal well with it. (That's what the
strange
Hello,
attached are some simple tests for dirname and wc and
a fix for a small typo in another test script.
Posix specifies an -m option for wc, which toybox does
not implement. Should there be a test for this, too?
Why do the scripts actually use bash?
Regards,
Felix
diff -r b88859043af2 -r
69 matches
Mail list logo
