Re: [Toybox] [BUG] du applet prints wrong output for 2GB+ files

I do have an opinion, but I was out of comission for a couple days with eyestrain. (I fell asleep with my glasses on and rolled over them, bending them all out of shape. Then yesterday I accidentally sat on them and it bent them _back_. Yay? I should get a spare pair...) I don't like the

Re: [Toybox] [BUG] du applet prints wrong output for 2GB+ files

those particular ones are, though it would be better to explicitly cast to uintptr_t (or use a data/ptr union in struct dirtree) to make it clear we're doing this on purpose. i assumed rob would have a strong opinion one way or the other though... On Fri, Sep 30, 2016 at 1:39 AM, darken

Re: [Toybox] [BUG] du applet prints wrong output for 2GB+ files

I can confirm that the patch works. With the patch there are a few warnings during compilation though, safe to ignore? See: https://gist.github.com/d4rken/710cd1ab6265e062aaa2374e7be75452 2016-09-29 20:44 GMT+02:00 enh : > the attached patch fixes LP32 for me, without

Re: [Toybox] [BUG] du applet prints wrong output for 2GB+ files

the attached patch fixes LP32 for me, without obviously breaking anything. a quick grep didn't show any obvious case where making dirtree::extra larger would break anything, but rob will know better... On Thu, Sep 29, 2016 at 11:37 AM, darken wrote: > Why isn't `TT.total` the

Re: [Toybox] [BUG] du applet prints wrong output for 2GB+ files

works for me on Nexus 9. looks like du.c's TT.total is a signed long, so on LP32... On Thu, Sep 29, 2016 at 11:07 AM, darken wrote: > The du applet prints a ridiculously large size if the total size exceeds > 2GB. > > Reproduced on a Nexus5 with Android 6.0, but I don't think