Re: [Toybox] towards xzcat cleanup

2013-04-14 Thread Rob Landley
On 04/12/2013 09:19:45 AM, Isaac Dunham wrote: xzcat: more cleanup and some shrinking. -drop __always_inline (c. 1.5k of binary size), -remove the xz_dec_bcj_end and memzero macros (memeq is left because of negative returns), -disable XZ_DEC_SINGLE and XZ_DEC_PREALLOC, since we aren't using th

Re: [Toybox] towards xzcat cleanup

2013-04-12 Thread Isaac Dunham
xzcat: more cleanup and some shrinking. -drop __always_inline (c. 1.5k of binary size), -remove the xz_dec_bcj_end and memzero macros (memeq is left because of negative returns), -disable XZ_DEC_SINGLE and XZ_DEC_PREALLOC, since we aren't using them. (160 bytes) -Merge xz_dec_lzma2_end into xz_de

Re: [Toybox] towards xzcat cleanup

2013-04-11 Thread Rob Landley
On 04/11/2013 01:28:05 AM, Isaac Dunham wrote: More of same. Actually, it's not quite the same: -use crc_init(xz_crc32_table,1) -- I guessed on this one based on a match between magic constants, then tested it. First try was wrong, but this works.* (This is the sole difference in terms of actu

Re: [Toybox] towards xzcat cleanup

2013-04-10 Thread Rob Landley
On 04/10/2013 01:33:12 AM, Isaac Dunham wrote: Hello, First, I'd like to thank Landley for explaining the ifconfig cleanup... Yay! Glad it was useful. Would a similar description of the recent uuencode/uudecode cleanup help? That was fairly good code made tighter, so it's a less-obvious

[Toybox] towards xzcat cleanup

2013-04-09 Thread Isaac Dunham
Hello, First, I'd like to thank Landley for explaining the ifconfig cleanup... Second, I have a small compile-tested patch that applies some of those points to the mess that is xzcat, and reduces its ifdef forest slightly. xzcat is still nearly 2kloc (per sloccount), and still contains far too m