Re: [Toybox] [PATCH] Fix various seq bugs.

2017-05-23 Thread Rob Landley
On 05/22/2017 12:49 PM, enh wrote: > ping? Sigh. I had a message half-composed when my netbook crashed last week, noting things like how this: > Match GNU/busybox behavior with 0 increment. (An existing test was > failing on the host because of this.) Is unfixing a bug I fixed. I explicitly

Re: [Toybox] [PATCH] Fix various seq bugs.

2017-05-23 Thread Josh Gao
On Mon, May 22, 2017 at 11:54 PM, Rob Landley wrote: > > What's the use case for this code? Did they notice a difference from gnu > and say "any difference is a bug", or was somebody actually trying to do > something that broke? > The surprising behavior that I ran into was

[Toybox] request submit patch

2017-05-23 Thread aquanox
Hi everyone, I am a android developer and recently I am studying toybox, which located in external/toybox in android's source code. Today I found a trivial coding style issue in "toy_find" function. I had generated the patch according instruction in https://github.com/landley/toybox. The patch

Re: [Toybox] request submit patch

2017-05-23 Thread Rob Landley
On 05/23/2017 12:23 PM, aquanox wrote: > Hi everyone, I am a android developer and recently I am studying toybox, > which located in external/toybox in android's source code. > Today I found a trivial coding style issue in "toy_find" function. I had > generated the patch according instruction in >

[Toybox] [PATCH] Add and use xmmap.

2017-05-23 Thread enh
Everyone forgets that mmap returns MAP_FAILED rather than NULL on failure. Every use of mmap in toybox was either doing the wrong check, or no check at all (including the two I personally added). --- lib/lib.h | 1 + lib/xwrap.c| 7 ++