On 05/22/2017 12:49 PM, enh wrote:
> ping?
Sigh. I had a message half-composed when my netbook crashed last week,
noting things like how this:
> Match GNU/busybox behavior with 0 increment. (An existing test was
> failing on the host because of this.)
Is unfixing a bug I fixed. I explicitly
On Mon, May 22, 2017 at 11:54 PM, Rob Landley wrote:
>
> What's the use case for this code? Did they notice a difference from gnu
> and say "any difference is a bug", or was somebody actually trying to do
> something that broke?
>
The surprising behavior that I ran into was
Hi everyone, I am a android developer and recently I am studying toybox, which
located in external/toybox in android's source code.
Today I found a trivial coding style issue in "toy_find" function. I had
generated the patch according instruction in
https://github.com/landley/toybox. The patch
On 05/23/2017 12:23 PM, aquanox wrote:
> Hi everyone, I am a android developer and recently I am studying toybox,
> which located in external/toybox in android's source code.
> Today I found a trivial coding style issue in "toy_find" function. I had
> generated the patch according instruction in
>
Everyone forgets that mmap returns MAP_FAILED rather than NULL on failure.
Every use of mmap in toybox was either doing the wrong check, or no check
at all (including the two I personally added).
---
lib/lib.h | 1 +
lib/xwrap.c| 7 ++