Re: [Toybox] ToT still broken...

2018-09-21 Thread Rob Landley
On 09/21/2018 02:29 PM, Rob Landley wrote: > On 09/20/2018 02:46 PM, enh wrote: > I think I'm going to have to abandon gmail as "too broken to live". I'm not > looking forward to the admin hassle of setting up email somewhere else. (On > the > bright side, deleting spam manually is faster than

[Toybox] signal or xsignal for sigatexit()?

2018-09-21 Thread Rob Landley
signal() defaults to SA_RESTART, xsignal() uses sigaction() which does not. I'm not sure which is correct? (It's currently using signal() and things seem ok with what?) *shrug* The readall() code assumes no SA_RESTART. The main downside of signal by default I'm aware of is having to poll before

Re: [Toybox] [PATCH] file: fix more '%' conversions than data arguments warning.

2018-09-21 Thread Rob Landley
On 09/17/2018 06:11 PM, enh wrote: > Not sure how I messed this up, since both the toybox and Android build > systems warn about this. (Android has -Werror, so at least it kept me > from checking this in there.) I fixed this on sunday, just forgot to push. (And I saw this email in the web archive

Re: [Toybox] ToT still broken...

2018-09-21 Thread Rob Landley
On 09/20/2018 02:46 PM, enh wrote: > i see you fixed my file.c mistake (but don't appear to have seen my > patch --- is the list borked again?), but you've introduced a new one > since: Just caught up on my email and I don't see your i2c submission in the toybox folder, looks like gmail's spam

Re: [Toybox] ToT still broken...

2018-09-21 Thread enh
On Fri, Sep 21, 2018 at 12:30 PM Rob Landley wrote: > > On 09/20/2018 02:46 PM, enh wrote: > > i see you fixed my file.c mistake (but don't appear to have seen my > > patch --- is the list borked again?), but you've introduced a new one > > since: > > Just caught up on my email and I don't see

Re: [Toybox] signal or xsignal for sigatexit()?

2018-09-21 Thread Gavin Howard
Rob, I'm not better than you at C, but I did have to dig deep into this for my `bc', so I thought I would offer my 2 cents. First off, sigaction() is complex, but it is better in every other way. It gives you a lot more options, has better ways of querying the current signal handlers, has better

Re: [Toybox] ToT still broken...

2018-09-21 Thread Rob Landley
On 09/20/2018 02:46 PM, enh wrote: > i see you fixed my file.c mistake (but don't appear to have seen my > patch --- is the list borked again?), but you've introduced a new one > since: > > external/toybox/main.c:160:9: error: taking the absolute value of > unsigned type 'unsigned long' has no