Re: [Toybox] FYI: kernel builds rely on GNU expr extensions

2019-05-02 Thread enh via Toybox
(fwiw, with an instrumented build of the 4.19 Android common kernel, i only see `expr 4 * 65536 + 019 * 256 + 037`. so i don't know what they're _really_ doing to hit this.) On Thu, May 2, 2019 at 9:15 AM Rob Landley wrote: > > On 5/1/19 3:23 PM, enh via Toybox wrote: > > so you know how i said

Re: [Toybox] [PATCH] Android moved the scheduler policy functions in Q.

2019-05-02 Thread Rob Landley
On 5/1/19 5:40 PM, enh via Toybox wrote: > They're forwarded to libprocessgroup, but we may as well go straight to > the source since neither library is in the NDK anyway. > > This code is unfortunate because it means that even `toybox true` ends > up pulling in a JSON parser at runtime, because

Re: [Toybox] FYI: kernel builds rely on GNU expr extensions

2019-05-02 Thread Rob Landley
On 5/1/19 3:23 PM, enh via Toybox wrote: > so you know how i said i wasn't going to use anything in pending for > the build? turns out i wasn't paying enough attention and accidentally > used expr... Eh, if you're deploying pending on the device using it in the build isn't that much more of a

Re: [Toybox] [PATCH] tar.test: workaround for mksh.

2019-05-02 Thread Rob Landley
On 5/1/19 2:36 PM, enh wrote: > thanks. thanks for improving my echo -E patch too --- i knew about the > syntax for "error if given more than one of these options", but not > "take the last of this set to appear". Options switching other options off is pretty common and needed a thing. (Another

Re: [Toybox] [PATCH] Android moved the scheduler policy functions in Q.

2019-05-02 Thread enh via Toybox
On Thu, May 2, 2019 at 9:35 AM Rob Landley wrote: > > On 5/1/19 5:40 PM, enh via Toybox wrote: > > They're forwarded to libprocessgroup, but we may as well go straight to > > the source since neither library is in the NDK anyway. > > > > This code is unfortunate because it means that even `toybox

Re: [Toybox] FYI: kernel builds rely on GNU expr extensions

2019-05-02 Thread enh via Toybox
On Thu, May 2, 2019 at 9:15 AM Rob Landley wrote: > > On 5/1/19 3:23 PM, enh via Toybox wrote: > > so you know how i said i wasn't going to use anything in pending for > > the build? turns out i wasn't paying enough attention and accidentally > > used expr... > > Eh, if you're deploying pending

[Toybox] pathological case in sed s///g

2019-05-02 Thread enh via Toybox
i've known about this for a couple of days and haven't had time to look at it properly yet, so i should mention it here... if you have a file with a 1MiB line of 'x'es and you sed 's/x/y/g', BSD or GNU sed finishes immediately, but toybox takes forever.

[Toybox] [PATCH] env: fix case where a variable is replaced.

2019-05-02 Thread enh via Toybox
Found when trying to update the toybox prebuilt used for the Android build. Also add the corresponding test. --- lib/env.c | 4 +--- tests/env.test | 2 ++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/env.c b/lib/env.c index 35ef688c..bc23b753 100644 --- a/lib/env.c