Re: [Toybox] test flakiness sitrep

2019-08-15 Thread Rob Landley
On 8/14/19 11:58 PM, enh wrote: > On Mon, Aug 12, 2019 at 8:52 PM Rob Landley wrote: >> >> On 8/12/19 3:33 PM, enh via Toybox wrote: >>> last week i turned on the toybox tests in presubmit for changes to >>> toybox in AOSP, and postsubmit otherwise. so we have a fair bit of >>> data now (sadly

Re: [Toybox] [PATCH] find.test: fix test expectation for BSD libcs.

2019-08-15 Thread Rob Landley
On 8/14/19 8:06 PM, enh via Toybox wrote: > glibc says "Too many levels of symbolic links", but BSD says "Too many > symbolic links encountered". And if you're running the test against a localized chinese libc the error message is something else entirely. Don't depend on it. I write tests to

Re: [Toybox] [PATCH] find.test: fix test expectation for BSD libcs.

2019-08-15 Thread Rob Landley
On 8/15/19 11:00 AM, enh wrote: > On Thu, Aug 15, 2019 at 2:00 AM Rob Landley wrote: >> >> On 8/14/19 8:06 PM, enh via Toybox wrote: >>> glibc says "Too many levels of symbolic links", but BSD says "Too many >>> symbolic links encountered". >> >> And if you're running the test against a

Re: [Toybox] [PATCH] find.test: fix test expectation for BSD libcs.

2019-08-15 Thread enh via Toybox
On Thu, Aug 15, 2019 at 2:00 AM Rob Landley wrote: > > On 8/14/19 8:06 PM, enh via Toybox wrote: > > glibc says "Too many levels of symbolic links", but BSD says "Too many > > symbolic links encountered". > > And if you're running the test against a localized chinese libc the error > message is

Re: [Toybox] test flakiness sitrep

2019-08-15 Thread enh via Toybox
On Thu, Aug 15, 2019 at 3:36 AM Rob Landley wrote: > > > > On 8/14/19 11:58 PM, enh wrote: > > On Mon, Aug 12, 2019 at 8:52 PM Rob Landley wrote: > >> > >> On 8/12/19 3:33 PM, enh via Toybox wrote: > >>> last week i turned on the toybox tests in presubmit for changes to > >>> toybox in AOSP, and

Re: [Toybox] test flakiness sitrep

2019-08-15 Thread Rob Landley
On 8/15/19 11:35 AM, enh wrote: > On Thu, Aug 15, 2019 at 3:36 AM Rob Landley wrote: >> Working as fast as I can. Hobby time is finite. :( >> >> (Did you know busybox hush is 11000 lines and busybox ash is 14000? I thought >> they were smaller. Hadn't looked at either in years, did a wc on

[Toybox] [PATCH] find.test: allow any error message about symlink loops.

2019-08-15 Thread enh via Toybox
glibc says "Too many levels of symbolic links", but BSD says "Too many symbolic links encountered". Until it becomes a problem, allow any error message. --- tests/find.test | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) From 8d4540c8c9b6171b08b46dead178d56bc6105581 Mon Sep 17