[Toybox] bash continues to confuse me.

2020-06-17 Thread Rob Landley
Trying to figure out when spaces are and aren't allowed in ${blah} led to asking why echo ${!a* } is an error but ${!a@ } isn't (when there are no variables starting with a), and I eventually worked out that: $ X=PWD $ echo ${!X@Q} '/home/landley/toybox/clean' Is going on? Which is just

Re: [Toybox] GitHub Action Example

2020-06-17 Thread enh via Toybox
On Wed, Jun 17, 2020 at 10:26 AM dmccunney wrote: > > On Tue, Jun 16, 2020 at 4:27 PM enh via Toybox > wrote: > > (i'm personally looking forward to the web editor they've talked about, > > if it's anything close to Visual Studio Code --- which it ought to be, given > > that that's just

Re: [Toybox] tests

2020-06-17 Thread Rob Landley
> i'm not sure i understand the intent behind this change: > > commit 7f062f2dcfa5511139476e1aef8db74f49566432 > Author: Rob Landley > Date: Tue Nov 20 17:50:05 2018 -0600 > > Skip tests that don't have the executable bit set unless $TEST_ALL set. I blogged about it when it went in:

Re: [Toybox] GitHub Action Example

2020-06-17 Thread dmccunney
On Tue, Jun 16, 2020 at 4:27 PM enh via Toybox wrote: > (i'm personally looking forward to the web editor they've talked about, > if it's anything close to Visual Studio Code --- which it ought to be, given > that that's just Javascript.) You mean this? https://www.gitpod.io/ Looks like it

Re: [Toybox] [PATCH] file: add GIF version information.

2020-06-17 Thread Rob Landley
On 6/16/20 11:35 AM, enh via Toybox wrote: > This let me compare against the host for #225. > --- > tests/file.test | 2 +- > toys/posix/file.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) Applied, but: $ VERBOSE=1 TEST_HOST=1 make test_file scripts/test.sh file PASS: file

Re: [Toybox] GitHub Action Example

2020-06-17 Thread Rob Landley
On 6/16/20 3:27 PM, enh wrote: > On Mon, Jun 15, 2020 at 4:05 PM Rob Landley wrote: >> >> On 6/15/20 1:42 PM, enh wrote: >>> On Mon, Jun 15, 2020 at 11:05 AM Rob Landley wrote: > i don't actually remember us ever having an aarch64-specific issue. > (funnily enough, a 32-bit x86 build

Re: [Toybox] generating toybox test coverage data

2020-06-17 Thread Rob Landley
On 6/16/20 5:41 PM, enh via Toybox wrote: > TL;DR: the current state of test coverage looks like: > > function: 59.85% (468/782) > line: 56.17% (12111/21560) > region: 53.61% (11280/21039) See "test error paths", better coverage for existing tests, adding tests for commands that have no

Re: [Toybox] GitHub Action Example

2020-06-17 Thread Eric Molitor
We are extremely busy at work so coming back to this thread later than I intended. I also have mixed feelings about MSFT and GithHub but in some ways why not take advantage of them and exploit what they are offering. I don't believe there is any significant coupling to MSFT and it's a relatively