Re: [Toybox] [PATCH] dirtree_path: always honor size request.

2020-10-15 Thread enh via Toybox
thanks. your cleanup works too --- i'd used xzalloc because i'm paranoid, but since tar is using strcat() to append "/" that's fine :-) On Thu, Oct 15, 2020 at 1:47 PM Rob Landley wrote: > > On 10/14/20 3:19 PM, enh via Toybox wrote: > > tar asks dirtree_path() to reserve space for a trailing

Re: [Toybox] [PATCH] dirtree_path: always honor size request.

2020-10-15 Thread Rob Landley
On 10/14/20 3:19 PM, enh via Toybox wrote: > tar asks dirtree_path() to reserve space for a trailing '/', but recent > changes broke that for the case that was resolving to just a strdup(). Oops. Applied. Thanks, Rob ___ Toybox mailing list

Re: [Toybox] sort -V test?

2020-10-15 Thread Rob Landley
On 10/15/20 6:59 PM, enh wrote: > one reason bionic doesn't implement strverscmp() is that afaik not > even the GNU tools use it. they all have slightly different ideas > about how versions should be sorted :-/ I don't use it either, I did the sorting myself. But they changed how the sorting

Re: [Toybox] [PATCH] tar: fix heap buffer overrun.

2020-10-15 Thread Rob Landley
On 10/15/20 7:45 PM, enh wrote: > On Thu, Oct 15, 2020 at 5:21 PM Rob Landley wrote: >> >> On 10/14/20 3:21 PM, enh wrote: >>> i've sent a new fix that just touches dirtree_path() so that it always >>> honors the size request again. >> >> Applied, and then cosmetically fiddled with because I

Re: [Toybox] [PATCH] dirtree_path: always honor size request.

2020-10-15 Thread Rob Landley
On 10/14/20 3:19 PM, enh via Toybox wrote: > tar asks dirtree_path() to reserve space for a trailing '/', but recent > changes broke that for the case that was resolving to just a strdup(). > > Caught by `export ASAN=1` and `make test_tar`. P.S. I just downloaded ndk-21d to see if it had been

Re: [Toybox] sort -V test?

2020-10-15 Thread enh via Toybox
one reason bionic doesn't implement strverscmp() is that afaik not even the GNU tools use it. they all have slightly different ideas about how versions should be sorted :-/ (i'll also note that the old behavior matches sort's/librarians' general "something comes before nothing" rule, so the new

Re: [Toybox] [PATCH] tar: fix heap buffer overrun.

2020-10-15 Thread enh via Toybox
On Thu, Oct 15, 2020 at 5:21 PM Rob Landley wrote: > > On 10/14/20 3:21 PM, enh wrote: > > i've sent a new fix that just touches dirtree_path() so that it always > > honors the size request again. > > Applied, and then cosmetically fiddled with because I do that. > > >> but I leave for the

[Toybox] [PATCH] chattr.test: don't fail on f2fs with compression enabled.

2020-10-15 Thread enh via Toybox
f2fs with compression enabled only lets you `chattr +c` on an empty file. --- tests/chattr.test | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) From 18b5e9287d7203795f703797d54c98c2f04140b0 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Thu, 15 Oct 2020 16:48:57 -0700 Subject:

Re: [Toybox] watchdog: shutdown on SIGINT when in foreground

2020-10-15 Thread Rob Landley
On 10/14/20 4:32 PM, Patrick Oppenlander wrote: > Hi, > > I was recently testing a watchdog driver and found it to be quite > helpful to catch SIGINT when running "watchdog -F". > > Trivial patch attached. Not sure if you want to catch both signals or > switch like the patch does. I'm not a

[Toybox] sort -V test?

2020-10-15 Thread Rob Landley
Following up in the "promote more tests" todo item... Back when I implemented sort -V, it passed the tests on the host. But since then I've switched off of Ubuntu (because they end of lifed the last version without systemd) to Devuan, and the -rc and -pre stuff in test_sort is backwards now:

Re: [Toybox] [PATCH] dirtree_path: always honor size request.

2020-10-15 Thread enh via Toybox
yeah, that's unlikely to ever be supported. but note that you can use `export ASAN=1` on the *host*. that's where i did my testing because it's way faster than cross compiling and syncing and running on a 10x slower cpu! On Thu, Oct 15, 2020 at 4:53 PM Rob Landley wrote: > > On 10/14/20 3:19 PM,

Re: [Toybox] [PATCH] tar: fix heap buffer overrun.

2020-10-15 Thread Rob Landley
On 10/14/20 3:21 PM, enh wrote: > i've sent a new fix that just touches dirtree_path() so that it always > honors the size request again. Applied, and then cosmetically fiddled with because I do that. >> but I leave for the airport to fly back to Japan in 2 hours. (Part of the >> reason I've