Re: [Toybox] Graff and bc

>> Before I answer your questions, I have good news: in the midst of >> fixing bugs, I was still able to reduce the line count, even though I >> had to add quite a bit to fix bugs. > > Winding a spring tighter and figuring out how to make a watch with half as > much > metal are two different

Re: [Toybox] Graff and bc

On 03/15/2018 11:47 AM, Gavin Howard wrote: > Before I answer your questions, I have good news: in the midst of > fixing bugs, I was still able to reduce the line count, even though I > had to add quite a bit to fix bugs. Winding a spring tighter and figuring out how to make a watch with half as

Re: [Toybox] Graff and bc

I am talked to another person that would like the bc (for a Linux distro) about making the VM global. He said that yes, he thought it would be better. Because of that, if you want it, I will do it. Gavin H. On Thu, Mar 15, 2018 at 11:50 AM, Gavin Howard wrote: > Oh, I

Re: [Toybox] Graff and bc

Oh, I guess another advantage to making the BcVm instance global would be that I could inline bc_vm_init() and bc_vm_free(). GH On Thu, Mar 15, 2018 at 10:47 AM, Gavin Howard wrote: > Before I answer your questions, I have good news: in the midst of > fixing bugs, I was

Re: [Toybox] Graff and bc

Before I answer your questions, I have good news: in the midst of fixing bugs, I was still able to reduce the line count, even though I had to add quite a bit to fix bugs. Non-comprehensive list of bugs fixed: * Number printing * String printing * Various math bugs * Recursion stomping on local

Re: [Toybox] Graff and bc

I am about to try to implement your changes to bc_exec (and maybe bc_vm_init) in my release script. While doing so, if you would like, it would make sense to try to remove the BcStatus enum and replace it with either #defines (chars, so I can assign right to toys.retval) or something else of your

Re: [Toybox] Graff and bc

> And still not on the list. Oh well. Actually, that *was* sent to the list; I just also sent it to you directly. I won't make that mistake again. I will only send things to the list. >> That is a really good email, and I guess we have had a bit of >> miscommunication about this. >> >> To me, I

Re: [Toybox] Graff and bc

On 03/13/2018 10:05 AM, Gavin Howard wrote: > Also, bc_code is equivalent to "toys.optflags & FLAG_c", not > "toys.optflags & FLAG_i." FLAG_i is for bc_interactive. > GH This is why I want those regression tests. :) Rob ___ Toybox mailing list

Re: [Toybox] Graff and bc

Also, bc_code is equivalent to "toys.optflags & FLAG_c", not "toys.optflags & FLAG_i." FLAG_i is for bc_interactive. GH On Tue, Mar 13, 2018 at 8:49 AM, Gavin Howard wrote: > Rob, > > If you inline bc_exec() and bc_vm_init(), I am not sure that I will be > able to

Re: [Toybox] Graff and bc

Rob, If you inline bc_exec() and bc_vm_init(), I am not sure that I will be able to maintain this for you. bc_exec() is there just so I could keep the main function in my repo out of yours. Trying to make that work with my release script would be killer. I don't think saving 20 out of 9000 lines

Re: [Toybox] Graff and bc

On 03/12/2018 08:41 PM, Rob Landley wrote:> They're both intentionally small and simple, with descriptions in the commit > messages. I'll just post the third one to the list... Next pass, net deletion of 72 lines. landley@driftwood:~/toybox/toy3$ git diff toys/*/bc.c | diffstat bc.c | 174

Re: [Toybox] Graff and bc

On 03/12/2018 05:21 PM, Rob Landley wrote: >> I look forward to working with you. > > So instead of applying a series of cleanup patches, you want me to send them > to > you and then pull them back from you? > > *shrug* I can do that. Darn it, creating a branch doesn't check out the branch, so

Re: [Toybox] Graff and bc

On 03/12/2018 03:43 PM, Gavin Howard wrote: > Rob and all, > > I am the gdh that Christopher Graff was referring to > here:  > http://lists.landley.net/pipermail/toybox-landley.net/2018-March/009413.html. > I have a few notes. I am sympathetic to the drama happening off-list, but I have plenty

[Toybox] Graff and bc

Rob and all, I am the gdh that Christopher Graff was referring to here: http://lists.landley.net/pipermail/toybox-landley.net/2018-March/009413.html. I have a few notes. First, Graff's library was incompatible with the POSIX bc spec in subtle ways, and I was getting frustrated trying to work