Re: [Toybox] Release prep.

2018-02-09 Thread enh
On Fri, Feb 9, 2018 at 9:07 AM, Andreas Gampe wrote: > On Fri, Feb 9, 2018 at 7:36 AM, Rob Landley wrote: >> >> >> On 02/08/2018 10:44 AM, Andreas Gampe wrote: >>> Argh. I should have given you the full failure message (or be more >>> explicit in the

Re: [Toybox] Release prep.

2018-02-09 Thread Andreas Gampe
On Fri, Feb 9, 2018 at 7:36 AM, Rob Landley wrote: > > > On 02/08/2018 10:44 AM, Andreas Gampe wrote: >> Argh. I should have given you the full failure message (or be more >> explicit in the suggested solution) - sorry, my mistake. ASAN >> complains about a heap buffer overflow,

Re: [Toybox] Release prep.

2018-02-09 Thread Rob Landley
On 02/08/2018 10:44 AM, Andreas Gampe wrote: > Argh. I should have given you the full failure message (or be more > explicit in the suggested solution) - sorry, my mistake. ASAN > complains about a heap buffer overflow, not a null pointer access > (which should always kill top, not just under

Re: [Toybox] Release prep.

2018-02-08 Thread Andreas Gampe
Here's a symbolized ASAN abort after the import of your fix: ==7750==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x004b4be8 at pc 0x0056c377f290 bp 0x007ff7193f50 sp 0x007ff7193f48 READ of size 8 at 0x004b4be8 thread T0 Stack Trace: RELADDR FUNCTION

Re: [Toybox] Release prep.

2018-02-08 Thread Andreas Gampe
Argh. I should have given you the full failure message (or be more explicit in the suggested solution) - sorry, my mistake. ASAN complains about a heap buffer overflow, not a null pointer access (which should always kill top, not just under ASAN). Your fix was: struct carveup *otb = old.tb ?

Re: [Toybox] Release prep.

2018-02-08 Thread Andreas Gampe
Stack Trace: RELADDR FUNCTION FILE:LINE 7e253 top_common+6387 external/toybox/toys/posix/ps.c:1420 7c413 top_main+555 external/toybox/toys/posix/ps.c:1666 1f7db toy_exec+311 external/toybox/main.c:169 1ef77 toybox_main+91

Re: [Toybox] Release prep.

2018-02-07 Thread enh
On Mon, Feb 5, 2018 at 11:01 AM, enh wrote: > On Mon, Feb 5, 2018 at 10:43 AM, Rob Landley wrote: >> On 02/05/2018 11:34 AM, enh wrote: >>> On Sun, Feb 4, 2018 at 6:14 PM, Rob Landley wrote: For some reason I thought the next release

Re: [Toybox] Release prep.

2018-02-05 Thread enh
On Mon, Feb 5, 2018 at 10:43 AM, Rob Landley wrote: > On 02/05/2018 11:34 AM, enh wrote: >> On Sun, Feb 4, 2018 at 6:14 PM, Rob Landley wrote: >>> For some reason I thought the next release should happen the middle of >>> this month, but it turns out it was

Re: [Toybox] Release prep.

2018-02-05 Thread Rob Landley
On 02/05/2018 11:34 AM, enh wrote: > On Sun, Feb 4, 2018 at 6:14 PM, Rob Landley wrote: >> For some reason I thought the next release should happen the middle of >> this month, but it turns out it was the middle of last month. (Ok, I've >> been distracted.) >> >> So I'm giving

Re: [Toybox] Release prep.

2018-02-05 Thread enh
On Sun, Feb 4, 2018 at 6:14 PM, Rob Landley wrote: > For some reason I thought the next release should happen the middle of > this month, but it turns out it was the middle of last month. (Ok, I've > been distracted.) > > So I'm giving myself one more week to tidy up loose ends.

Re: [Toybox] Release prep and testcmd in tests/*.test

2017-09-25 Thread enh
say what you like about all the perl (https://android.googlesource.com/platform/external/mksh/+/master/src/check.pl), there's a lot to be said for the style it lets mksh tests be written in (https://android.googlesource.com/platform/external/mksh/+/master/src/check.t). it's inherently