On Fri, Mar 10, 2017 at 03:58:08AM -0600, Jiandi An wrote:
> +/*
> + * This is a TPM Command Response Buffer start method that invokes a
> + * Secure Monitor Call to requrest the firmware to execute or cancel
> + * a TPM 2.0 command.
> + */
> +static inline int tpm_crb_smc_start(unsigned long func_id)
> +{
> + struct arm_smccc_res res;
> +
> + arm_smccc_smc(func_id, 0, 0, 0, 0, 0, 0, 0, &res);
> + if (res.a0 != 0) {
> + WARN(1, "tpm_crb_smc_start() returns res.a0 = 0x%lx\n", res.a0);
> + return -EIO;
I don't think either of these WARN's are appropriate.
'dev_err(FIRMWARE_BUG' would be better.
Jason
------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
tpmdd-devel mailing list
tpmdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
