Re: [tpmdd-devel] [PATCH v2 0/3] TPM2.0: Added eventlog support for TPM2.0

2016-08-16 Thread Nayna
Hi Jason, Thanks for your inputs.. Further responses inline. On 08/13/2016 08:29 AM, Jason Gunthorpe wrote: > On Thu, Aug 11, 2016 at 04:18:34PM +0530, Nayna wrote: >>> #1. And the next somewhat pre-existing issue is that we call >>> tpm_bios_log_setup even if we don't have access to a bios log.

Re: [tpmdd-devel] [PATCH v2 1/3] TPM2.0: Refactored eventlog init functions.

2016-08-16 Thread Nayna
Sure Jason.. Taking care of split and other fixes in my V3 version of patch. Thanks & Regards, - Nayna On 08/13/2016 08:15 AM, Jason Gunthorpe wrote: > On Wed, Aug 10, 2016 at 04:42:20PM +0530, Nayna wrote: >> Thanks for reviewing. >> >> Sure, I will post next version with split as two patches

Re: [tpmdd-devel] [PATCH v2 2/3] TPM2.0: TPM Device Tree Documentation

2016-08-16 Thread Nayna
Hi Jason, Thanks for the review. Please find my responses inline. On 08/13/2016 08:12 AM, Jason Gunthorpe wrote: > On Fri, Aug 12, 2016 at 06:06:05PM +0530, Nayna wrote: >>> Documentation/devicetree/bindings/submitting-patches.txt >>> >>> And be sure to follow all the requirements, including CC

Re: [tpmdd-devel] [PATCH v2 0/3] TPM2.0: Added eventlog support for TPM2.0

2016-08-16 Thread Nayna
Hi Jarkko, On 08/16/2016 02:56 AM, Jarkko Sakkinen wrote: > On Fri, Aug 12, 2016 at 06:02:00PM +0530, Nayna wrote: Jarkko, Please let me know if it doesn't answer your question. >>> >>> 1. EFI does not pass the log by any means AFAIK before a boot loader >>> calls ExitBootServices(). >

[tpmdd-devel] [PATCH] tpm: fix a race condition tpm2_unseal_trusted()

2016-08-16 Thread Jarkko Sakkinen
Unseal and load operations should be done as an atomic operation. This commit introduces unlocked tpm_transmit() so that tpm2_unseal_trusted() can do the locking by itself. v2: Introduced an unlocked unseal operation instead of changing locking strategy in order to make less intrusive bug fix

Re: [tpmdd-devel] [PATCH v2 0/3] TPM2.0: Added eventlog support for TPM2.0

2016-08-16 Thread Jarkko Sakkinen
On Wed, Aug 17, 2016 at 12:46:40AM +0530, Nayna wrote: > Hi Jarkko, > > > > On 08/16/2016 02:56 AM, Jarkko Sakkinen wrote: > >On Fri, Aug 12, 2016 at 06:02:00PM +0530, Nayna wrote: > Jarkko, Please let me know if it doesn't answer your question. > >>> > >>>1. EFI does not pass the log by an

Re: [tpmdd-devel] [PATCH v2 0/3] TPM2.0: Added eventlog support for TPM2.0

2016-08-16 Thread Jarkko Sakkinen
On Tue, Aug 16, 2016 at 10:48:53PM +0300, Jarkko Sakkinen wrote: > On Wed, Aug 17, 2016 at 12:46:40AM +0530, Nayna wrote: > > Hi Jarkko, > > > > > > > > On 08/16/2016 02:56 AM, Jarkko Sakkinen wrote: > > >On Fri, Aug 12, 2016 at 06:02:00PM +0530, Nayna wrote: > > Jarkko, Please let me know i

Re: [tpmdd-devel] [PATCH] tpm: fix a race condition tpm2_unseal_trusted()

2016-08-16 Thread Jarkko Sakkinen
On Tue, Aug 16, 2016 at 10:38:22PM +0300, Jarkko Sakkinen wrote: > Unseal and load operations should be done as an atomic operation. This > commit introduces unlocked tpm_transmit() so that tpm2_unseal_trusted() > can do the locking by itself. > > v2: Introduced an unlocked unseal operation instea

Re: [tpmdd-devel] [PATCH v2 0/3] TPM2.0: Added eventlog support for TPM2.0

2016-08-16 Thread Nayna
Hi Jarkko, My response inline. On 08/17/2016 09:45 AM, Jarkko Sakkinen wrote: > On Tue, Aug 16, 2016 at 10:48:53PM +0300, Jarkko Sakkinen wrote: >> On Wed, Aug 17, 2016 at 12:46:40AM +0530, Nayna wrote: >>> Hi Jarkko, >>> >>> >>> >>> On 08/16/2016 02:56 AM, Jarkko Sakkinen wrote: On Fri, Aug