Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag

2016-10-19 Thread Winkler, Tomas
> > On Mon, Oct 17, 2016 at 11:42:24PM +0300, Jarkko Sakkinen wrote: > > Because all the existing hardware have HID MSFT0101 we end up always > > setting CRB_FL_CRB_START flag as a workaround for 4th Gen Core CPUs. > > Even if ACPI start is used, the driver will always issue also CRB start. Do

Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag

2016-10-19 Thread Jarkko Sakkinen
On Wed, Oct 19, 2016 at 10:28:29AM +, Winkler, Tomas wrote: > > > > > > On Mon, Oct 17, 2016 at 11:42:24PM +0300, Jarkko Sakkinen wrote: > > > Because all the existing hardware have HID MSFT0101 we end up always > > > setting CRB_FL_CRB_START flag as a workaround for 4th Gen Core CPUs. > > >

Re: [tpmdd-devel] [PATCH v5 4/7] tpm: fix the race condition between event log access and chip getting unregistered

2016-10-19 Thread Jarkko Sakkinen
On Tue, Oct 18, 2016 at 08:49:42PM -0400, Nayna Jain wrote: > Currently, the event log file operations are not serialized with > tpm_chip_unregister(), which can possibly cause a race condition. > > This patch fixes the race condition by: > - moving read_log() from fops to chip register. > - dis

Re: [tpmdd-devel] [PATCH v5 5/7] tpm: redefine read_log() to handle ACPI/OF at runtime

2016-10-19 Thread Jarkko Sakkinen
On Tue, Oct 18, 2016 at 08:49:43PM -0400, Nayna Jain wrote: > Currently, read_log() has two implementations: one for ACPI platforms > and the other for device tree(OF) based platforms. The proper one is > selected at compile time using Kconfig and #ifdef in the Makefile, > which is not the recommen

Re: [tpmdd-devel] [PATCH v5 7/7] tpm: replace or remove printk error messages

2016-10-19 Thread Jarkko Sakkinen
On Tue, Oct 18, 2016 at 08:49:45PM -0400, Nayna Jain wrote: > This patch removes the unnecessary error messages on failing to > allocate memory and replaces pr_err/printk with dev_dbg/dev_info > as applicable. > > Suggested-by: Jason Gunthorpe > Signed-off-by: Nayna Jain Reviewed-by: Jarkko Sak

Re: [tpmdd-devel] [PATCH v5 5/7] tpm: redefine read_log() to handle ACPI/OF at runtime

2016-10-19 Thread Jason Gunthorpe
On Wed, Oct 19, 2016 at 07:17:40PM +0300, Jarkko Sakkinen wrote: > > Suggested-by: Jason Gunthorpe > > Signed-off-by: Nayna Jain > > Reviewed-by: Jason Gunthorpe > > Do we have situation where we need a compiled kernel image that is > both DT and ACPI enabled? It is possible to enable DT on x8