Re: [tpmdd-devel] [PATCH 1/2] tpm/tpm-interface: place kdoc just above tpm_pcr_extend

2016-11-02 Thread Jarkko Sakkinen
On Tue, Nov 01, 2016 at 03:05:13AM +0200, Tomas Winkler wrote: > Place kdoc just above tpm_pcr_extend so it can be parsed > correctly. > > Signed-off-by: Tomas Winkler Reviewed-by: Jarkko Sakkinen /Jarkko > --- > drivers/char/tpm/tpm-interface.c | 16 > 1 file changed, 8 ins

Re: [tpmdd-devel] [PATCH 1/3] tpm tis: Do not print timeout messages twice

2016-11-02 Thread Jarkko Sakkinen
On Wed, Oct 26, 2016 at 04:28:44PM -0600, Jason Gunthorpe wrote: > The tis driver does a tpm_get_timeouts out side of tpm_chip_register, > and tpm_get_timeouts can print a message, resulting in two prints, eg: > > tpm tpm0: [Hardware Error]: Adjusting reported timeouts: A 1->75us B > 100

Re: [tpmdd-devel] [PATCH 2/3] tpm xen: Remove bogus tpm_chip_unregister

2016-11-02 Thread Jarkko Sakkinen
On Wed, Oct 26, 2016 at 04:28:45PM -0600, Jason Gunthorpe wrote: > tpm_chip_unregister can only be called after tpm_chip_register. > devm manages the allocation so no unwind is needed here. > > Fixes: afb5abc262e96 ("tpm: two-phase chip management functions") Cc: sta...@vger.kernel.org Reviewed-b

Re: [tpmdd-devel] [PATCH 3/3] tpm: Get rid of TPM_CHIP_FLAG_REGISTERED

2016-11-02 Thread Jarkko Sakkinen
On Wed, Oct 26, 2016 at 04:28:46PM -0600, Jason Gunthorpe wrote: > This is no longer necessary, all calls to tpm_chip_unregister happen > in remove() callbacks. > > Signed-off-by: Jason Gunthorpe Reviewed-by: Jarkko Sakkinen /Jarkko > --- > drivers/char/tpm/tpm-chip.c | 5 - > drivers/ch

Re: [tpmdd-devel] [PATCH 04/12] xen: make use of xenbus_read_unsigned() in xen-tpmfront

2016-11-02 Thread Jarkko Sakkinen
On Mon, Oct 31, 2016 at 05:48:22PM +0100, Juergen Gross wrote: > Use xenbus_read_unsigned() instead of xenbus_scanf() when possible. > This requires to change the type of one read from int to unsigned, > but this case has been wrong before: negative values are not allowed > for the modified case. >

Re: [tpmdd-devel] [PATCH v5 1/7] tpm: define a generic open() method for ascii & bios measurements

2016-11-02 Thread Jarkko Sakkinen
On Tue, Oct 18, 2016 at 08:49:39PM -0400, Nayna Jain wrote: > open() method for event log ascii and binary bios measurements file > operations are very similar. This patch refactors the code into a > single open() call by passing seq_operations as i_node->private data. > > Suggested-by: Jason Gunt

Re: [tpmdd-devel] [PATCH v5] tpm_tis: Check return values from get_burstcount.

2016-11-02 Thread Jarkko Sakkinen
On Fri, Oct 28, 2016 at 07:28:15PM +0300, Jarkko Sakkinen wrote: > On Thu, Oct 27, 2016 at 02:50:09PM -0700, Josh Zimmerman wrote: > > If the TPM we're connecting to uses a static burst count, it will report > > a burst count of zero throughout the response read. However, get_burstcount > > assumes

[tpmdd-devel] [PATCH] tpm: transition tpm_vtpm_proxy documentation to the Sphinx

2016-11-02 Thread Jarkko Sakkinen
Transitioned the tpm_vtpm_proxy documentation to the Sphinx infrastructure and removed parts from the documentation that are easier to pull from the sources. Restructured vtpm_proxy.h and tpm_vtpm_proxy.c to be compatible with this approach and wrote associated documentation comments. Signed-off-b

Re: [tpmdd-devel] [PATCH] tpm: transition tpm_vtpm_proxy documentation to the Sphinx

2016-11-02 Thread Stefan Berger
Jarkko Sakkinen wrote on 11/02/2016 12:01:56 PM: > > Transitioned the tpm_vtpm_proxy documentation to the Sphinx > infrastructure and removed parts from the documentation that are easier > to pull from the sources. Restructured vtpm_proxy.h and tpm_vtpm_proxy.c > to be compatible with this appr