Re: [tpmdd-devel] [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array

2016-11-25 Thread Jarkko Sakkinen
On Thu, Nov 24, 2016 at 09:53:13AM -0700, Jason Gunthorpe wrote: > On Thu, Nov 24, 2016 at 03:57:23PM +0200, Jarkko Sakkinen wrote: > > I manually added the changes to: > > > > tpm: replace dynamically allocated bios_dir with a static array > > For this patch.. > > Could drop 'int rc' from tpm

Re: [tpmdd-devel] [PATCH RFC 2/2] tpm: refactor tpm2_get_tpm_pt to tpm2_getcap_cmd

2016-11-25 Thread Jarkko Sakkinen
On Thu, Nov 24, 2016 at 07:12:57PM +0530, Nayna wrote: > > > On 11/15/2016 05:18 AM, Jarkko Sakkinen wrote: > > On Fri, Nov 11, 2016 at 04:02:43PM -0800, Jarkko Sakkinen wrote: > > > On Fri, Nov 11, 2016 at 09:51:45AM +0530, Nayna wrote: > > > > > > > > > > > > On 10/09/2016 03:44 PM, Jarkko Sa

Re: [tpmdd-devel] [PATCH v5 3/3] tpm: add securityfs support for TPM 2.0 firmware event log

2016-11-25 Thread Jarkko Sakkinen
On Thu, Nov 24, 2016 at 09:51:03PM -0500, Stefan Berger wrote: > On 11/24/2016 04:10 PM, Jarkko Sakkinen wrote: > > On Wed, Nov 23, 2016 at 12:27:37PM -0500, Nayna Jain wrote: > > > Unlike the device driver support for TPM 1.2, the TPM 2.0 does > > > not support the securityfs pseudo files for disp

Re: [tpmdd-devel] [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array

2016-11-25 Thread Jason Gunthorpe
On Fri, Nov 25, 2016 at 10:08:38AM +0200, Jarkko Sakkinen wrote: > > This is no good at this point in the series - we need the ENODEV > > detection in tpm_chip_register() from the 'Fix handle of missing event > > log' moved into this patch, because it now returns ENODEV due to > > sercurityfs > >

Re: [tpmdd-devel] [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c

2016-11-25 Thread Jason Gunthorpe
On Thu, Nov 24, 2016 at 11:01:05PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 12:38:30PM -0700, Jason Gunthorpe wrote: > > On Wed, Nov 23, 2016 at 12:27:35PM -0500, Nayna Jain wrote: > > > The device driver code for the event log has the init functions and > > > TPM 1.2 parsing logic b

Re: [tpmdd-devel] [PATCH v5 3/3] tpm: add securityfs support for TPM 2.0 firmware event log

2016-11-25 Thread Jason Gunthorpe
On Thu, Nov 24, 2016 at 11:10:57PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 12:27:37PM -0500, Nayna Jain wrote: > > Unlike the device driver support for TPM 1.2, the TPM 2.0 does > > not support the securityfs pseudo files for displaying the > > firmware event log. > > > > This patc