[tpmdd-devel] [PATCH] tpm_tis: unconstify array cmd_getticks

2017-09-07 Thread Colin King
From: Colin Ian King Remove const from cmd_getticks, fixes build warnings: drivers/char/tpm/tpm_tis_core.c:469:31: warning: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] rc = tpm_tis_send_data(chip, cmd_getticks, len);

[tpmdd-devel] [PATCH] tpm: constify transmit data pointers

2017-09-07 Thread Arnd Bergmann
Making cmd_getticks 'const' introduced a couple of harmless warnings: drivers/char/tpm/tpm_tis_core.c: In function 'probe_itpm': drivers/char/tpm/tpm_tis_core.c:469:31: error: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifi

[tpmdd-devel] NACK: [PATCH] tpm_tis: unconstify array cmd_getticks

2017-09-07 Thread Colin Ian King
On 07/09/17 09:42, Colin King wrote: > From: Colin Ian King > > Remove const from cmd_getticks, fixes build warnings: > > drivers/char/tpm/tpm_tis_core.c:469:31: warning: passing argument 2 of > 'tpm_tis_send_data' discards 'const' qualifier from pointer target > type [-Wdiscarded-qualifiers] >

Re: [tpmdd-devel] [PATCH 1/2] efi: call get_event_log before ExitBootServices

2017-09-07 Thread Ard Biesheuvel
On 7 September 2017 at 16:24, Thiebaud Weksteen wrote: > Hi Ard, > > Thanks for reviewing the patch. (Non-addressed comments are fixed in the > next patch set). > > On Wed, Sep 06, 2017 at 03:53:33PM +0100, Ard Biesheuvel wrote: >> Hi Thiebaud, >> >> On 6 September 2017 at 15:25, Thiebaud Weksteen

Re: [tpmdd-devel] [PATCH 1/2] efi: call get_event_log before ExitBootServices

2017-09-07 Thread Thiebaud Weksteen via tpmdd-devel
Hi Ard, Thanks for reviewing the patch. (Non-addressed comments are fixed in the next patch set). On Wed, Sep 06, 2017 at 03:53:33PM +0100, Ard Biesheuvel wrote: > Hi Thiebaud, > > On 6 September 2017 at 15:25, Thiebaud Weksteen wrote: > > With TPM 2.0, access to the event log is only possible

Re: [tpmdd-devel] [PATCH v2 0/4] additional TPM performance improvements

2017-09-07 Thread Jarkko Sakkinen
On Wed, Sep 06, 2017 at 08:56:35AM -0400, Nayna Jain wrote: > After further discussions with the Device Driver working group (ddwg), > the following changes were made: > > * Check for burstcount at least once to confirm the TPM is ready to accept > the data. Similarly, query for the TPM Expect st

Re: [tpmdd-devel] NACK: [PATCH] tpm_tis: unconstify array cmd_getticks

2017-09-07 Thread Jarkko Sakkinen
On Thu, Sep 07, 2017 at 03:02:32PM +0100, Colin Ian King wrote: > On 07/09/17 09:42, Colin King wrote: > > From: Colin Ian King > > > > Remove const from cmd_getticks, fixes build warnings: > > > > drivers/char/tpm/tpm_tis_core.c:469:31: warning: passing argument 2 of > > 'tpm_tis_send_data' dis

Re: [tpmdd-devel] [PATCH] tpm: constify transmit data pointers

2017-09-07 Thread Jarkko Sakkinen
On Thu, Sep 07, 2017 at 03:30:45PM +0200, Arnd Bergmann wrote: > Making cmd_getticks 'const' introduced a couple of harmless warnings: > > drivers/char/tpm/tpm_tis_core.c: In function 'probe_itpm': > drivers/char/tpm/tpm_tis_core.c:469:31: error: passing argument 2 of > 'tpm_tis_send_data' discar

Re: [tpmdd-devel] [PATCH v2] tpm-dev-common: Reject too short writes

2017-09-07 Thread Jarkko Sakkinen
On Wed, Sep 06, 2017 at 02:19:28PM +, alexander.stef...@infineon.com wrote: > > On Wed, Sep 06, 2017 at 03:42:33PM +0300, Jarkko Sakkinen wrote: > > > On Mon, Sep 04, 2017 at 07:36:42PM +0200, Alexander Steffen wrote: > > > > tpm_transmit() does not offer an explicit interface to indicate the >

Re: [tpmdd-devel] [PATCH] tpm: constify transmit data pointers

2017-09-07 Thread Jason Gunthorpe
On Thu, Sep 07, 2017 at 03:30:45PM +0200, Arnd Bergmann wrote: > Making cmd_getticks 'const' introduced a couple of harmless warnings: > > drivers/char/tpm/tpm_tis_core.c: In function 'probe_itpm': > drivers/char/tpm/tpm_tis_core.c:469:31: error: passing argument 2 of > 'tpm_tis_send_data' discar