On 09/12/2017 04:14 AM, Nasim, Kam wrote:
Hi folks,
I am building my TPM 2.0 driver as Kernel modules (tpm.ko,
tpm_tis_core.ko and tpm_tis.ko).
I noticed that while my /sys/kernel/security directory is created and
mounted to securityFS, it is empty.
Looking at tpm_bios_log_setup() in t
Removed those additions to the authors lists within last few years
that are not the original authors.
In some ways authors list does not make sense at all because git log is
really the ultimate authors list but it is fine to give yourself a bit
of credit in rare cases if you create a new driver in
Hi Thiebaud,
[auto build test ERROR on efi/next]
[also build test ERROR on next-20170913]
[cannot apply to char-misc/char-misc-testing linus/master v4.13]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
Thank you Nayna for getting back to me, yes I am using ACPI so that would
explain it.
Which brings me to my last issue, I am not seeing the PCRS file in either of
these locations:
/sys/devices/pnp0//pcrs
/sys/devices/platform/tpm_tis/pcrs
I am loading TPM as kernel modules so is this behavior n
Hi Thiebaud,
[auto build test ERROR on efi/next]
[also build test ERROR on next-20170913]
[cannot apply to char-misc/char-misc-testing linus/master v4.13]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
efi_tpm_eventlog_init should be in patch 0003 and not 0002.
I'll send a new version of the patch set once I've received more feedback.
On Wed, Sep 13, 2017 at 4:49 PM, kbuild test robot wrote:
> Hi Thiebaud,
>
> [auto build test ERROR on efi/next]
> [also build test
Fixed in next patch set
On Wed, Sep 13, 2017 at 6:27 PM, kbuild test robot wrote:
> Hi Thiebaud,
>
> [auto build test ERROR on efi/next]
> [also build test ERROR on next-20170913]
> [cannot apply to char-misc/char-misc-testing linus/master v4.13]
> [if your patch is applied to
The local variable 'attrs' should have the type __be32 instead of u32.
Fixes: 58472f5cd4f6 ("tpm: validate TPM 2.0 commands")
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm2-cmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm2-cmd.c b/drive
Use __le32 type for data in that format.
Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy")
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm_tis_spi.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis_spi.
The local variable 'handle' should have the type __be32 instead of u32.
Fixes: 745b361e989a ("tpm: infrastructure for TPM spaces")
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm2-space.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm2-space.
On Wed, Sep 13, 2017 at 10:26:20AM -0700, Jarkko Sakkinen wrote:
> The local variable 'attrs' should have the type __be32 instead of u32.
>
> Fixes: 58472f5cd4f6 ("tpm: validate TPM 2.0 commands")
> Signed-off-by: Jarkko Sakkinen
All 3 look good to me:
Reviewed-by: Jason Gunthorpe
Jason
Am 12. September 2017 17:45:08 GMT-07:00 schrieb Jarkko Sakkinen
:
>On Wed, Sep 06, 2017 at 08:56:36AM -0400, Nayna Jain wrote:
>> The TPM burstcount status indicates the number of bytes that can
>> be sent to the TPM without causing bus wait states. Effectively,
>> it is the number of empty by
On Mon, Sep 11, 2017 at 12:26:52PM +0200, Alexander Steffen wrote:
> The buffers used as tx_buf/rx_buf in a SPI transfer need to be DMA-safe.
> This cannot be guaranteed for the buffers passed to tpm_tis_spi_read_bytes
> and tpm_tis_spi_write_bytes. Therefore, we need to use our own DMA-safe
> buff
On 9/6/2017 12:12 PM, Jason Gunthorpe wrote:
The problem with this approach is that the TPM could totally block
the CPU for very long periods of time.
It seems very risky to enable..
How would you characterize "very long"?
The TPM vendors confirm that they empty the FIFO at internal speeds
Applied (as other similar) already to master because these are
very obvious things to fix. I'll wait for reviews and tests before
applying to next.
/Jarkko
On Wed, Sep 13, 2017 at 10:26:54AM -0700, Jarkko Sakkinen wrote:
> Use __le32 type for data in that format.
>
> Fixes: 0edbfea537d1 ("tpm/tp
On Mon, Sep 11, 2017 at 12:00:19PM +0200, Thiebaud Weksteen wrote:
> With TPM 1.2, the ACPI table ("TCPA") has two fields to recover the Event Log
> Area (LAML and LASA). These logs are useful to understand and rebuild the
> final values of PCRs.
>
> With TPM 2.0, the ACPI table ("TPM2") does not
Am 13. September 2017 11:52:12 GMT-07:00 schrieb Ken Goldman
:
>On 9/6/2017 12:12 PM, Jason Gunthorpe wrote:
>>
>> The problem with this approach is that the TPM could totally block
>> the CPU for very long periods of time.
>>
>> It seems very risky to enable..
>>
>
>How would you characteriz
On 2017-09-06 07:39, Jarkko Sakkinen wrote:
On Fri, Aug 25, 2017 at 06:28:55PM -0500, Jiandi An wrote:
This patch gets rid of dealing with intermediate flag for start method
and use start method value from ACPI table directly.
For ARM64, the locality is handled by Trust Zone in FW. The layout
Hi Jarkko, Mimi, James, Jason, and everybody else,
it would be great if we could find a slot to discuss in person how we proceed
with the mailing lists, patch flows and review cycles.
I know there were some discussions, but atleast for my part I did not get the
final conclusion on how we procee
On September 13, 2017 1:48:43 PM PST, Peter Huewe wrote:
>Hi Jarkko, Mimi, James, Jason, and everybody else,
>
>it would be great if we could find a slot to discuss in person how we
>proceed with the mailing lists, patch flows and review cycles.
>I know there were some discussions, but atleast fo
On Wed, Sep 13, 2017 at 12:14:21PM -0600, Jason Gunthorpe wrote:
> On Wed, Sep 13, 2017 at 10:26:20AM -0700, Jarkko Sakkinen wrote:
> > The local variable 'attrs' should have the type __be32 instead of u32.
> >
> > Fixes: 58472f5cd4f6 ("tpm: validate TPM 2.0 commands")
> > Signed-off-by: Jarkko Sa
On Wed, Sep 13, 2017 at 11:39:03AM -0700, Peter Huewe wrote:
>
>
> Am 12. September 2017 17:45:08 GMT-07:00 schrieb Jarkko Sakkinen
> :
> >On Wed, Sep 06, 2017 at 08:56:36AM -0400, Nayna Jain wrote:
> >> The TPM burstcount status indicates the number of bytes that can
> >> be sent to the TPM wit
On Wed, Sep 13, 2017 at 03:33:51PM -0500, anjia...@codeaurora.org wrote:
> On 2017-09-06 07:39, Jarkko Sakkinen wrote:
> > On Fri, Aug 25, 2017 at 06:28:55PM -0500, Jiandi An wrote:
> > > This patch gets rid of dealing with intermediate flag for start method
> > > and use start method value from AC
On Wed, Sep 13, 2017 at 10:48:43PM +0200, Peter Huewe wrote:
> Hi Jarkko, Mimi, James, Jason, and everybody else,
>
> it would be great if we could find a slot to discuss in person how we
> proceed with the mailing lists, patch flows and review cycles.
> I know there were some discussions, but at
Am 13. September 2017 16:21:25 GMT-07:00 schrieb Jarkko Sakkinen
:
>On Wed, Sep 13, 2017 at 10:48:43PM +0200, Peter Huewe wrote:
>> Hi Jarkko, Mimi, James, Jason, and everybody else,
>>
>> it would be great if we could find a slot to discuss in person how we
>> proceed with the mailing lists,
25 matches
Mail list logo