Re: [tpmdd-devel] [PATCH v5 7/7] tpm: replace or remove printk error messages

2016-10-20 Thread Nayna
On 10/20/2016 04:54 PM, Jarkko Sakkinen wrote: > On Thu, Oct 20, 2016 at 07:34:37AM +, Winkler, Tomas wrote: >>> On Tue, Oct 18, 2016 at 08:49:45PM -0400, Nayna Jain wrote: This patch removes the unnecessary error messages on failing to allocate memory and replaces pr_err/printk

Re: [tpmdd-devel] [PATCH v5 4/7] tpm: fix the race condition between event log access and chip getting unregistered

2016-10-20 Thread Jason Gunthorpe
On Tue, Oct 18, 2016 at 08:49:42PM -0400, Nayna Jain wrote: > + struct tpm_chip_seqops *chip_seqops; > + const struct seq_operations *seqops; > + struct tpm_chip *chip; > + > + inode_lock(inode); > + if (!inode->i_private) { > + inode_unlock(inode); > +

Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag

2016-10-20 Thread Jason Gunthorpe
On Thu, Oct 20, 2016 at 05:00:11PM +0300, Jarkko Sakkinen wrote: > > > I have a 4th Gen Core NUC where I experienced this issue. It reported > > > requiring only ACPI start but actually required ACPI + CRB start. The > > > comment could have been better. Shouldn't bios work arounds be keyed on

Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag

2016-10-20 Thread Jarkko Sakkinen
On Wed, Oct 19, 2016 at 07:09:28PM +0300, Jarkko Sakkinen wrote: > On Wed, Oct 19, 2016 at 10:28:29AM +, Winkler, Tomas wrote: > > > > > > > > > > On Mon, Oct 17, 2016 at 11:42:24PM +0300, Jarkko Sakkinen wrote: > > > > Because all the existing hardware have HID MSFT0101 we end up always >

Re: [tpmdd-devel] [PATCH v5 7/7] tpm: replace or remove printk error messages

2016-10-20 Thread Jarkko Sakkinen
On Thu, Oct 20, 2016 at 07:01:51PM +0530, Nayna wrote: > > > On 10/20/2016 01:04 PM, Winkler, Tomas wrote: > > > On Tue, Oct 18, 2016 at 08:49:45PM -0400, Nayna Jain wrote: > > > > This patch removes the unnecessary error messages on failing to > > > > allocate memory and replaces pr_err/printk

Re: [tpmdd-devel] [PATCH v5 7/7] tpm: replace or remove printk error messages

2016-10-20 Thread Jarkko Sakkinen
On Thu, Oct 20, 2016 at 07:34:37AM +, Winkler, Tomas wrote: > > On Tue, Oct 18, 2016 at 08:49:45PM -0400, Nayna Jain wrote: > > > This patch removes the unnecessary error messages on failing to > > > allocate memory and replaces pr_err/printk with dev_dbg/dev_info as > > > applicable. > > > >

Re: [tpmdd-devel] [PATCH v5 7/7] tpm: replace or remove printk error messages

2016-10-20 Thread Winkler, Tomas
> On Tue, Oct 18, 2016 at 08:49:45PM -0400, Nayna Jain wrote: > > This patch removes the unnecessary error messages on failing to > > allocate memory and replaces pr_err/printk with dev_dbg/dev_info as > > applicable. > > > > Suggested-by: Jason Gunthorpe > >

Re: [tpmdd-devel] [PATCH v5 5/7] tpm: redefine read_log() to handle ACPI/OF at runtime

2016-10-20 Thread Jarkko Sakkinen
On Wed, Oct 19, 2016 at 11:26:25AM -0600, Jason Gunthorpe wrote: > On Wed, Oct 19, 2016 at 07:17:40PM +0300, Jarkko Sakkinen wrote: > > > Suggested-by: Jason Gunthorpe > > > Signed-off-by: Nayna Jain > > > Reviewed-by: Jason Gunthorpe