[tpmdd-devel] [PATCH 2/3] tpm xen: Remove bogus tpm_chip_unregister

2016-10-26 Thread Jason Gunthorpe
tpm_chip_unregister can only be called after tpm_chip_register. devm manages the allocation so no unwind is needed here. Fixes: afb5abc262e96 ("tpm: two-phase chip management functions") --- drivers/char/tpm/xen-tpmfront.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [tpmdd-devel] [PATCH v5 7/7] tpm: replace or remove printk error messages

2016-10-26 Thread Nayna
On 10/26/2016 04:26 PM, Jarkko Sakkinen wrote: > On Wed, Oct 26, 2016 at 07:52:53AM +0530, Nayna wrote: >> >> >> On 10/21/2016 08:32 PM, Jarkko Sakkinen wrote: >>> On Fri, Oct 21, 2016 at 08:52:14AM +0530, Nayna wrote: On 10/20/2016 04:54 PM, Jarkko Sakkinen wrote: > On Thu,

[tpmdd-devel] [PATCH v2] tpm_tis: Allow tpm_tis to be bound using DT

2016-10-26 Thread Jason Gunthorpe
This provides an open firwmare driver binding for tpm_tis. OF is useful on arches where ACPI/PNP is not used. The tcg,tpm-tis-mmio register map interface is specified by the TCG. Signed-off-by: Jason Gunthorpe --- .../bindings/security/tpm/tpm_tis_mmio.txt

Re: [tpmdd-devel] [PATCH] tpm_tis: Allow tpm_tis to be bound using DT

2016-10-26 Thread Mark Rutland
On Wed, Oct 26, 2016 at 10:05:05AM -0600, Jason Gunthorpe wrote: > On Wed, Oct 26, 2016 at 01:55:27PM +0300, Jarkko Sakkinen wrote: > > On Tue, Oct 25, 2016 at 05:23:31PM -0600, Jason Gunthorpe wrote: > > > This provides an open firwmare driver binding for tpm_tis. OF > > > is useful on arches

Re: [tpmdd-devel] [PATCH] tpm_tis: Allow tpm_tis to be bound using DT

2016-10-26 Thread Mark Rutland
On Wed, Oct 26, 2016 at 10:01:53AM -0600, Jason Gunthorpe wrote: > On Wed, Oct 26, 2016 at 12:25:51PM +0100, Mark Rutland wrote: > > > > +Required properties: > > > + > > > +- compatible: should specify the actual hardware chip followed by the > > > + generic interface name "tcg,tpm_tis-spi"; >

Re: [tpmdd-devel] [PATCH] tpm_tis: Allow tpm_tis to be bound using DT

2016-10-26 Thread Jason Gunthorpe
On Wed, Oct 26, 2016 at 01:55:27PM +0300, Jarkko Sakkinen wrote: > On Tue, Oct 25, 2016 at 05:23:31PM -0600, Jason Gunthorpe wrote: > > This provides an open firwmare driver binding for tpm_tis. OF > > is useful on arches where ACPI/PNP is not used. > > > > The tcg,tpm_tis-mmio register map

Re: [tpmdd-devel] [PATCH] tpm_tis: Allow tpm_tis to be bound using DT

2016-10-26 Thread Jason Gunthorpe
On Wed, Oct 26, 2016 at 12:25:51PM +0100, Mark Rutland wrote: > > +Required properties: > > + > > +- compatible: should specify the actual hardware chip followed by the > > + generic interface name "tcg,tpm_tis-spi"; > > Please use '-' in comaptible strings rather than '_'. Erk, there is also

Re: [tpmdd-devel] [PATCH] tpm_tis: Allow tpm_tis to be bound using DT

2016-10-26 Thread Mark Rutland
On Tue, Oct 25, 2016 at 05:23:31PM -0600, Jason Gunthorpe wrote: > This provides an open firwmare driver binding for tpm_tis. OF > is useful on arches where ACPI/PNP is not used. > > The tcg,tpm_tis-mmio register map interface is specified by the TCG. > > Signed-off-by: Jason Gunthorpe

Re: [tpmdd-devel] [PATCH v5 7/7] tpm: replace or remove printk error messages

2016-10-26 Thread Jarkko Sakkinen
On Wed, Oct 26, 2016 at 07:52:53AM +0530, Nayna wrote: > > > On 10/21/2016 08:32 PM, Jarkko Sakkinen wrote: > > On Fri, Oct 21, 2016 at 08:52:14AM +0530, Nayna wrote: > > > > > > > > > On 10/20/2016 04:54 PM, Jarkko Sakkinen wrote: > > > > On Thu, Oct 20, 2016 at 07:34:37AM +, Winkler,

Re: [tpmdd-devel] [PATCH] tpm_tis: Allow tpm_tis to be bound using DT

2016-10-26 Thread Jarkko Sakkinen
On Tue, Oct 25, 2016 at 05:23:31PM -0600, Jason Gunthorpe wrote: > This provides an open firwmare driver binding for tpm_tis. OF > is useful on arches where ACPI/PNP is not used. > > The tcg,tpm_tis-mmio register map interface is specified by the TCG. > > Signed-off-by: Jason Gunthorpe

[tpmdd-devel] [PATCH v3 1/2] Documentation: tpm: add the IBM Virtual TPM device tree binding documentation

2016-10-26 Thread Nayna Jain
Virtual TPM, which is being used on IBM POWER7+ and POWER8 systems running POWERVM, is currently supported by tpm device driver but lacks the documentation. This patch adds the missing documentation for the existing support. Suggested-by: Jason Gunthorpe