Re: [tpmdd-devel] [PATCH v5 3/3] tpm: add securityfs support for TPM 2.0 firmware event log

On 11/24/2016 04:10 PM, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 12:27:37PM -0500, Nayna Jain wrote: >> Unlike the device driver support for TPM 1.2, the TPM 2.0 does >> not support the securityfs pseudo files for displaying the >> firmware event log. >> >> This patch enables support for

Re: [tpmdd-devel] [PATCH v5 3/3] tpm: add securityfs support for TPM 2.0 firmware event log

On Wed, Nov 23, 2016 at 12:27:37PM -0500, Nayna Jain wrote: > Unlike the device driver support for TPM 1.2, the TPM 2.0 does > not support the securityfs pseudo files for displaying the > firmware event log. > > This patch enables support for providing the TPM 2.0 event log in > binary form. TPM

Re: [tpmdd-devel] [PATCH v5 2/3] tpm: enhance read_log_of() to support Physical TPM event log

On Wed, Nov 23, 2016 at 12:27:36PM -0500, Nayna Jain wrote: > - memcpy(log->bios_event_log, __va(*basep), *sizep); > + if (of_property_match_string(np, "compatible", "IBM,vtpm") < 0) > + memcpy(chip->log.bios_event_log, __va(be64_to_cpup(basep)), > +

Re: [tpmdd-devel] [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c

On Wed, Nov 23, 2016 at 12:38:30PM -0700, Jason Gunthorpe wrote: > On Wed, Nov 23, 2016 at 12:27:35PM -0500, Nayna Jain wrote: > > The device driver code for the event log has the init functions and > > TPM 1.2 parsing logic both defined in same file(tpm_eventlog.c). > > > > Since the

Re: [tpmdd-devel] [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array

On Thu, Nov 24, 2016 at 03:57:23PM +0200, Jarkko Sakkinen wrote: > I manually added the changes to: > > tpm: replace dynamically allocated bios_dir with a static array For this patch.. Could drop 'int rc' from tpm1_chip_register, but it will come back in a later patch Could dump

Re: [tpmdd-devel] [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c

On 11/24/2016 10:13 PM, Jason Gunthorpe wrote: > On Thu, Nov 24, 2016 at 01:31:03PM +0530, Nayna wrote: > Since the initialization functions are common with the TPM 2.0 event log support, this patch splits tpm_eventlog.c to have only TPM 1.2 event log parsing logic and moves the

Re: [tpmdd-devel] [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c

On Thu, Nov 24, 2016 at 01:31:03PM +0530, Nayna wrote: > >>Since the initialization functions are common with the TPM 2.0 event > >>log support, this patch splits tpm_eventlog.c to have only TPM 1.2 > >>event log parsing logic and moves the init functions into > >>tpm_eventlog_init.c. > > > >I

Re: [tpmdd-devel] [PATCH v2 0/4] tpm: kdoc cleanup

On Wed, Nov 23, 2016 at 12:04:10PM +0200, Tomas Winkler wrote: > Cleanup tpm in-code documentation. > > Tomas Winkler (4): > tpm: add kdoc for tpm_transmit and tpm_transmit_cmd > tpm/tpm2-chip: fix kdoc errors > tmp: use pdev for parent device in tpm_chip_alloc > tpm/vtpm: fix kdoc

Re: [tpmdd-devel] [PATCH] tpm/tpm_tis_spi: drop duplicate header module.h

On Wed, Nov 23, 2016 at 11:18:53PM +0800, Geliang Tang wrote: > Drop duplicate header module.h from tpm_tis_spi.c. > > Signed-off-by: Geliang Tang Reviewed-by: Jarkko Sakkinen /Jarkko > --- > drivers/char/tpm/tpm_tis_spi.c | 1 - > 1

Re: [tpmdd-devel] [PATCH 2/4 v2] tpm/tpm2-chip: fix kdoc errors

On Wed, Nov 16, 2016 at 07:03:39PM +0200, Tomas Winkler wrote: > Use correct kdoc format, describe correct parameters and return values. > > Signed-off-by: Tomas Winkler Reviewed-by: Jarkko Sakkinen > --- > V2: rework and rebase of

Re: [tpmdd-devel] [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c

On 11/24/2016 01:08 AM, Jason Gunthorpe wrote: > On Wed, Nov 23, 2016 at 12:27:35PM -0500, Nayna Jain wrote: >> The device driver code for the event log has the init functions and >> TPM 1.2 parsing logic both defined in same file(tpm_eventlog.c). >> >> Since the initialization functions are