Re: [tpmdd-devel] [PATCH v2 3/3] tpm_crb: request and relinquish locality 0

On Mon, Dec 05, 2016 at 09:51:42PM +, Winkler, Tomas wrote: > > > > CC linux-security-module > > > > On Sat, Dec 03, 2016 at 07:52:13PM +0200, Jarkko Sakkinen wrote: > > > Request and relinquish locality for the driver use in order to be a > > > better citizen in a multi locality environment

Re: [tpmdd-devel] [PATCH v2 3/3] tpm_crb: request and relinquish locality 0

On Mon, Dec 05, 2016 at 09:32:35AM -0700, Jason Gunthorpe wrote: > On Sat, Dec 03, 2016 at 07:52:13PM +0200, Jarkko Sakkinen wrote: > > + iowrite32(CRB_LOC_CTRL_RELINQUISH, >regs_h->loc_ctrl); > > Since regs_h can be null shouldn't there be some guards ? Yes, there should. Thanks for pointing

Re: [tpmdd-devel] [PATCH v2 1/3] tpm_crb: map locality registers

On Mon, Dec 05, 2016 at 09:31:57PM +, Winkler, Tomas wrote: > > > > On Mon, Dec 05, 2016 at 12:07:51PM +, Winkler, Tomas wrote: > > > > > --- > > > > > drivers/char/tpm/tpm_crb.c | 96 > > > > > ++ > > > > > 1 file changed, 64 insertions(+), 32

Re: [tpmdd-devel] [PATCH v2 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd

> -Original Message- > From: Nayna [mailto:na...@linux.vnet.ibm.com] > Sent: Tuesday, December 06, 2016 11:17 > To: Jarkko Sakkinen ; Winkler, Tomas > > Cc: tpmdd-devel@lists.sourceforge.net; linux-ker...@vger.kernel.org >

Re: [tpmdd-devel] [PATCH v6 2/2] tpm: add securityfs support for TPM 2.0 firmware event log

On 11/30/2016 10:29 PM, Nayna wrote: > > > On 11/26/2016 09:17 PM, Jarkko Sakkinen wrote: >> On Sat, Nov 26, 2016 at 07:45:39AM -0500, Nayna Jain wrote: >>> Unlike the device driver support for TPM 1.2, the TPM 2.0 does >>> not support the securityfs pseudo files for displaying the >>> firmware